1623355 - Rename Android PGO builds to Android Shippable

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Description

[Ionuț Goldan [:igoldan]]

Firefox builds are no longer called PGO builds, rather shippable builds.
As all desktop builds have shifted towards this naming convention, so should the Android builds.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8) (PTO'ish until July 5)]

cc a bunch of people. not sure what all depends on the name of the platform; hoping others can chime in.

:igoldan, can you outline what changes need to be made on perf dashboards, tools, etc.

Comment 2

[Justin Wood (:Callek)]

I've already started working on this in https://bugzilla.mozilla.org/show_bug.cgi?id=1617484 -- I'm ok with a dupe either way, or merely doing a see-also/need-info between these two.

I know there is work to do to coordinate this at least.

Comment 3

[Ionuț Goldan [:igoldan]]

(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #1)

[...]
:igoldan, can you outline what changes need to be made on perf dashboards, tools, etc.

Regarding my team, I don't think we have to perform any changes. Last pgo/nightly/release -> shippable rename didn't involve any kind of treatment from our side. It only temporary made us blind on perf regressions, for about a day.

Comment 4

[Ionuț Goldan [:igoldan]]

Justin, I see bug 1617484 mostly tackles nightlies. In this bug, we're especially interested in renaming the PGOs from Android.
Thus, I'd say this is a separate bug. Is it something you or someone from your team can pick?

Comment 5

[Justin Wood (:Callek)]

Hrm, good point - I intend to do the same piece of work here, (turn PGO into Shippable and use the same jobs for what we ship on nightly) I just didn't get that far yet on the work.

I suppose this bug could be the one to tackle the pgo->use-shippable piece.

Comment 6

[Justin Wood (:Callek)]

Attachment: Bug 1623355 - Part 3/9 - Rename android pgo tests to -shippable/opt and adjust run-on-platforms to cope. r=aki

Depends on D73900

Comment 7

[Justin Wood (:Callek)]

Attachment: Bug 1623355 - Part 4/9 - Point tests based on pgo builds to use shippable builds. r=aki

Depends on D74306

Comment 8

[Justin Wood (:Callek)]

Attachment: Bug 1623355 - Part 5/9 - Rename pgo instrumentation steps to shippable. And make condition profiles use shippable. r=aki

Depends on D74307

Comment 9

[Justin Wood (:Callek)]

Attachment: Bug 1623355 - Part 6/9 - Remove Android PGO build types. r=aki

Depends on D74308

Comment 10

[Justin Wood (:Callek)]

Attachment: Bug 1623355 - Part 7/9 - Set treeherder symbols appropriately for Android Shippable. r=aki

Depends on D74309

Comment 11

[Justin Wood (:Callek)]

Attachment: Bug 1623355 - Part 8/9 - Set new shippable index's for Android shippable builds. r=aki

Depends on D74359

Comment 12

[Justin Wood (:Callek)]

:kats, I see that fpush-linux-android's preset currently runs:

• "build-android-api-16/debug",
• "build-android-api-16/opt",
• "build-android-api-16/pgo",
• "build-android-x86/opt",
• "build-android-x86_64/debug",
• "build-android-x86_64/opt",

Part 4 here removes `build-android-api-16/pgo - do you need that for your f-push preset or should I modify it to include the android-api-16-shippable?

Comment 13

[Kartikaya Gupta (email:[e-mail])]

Removing it should be ok. Thanks for checking!

Comment 14

[Justin Wood (:Callek)]

Attachment: Bug 1623355 - Part 2/9 - Add shippable as a valid target for performance test cron targets. r=aki

Comment 15

[Justin Wood (:Callek)]

Attachment: Bug 1623355 - Part 9/9 - Remove 'pgo' support from performance testing target tasks. r=aki

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de5f01ae37fa
Part 1/8 - Add shippable as a valid target for performance test cron targets. r=aki
https://hg.mozilla.org/integration/autoland/rev/dc3076515342
Part 2/8 - Rename android pgo tests to -shippable/opt and adjust run-on-platforms to cope. r=aki
https://hg.mozilla.org/integration/autoland/rev/888df247ba6e
Part 3/8 - Point tests based on pgo builds to use shippable builds. r=aki
https://hg.mozilla.org/integration/autoland/rev/b4ffd5ccbfc7
Part 4/8 - Rename pgo instrumentation steps to shippable. And make condition profiles use shippable. r=aki
https://hg.mozilla.org/integration/autoland/rev/fd76f6bc0797
Part 5/8 - Remove Android PGO build types. r=aki
https://hg.mozilla.org/integration/autoland/rev/87331010321a
Part 6/8 - Set treeherder symbols appropriately for Android Shippable. r=aki
https://hg.mozilla.org/integration/autoland/rev/001eb6623a75
Part 7/8 - Set new shippable index's for Android shippable builds. r=aki
https://hg.mozilla.org/integration/autoland/rev/f94e3f8179a5
Part 8/8 - Remove 'pgo' support from performance testing target tasks. r=aki

Comment 17

[Narcis Beleuzu [:NarcisB]]

Backed out for buid signing failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/a3941f42e66295031c2a6bf7b188d4c48a7ae624
Log link: https://firefoxci.taskcluster-artifacts.net/H4_ooTeaQuqf5MxmgbJmvQ/0/public/logs/chain_of_trust.log

Comment 18

[Justin Wood (:Callek)]

Attachment: Bug 1623355 - Part 1/9 - Set update channel for autoland as well. r=tomprince

This is needed for geckoview signing, since geckoview defaults to 'nightly-autoland' update channel anyway,
and is what we use everywhere on autoland for update channel due to that default, so make taskgraph aware of it.

This patch seems to set the update channel attribute for non shippable builds too, but that aligns with what
happens on central anyway.

See-Also future Bug 1639383 - which may unify the update channels.

Comment 19

[Tom Prince [:tomprince]]

Attachment: Bug 1623355 - Part 1/9 - Set geckoview artifact names to match mozharness on non-release branches; r?Callek

For shippable builds on non-release branches, mozharness defaults to using
nightly-{project}. The update channel is encoded in the artifact filenames
for non release-channel builds, so update taskgraph to generate the correct
artifact names on non-release branches.

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07de002afb78
Part 1/9 - Set geckoview artifact names to match mozharness on non-release branches; r=Callek
https://hg.mozilla.org/integration/autoland/rev/0101200826e5
Part 2/9 - Add shippable as a valid target for performance test cron targets. r=aki
https://hg.mozilla.org/integration/autoland/rev/449ec0123902
Part 3/9 - Rename android pgo tests to -shippable/opt and adjust run-on-platforms to cope. r=aki
https://hg.mozilla.org/integration/autoland/rev/4f9f6716d896
Part 4/9 - Point tests based on pgo builds to use shippable builds. r=aki
https://hg.mozilla.org/integration/autoland/rev/7e13b54fdbc4
Part 5/9 - Rename pgo instrumentation steps to shippable. And make condition profiles use shippable. r=aki
https://hg.mozilla.org/integration/autoland/rev/d379d3ebc3f7
Part 6/9 - Remove Android PGO build types. r=aki
https://hg.mozilla.org/integration/autoland/rev/9359e7cd1398
Part 7/9 - Set treeherder symbols appropriately for Android Shippable. r=aki
https://hg.mozilla.org/integration/autoland/rev/a7d4a9064f31
Part 8/9 - Set new shippable index's for Android shippable builds. r=aki
https://hg.mozilla.org/integration/autoland/rev/5190da2e563e
Part 9/9 - Remove 'pgo' support from performance testing target tasks. r=aki

Comment 22

[Justin Wood (:Callek)]

Attachment: Followup to Bug 1623355 - Part 1, specifically fix typo in 'nightly'.

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92c11f0bf14b
Followup to Bug 1623355 - Part 1, specifically fix typo in 'nightly'. CLOSED TREE

Comment 24

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/07de002afb78
https://hg.mozilla.org/mozilla-central/rev/0101200826e5
https://hg.mozilla.org/mozilla-central/rev/449ec0123902
https://hg.mozilla.org/mozilla-central/rev/4f9f6716d896
https://hg.mozilla.org/mozilla-central/rev/7e13b54fdbc4
https://hg.mozilla.org/mozilla-central/rev/d379d3ebc3f7
https://hg.mozilla.org/mozilla-central/rev/9359e7cd1398
https://hg.mozilla.org/mozilla-central/rev/a7d4a9064f31
https://hg.mozilla.org/mozilla-central/rev/5190da2e563e
https://hg.mozilla.org/mozilla-central/rev/92c11f0bf14b

Comment 25

[Greg Mierzwinski [:sparky]]

Hello, I filed bug 1641017 for raptor-browsertime regressions. This patch completely disabled those tests everywhere and is a major regression. Please test those run-on-projects changes more closely next time. There are most likely other issues that I haven't found yet as well. #perftest-reviewers should have been a reviewer for this patch, we have tools that we use to prevent these kinds of regressions: https://phabricator.services.mozilla.com/D74306