Closed Bug 1624696 Opened 4 months ago Closed 4 months ago

Buttons with non-native theme don't honor padding.

Categories

(Core :: Widget, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

data:text/html,<button style="padding: 0 0.3em">Foo</button>

This breaks https://webplatform.news/issues/2020-03-19 for example.

Only button / menulist-button were missing from the hard-coded if condition. I
don't think we ever want to override author padding, and this can cause compat
issues as the one in this bug.

I'm making HasAuthorSpecifiedRules fast in bug 1624080, btw.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f3c5f5a1b35d
Respect padding for all elements except checkbox/radio. r=spohl,mstange
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e2f021fe0c3e
Respect padding for all elements except checkbox/radio. r=spohl,mstange
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
Regressions: 1624752
QA Whiteboard: [qa-76b-p2]
You need to log in before you can comment on or make changes to this bug.