1624696 - Buttons with non-native theme don't honor padding.

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

data:text/html,<button style="padding: 0 0.3em">Foo</button>

This breaks https://webplatform.news/issues/2020-03-19 for example.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1624696 - Respect padding for all elements except checkbox/radio. r=spohl,mstange

Only button / menulist-button were missing from the hard-coded if condition. I
don't think we ever want to override author padding, and this can cause compat
issues as the one in this bug.

I'm making HasAuthorSpecifiedRules fast in bug 1624080, btw.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3c5f5a1b35d
Respect padding for all elements except checkbox/radio. r=spohl,mstange

Comment 3

[Narcis Beleuzu [:NarcisB]]

Backed out for wpt failures on baseline-alignment-and-overflow.tentative.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/0460bc1ab4f09146747792fdb41c0031f60fc006
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=294565462&repo=autoland&lineNumber=3304

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2f021fe0c3e
Respect padding for all elements except checkbox/radio. r=spohl,mstange

Comment 5

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/e2f021fe0c3e