1631792 - Remove all of js/ipc and the CPOW infrastructure now that it is unused

Status: NEW

(Core :: DOM: Content Processes, task, P2)

Description

[:Gijs (he/him)]

CPOWs are dead, long live CPOWs.

Well, after bug 1631358, anyway.

We can remove all the now-unused IPC gunk for them, id est:

• All of (?) js/ipc;
• all references to the Javascript ipc protocol elsewhere in the tree
• rewrite all of inside_cpow to use inside_sync (possibly with a follow-up to evaluate how many of those are still necessary, either) and remove support for inside_cpow
• prefs for cpow timeouts and logging / forbidding unsafe access
• with that done, probably audit https://searchfox.org/mozilla-central/search?q=cpow or similar to see what else remains (right now this maxes out searchfox's 1000 hits, but a lot is in the stuff we'd remove in the other steps and/or bug 1631358

Comment 1

[Andrew McCreight [:mccr8]]

Another useful search would be jsipc. I think that'll catch a lot of forward declarations and "using namespace" that might be missed by other stuff. Although hopefully that will naturally get removed by the other stuff.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:neha, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Andrew McCreight [:mccr8]]

(In reply to :Gijs (he/him) from comment #0)

• prefs for cpow timeouts and logging / forbidding unsafe access

Here are the uses of StaticPrefs inside the js/ipc directory:
StaticPrefs::dom_ipc_cpows_forbid_unsafe_from_browser()
StaticPrefs::dom_ipc_cpows_log_enabled()
StaticPrefs::dom_ipc_cpows_log_stack()

There are no other occurances of "prefs" in this directory. Fortunately, they all contain "cpows", so they'd be easily found by followup cleanup.

Comment 4

[Andrew McCreight [:mccr8]]

NS_ERROR_XPC_CANT_PASS_CPOW_TO_NATIVE is another thing that can be removed (and would also be caught by a search for CPOWs).

Comment 5

[Andrew McCreight [:mccr8]]

All references to "jsipc" are gone now. (Aside from the weird orderfile stuff.)