1634631 - Central Kurdish (ckb) uses left-to-right layout instead of RTL

Status: RESOLVED FIXED

(Core :: Internationalization, enhancement)

Description

[Francesco Lodolo [:flod]]

Attachment: immagine.png

We have a new locale, Central Kurdish (ckb), that uses Arabic script and RTL layout, but shows up LTR in the browser.

Locale is not available in CLDR. If that's the source of our RTL locales, we need a way to work around it.

Comment 2

[Francesco Lodolo [:flod]]

Sorry for the noise. Not exactly sure about the category of this bug, but keeping as enhancement for now.

Also added reference to bug 1347272, which I believe started using Unicode as source via Services.locale.isAppLocaleRTL. As said, if that's what we're currently doing, I believe we need a way to override missing data from Unicode here.

Comment 3

[jwtiyar]

Central Kurdish is Available in CLDR.

Comment 4

[Francesco Lodolo [:flod]]

(In reply to cwtiyar from comment #3)

Central Kurdish is Available in CLDR.

I remember it was available, but couldn't find it this morning. But it's indeed there, no clue why I missed it
https://github.com/unicode-cldr/cldr-misc-full/blob/master/main/ckb/layout.json

At this point, I guess Axel was right and we have this list hardcoded somewhere?

Comment 5

[jwtiyar]

which list you mean?

Comment 6

[Francesco Lodolo [:flod]]

The list of locales using RTL layout.

I got down a rabbit hole, not sure I ended up in the right place. given I don't understand this list at all
https://searchfox.org/mozilla-central/rev/7fd1c1c34923ece7ad8c822bee062dd0491d64dc/third_party/rust/unic-langid-impl/src/layout_table.rs#1

pub const CHARACTER_DIRECTION_RTL: [u64; 6] = [29281, 29301, 29552, 24934, 25715, 25960];

Comment 7

[Axel Hecht [:Pike]]

So, the caveat here is that the source is https://github.com/zbraniecki/unic-locale, and that uses the modern subset, and ckb isn't in that. Per "ICU Subcommittee".

Zibi, what's the best way forward here?

In other news, I just checked, and Intl seems work OK, at least NumberFormat shows the correct resolved options.

Comment 8

[jwtiyar]

The title also is wrong dear francesco :)
ckb uses right-to-left instead of LTR.

Best Regards.

Comment 9

[Francesco Lodolo [:flod]]

(In reply to cwtiyar from comment #8)

The title also is wrong dear francesco :)
ckb uses right-to-left instead of LTR.

That's a description of the bug, not of the solution.

P.S. I'm going to mark a few comments as off-topic, let's move unrelated chat to Matrix

Comment 10

[Zibi Braniecki [:zbraniecki][:gandalf]]

Filed an issue https://github.com/zbraniecki/unic-locale/issues/58 and then we'll have to update Gecko to new unic-locale.

Comment 11

[jwtiyar]

What to do now? when we can get update?

Comment 12

[Zibi Braniecki [:zbraniecki][:gandalf]]

You'll see here once it'll get prioritized, an engineer will be assigned, and the patch will land.

You can just monitor this bug to be up to date.

Comment 13

[jwtiyar]

(In reply to Zibi Braniecki [:zbraniecki][:gandalf] from comment #12)

You'll see here once it'll get prioritized, an engineer will be assigned, and the patch will land.

You can just monitor this bug to be up to date.

when? its time assumptions.

Comment 14

[Zibi Braniecki [:zbraniecki][:gandalf]]

when? its time assumptions.

I don't have any time estimates.

If you're interested in writing the patches yourself, here's the intro: https://firefox-source-docs.mozilla.org/build/buildsystem/rust.html

Otherwise, it'll happen when enough changes accrue and we'll be doing an update of the fluent-rs crate in Gecko (which brings the updated unic-locale with the data for ckb).

Comment 15

[jwtiyar]

Thank you but iam not a developer to do it, but my language is not the first language with RTL, arabic is same.
so may be do not need too much work to be done.

Best Regards.

Comment 16

[Francesco Lodolo [:flod]]

(In reply to cwtiyar from comment #15)

Thank you but iam not a developer to do it, but my language is not the first language with RTL, arabic is same.
so may be do not need too much work to be done.

I'm going to start marking off-topic comments as such, please let's stay on topic and not make assumptions on how much something requires. I'm not a developer either, and I have no way to tell.

@zibi
This locale is making progress in Nightly, but testing is impacted. It would be great to bump priority if possible.
For reference, how frequently has been this library updated so far?

@Jwtiyar
I assume you should be able to temporarily work around it by setting intl.uidirection to 1 in about:config. Not sure if that covers all cases, but it would be a start. If not, please let's use Matrix for further discussions.

Comment 17

[jwtiyar]

(In reply to Francesco Lodolo [:flod] from comment #16)

(In reply to cwtiyar from comment #15)

Thank you but iam not a developer to do it, but my language is not the first language with RTL, arabic is same.
so may be do not need too much work to be done.

I'm going to start marking off-topic comments as such, please let's stay on topic and not make assumptions on how much something requires. I'm not a developer either, and I have no way to tell.

@zibi
This locale is making progress in Nightly, but testing is impacted. It would be great to bump priority if possible.
For reference, how frequently has been this library updated so far?

@Jwtiyar
I assume you should be able to temporarily work around it by setting intl.uidirection to 1 in about:config. Not sure if that covers all cases, but it would be a start. If not, please let's use Matrix for further discussions.

Thank you dear francessco, now is better.

Comment 18

[Zibi Braniecki [:zbraniecki][:gandalf]]

This should now be fixed. Flod, can you verify?

Comment 19

[Francesco Lodolo [:flod]]

Thanks, it's indeed fixed in the latest Nightly (20200903151816).

Comment 20

[jwtiyar]

I can confirm it's fixed. Thank you