1636207 - Refresh the WebRTC global sharing indicator

Status: RESOLVED FIXED

(Firefox :: Site Permissions, enhancement, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

See the Invision spec here: https://mozilla.invisionapp.com/share/79X1W38HGAY#/screens/415377467

Unlike the original indicator (which was only used on Windows and Linux), this new indicator should be usable on all platforms.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1636207 - Make the macOS WebRTC global menubar entry CSS easier to differentiate. r?florian!

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1636207 - Fork the WebRTC global indicator for a refresh. r?florian!

Depends on D74331

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1636207 - Create a new WebRTC global indicator. r?florian!

Depends on D74332

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1636207 - Include the serialized nsIMediaDevice list with the tab sharing state. r?florian!

Depends on D74332

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1636207 - Have webrtcUI.getActiveStreams support getting window streams. r?florian!

Depends on D74729

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1636207 - Follow-up: remove unnecessary browser_all_files_referenced.js whitelist entry. r=test-only.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1636207 - Follow-up: remove unused CSS variable from webRTC-indicator.css. r=mconley!

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/integration/autoland/rev/5e895b82e59a9064e1fdfe555b68317730009d3c
https://hg.mozilla.org/integration/autoland/rev/c82ee96a7391dfea67e91a671b1a2efd9dabbead
https://hg.mozilla.org/integration/autoland/rev/49ab7a9cfc3010a3104554c59aa6d926bb381685
https://hg.mozilla.org/integration/autoland/rev/a0be773ac8c93eeaac4f329dca775027d94c2e91
https://hg.mozilla.org/integration/autoland/rev/ed5ec54c0e9b2e659d070ce2beed3da4e7188085
https://hg.mozilla.org/integration/autoland/rev/9dc30e32168fc379f350ba6f1c306a290e17b836
https://hg.mozilla.org/integration/autoland/rev/50d7cec5c47617f2fe9effe54880e10165265c46
https://hg.mozilla.org/mozilla-central/rev/5e895b82e59a
https://hg.mozilla.org/mozilla-central/rev/c82ee96a7391
https://hg.mozilla.org/mozilla-central/rev/49ab7a9cfc30
https://hg.mozilla.org/mozilla-central/rev/a0be773ac8c9
https://hg.mozilla.org/mozilla-central/rev/ed5ec54c0e9b
https://hg.mozilla.org/mozilla-central/rev/9dc30e32168f
https://hg.mozilla.org/mozilla-central/rev/50d7cec5c476

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9146617 [details]
Bug 1636207 - Make the macOS WebRTC global menubar entry CSS easier to differentiate. r?florian!

Beta/Release Uplift Approval Request

• User impact if declined: None.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This adds a (disabled by default) branch that introduces a new sharing indicator. The old, battle-tested indicator is still there, and is what we're defaulting to still.
• String changes made/needed: None.

Comment 10

[Mike Conley (:mconley) (:⚙️)]

NOTE: For whoever uplifts this stuff - the two "follow-up" patches didn't need / get review in Phabricator. They were written after sheriffs noticed some test failures, and I cobbled together some follow-up patches which they landed on autoland. We'll need those follow-ups if and when we merge to beta.

Comment 11

[Pascal Chevrel:pascalc]

Comment on attachment 9146617 [details]
Bug 1636207 - Make the macOS WebRTC global menubar entry CSS easier to differentiate. r?florian!

Planned uplift approved via the release exception process, uplift approved for beta 8, thanks.

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/d849b7b919eca5c53f4e7a3ada08263a1ac49222
https://hg.mozilla.org/releases/mozilla-beta/rev/8011350b92e1d4eaae6f7d53e96f431f9ad2c4e9
https://hg.mozilla.org/releases/mozilla-beta/rev/0c1eaf00c85a9c473429d23d0b14327cad6229bd
https://hg.mozilla.org/releases/mozilla-beta/rev/a159e887fd7a87dfde45de56218ee073c803144e
https://hg.mozilla.org/releases/mozilla-beta/rev/172b1370fc22033764a94c16042efd0296c30b86
https://hg.mozilla.org/releases/mozilla-beta/rev/204fbccbb0f0ba613d2f4d90cc66786f9ad059aa
https://hg.mozilla.org/releases/mozilla-beta/rev/aad1ff05db57af0085e3c6dc896f7ae6b91966e7

Comment 13

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Just played with this on Windows, and noticed the new _ ("Minimize indicator") button solves bug 1639297! That is: users can now minimize the indicator and it no longer shows up in fullscreen, where it was a nuisance for many users (playing fullscreen games etc). Nice! 👍

Would it be ok to mention the just-landed privacy.webrtc.legacyGlobalIndicator pref over in that bug, or is it still confidential?

Will assume it's confidential for now, and update that bug once that changes.

Comment 14

[Mike Conley (:mconley) (:⚙️)]

Spoke with jib and cleared this up.