1636583 - Allow forcing a visit by appending a slash to uri-like search strings

Status: VERIFIED FIXED

(Firefox :: Address Bar, enhancement, P3)

Description

[Marco Bonardo [:mak]]

This is something that Chrome does, and there's no reason we should not do the same, since there's unlikely a use-case to search for a string ending with /

Comment 1

[Marco Bonardo [:mak]]

Verdi confirmed we always want to visit when the search string ends wiwht a slash, I think we should make this change in URIFixup for coherency.

The behavior is a bit more complex though, it looks like these are handled as uris:

1. asd/
2. asd.asd/
3. asd/ asd/
4. asd.asd/ asd/

But these are not

1. asd /
2. asd.com /
3. asd.asd /
4. asd/ asd

Thus the string must end with a slash, but there must be no space in the prePath part (before the first slash). This still makes sense.

Comment 2

[Marco Bonardo [:mak]]

Attachment: Bug 1636583 - Split pickResult out of pickElement. r=adw

This allows to pick a result without necessarily having a view element.

Comment 3

[Marco Bonardo [:mak]]

Attachment: Bug 1636583 - URIFixup should force a visit when an uri-like search string ends with a slash. r=adw

Depends on D75909

Comment 4

[Marco Bonardo [:mak]]

Attachment: Bug 1636583 - Make the urlbar always go through pickResult. r=adw

This changes the urlbar to always generate a result and then confirm it through
pickResult. This way we obtain a consistent behavior independently from whether
the view has a result or an action like Paste&Go happened.
Before this we used to go through getShortcutOrURIAndPostData, that implements
only a part of the urlbar logic, often causing different behavior depending on
the view state, and thus requiring constant maintenance to sync it up.
In a follow-up bug we will evaluate the complete removal of
getShortcutOrURIAndPostData in favor of direct calls to
UrlbarUtils.getHeuristicResultFor().

This also moves up a bit closer to always pass a final url to the docshell, and
stop trying to do complex URIFixup calls in it. For now we still rely
on its fix-ups for browser.fixup.dns_first_for_single_words, where we pass a
url, and if it's invalid it will instead search. See UrlbarUtils.RESULT_TYPE.URL
handling in pickResult().

Depends on D75910

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9fd142817919
Split pickResult out of pickElement. r=adw
https://hg.mozilla.org/integration/autoland/rev/660b7de89215
URIFixup should force a visit when an uri-like search string ends with a slash. r=adw
https://hg.mozilla.org/integration/autoland/rev/a2e636ff03c2
Make the urlbar always go through pickResult. r=adw

Comment 6

[Dorel Luca [:dluca]]

Backed out 3 changesets (bug 1636583) for Browser-chrome failures in browser/components/urlbar/tests/browser/browser_handleCommand_fallback.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=303373434&repo=autoland&lineNumber=2505

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=a2e636ff03c2b4ee74efc96bc040a4b0a725c963

Backout:
https://hg.mozilla.org/integration/autoland/rev/5d62e7f9ed7b605d6899a928908f5c2c652cd16d

Comment 7

[Marco Bonardo [:mak]]

heh, I clashed against another urlbar change that landed at the same time.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79ef4e692710
Split pickResult out of pickElement. r=adw
https://hg.mozilla.org/integration/autoland/rev/7e46c4fe1829
URIFixup should force a visit when an uri-like search string ends with a slash. r=adw
https://hg.mozilla.org/integration/autoland/rev/3883a1bffcbe
Make the urlbar always go through pickResult. r=adw

Comment 9

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/79ef4e692710
https://hg.mozilla.org/mozilla-central/rev/7e46c4fe1829
https://hg.mozilla.org/mozilla-central/rev/3883a1bffcbe

Comment 10

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I can confirm this enhancement works, I verified using Fx 78.0 on Windows 10 x64.