Closed Bug 1637365 Opened 6 years ago Closed 6 years ago

Implement pre-importing topsites for multistage onboarding flow

Categories

(Firefox :: Messaging System, enhancement, P1)

Product:
Firefox
Component:
Messaging System
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 79
Iteration:
79.1 - June 1 - June 14
Tracking Flags:
Tracking Status
firefox77 --- unaffected
firefox78 - verified
firefox79 --- verified

People

(Reporter: pdahiya, Assigned: Mardak)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files)

Pre-imported topsites design specs
83 bytes, text/plain
Details
Bug 1637365 - Show pre-imported topsites for some multistage onboarding flows r=pdahiya
47 bytes, text/x-phabricator-request
jcristau
: approval-mozilla-beta+
Details | Review

Scope of this bug

  • pre-import topsites links from user default browser
  • measure performance impact if any
  • integrate with tippy top to show tiles icon
  • fall back gracefully to hide tiles section or show hardcoded tiles if fail to pre-import topsites

Updating bug with Ed's comment in Slack on using ImportableTopSites to set newTab TopSites

Services.prefs.setStringPref("browser.newtabpage.activity-stream.default.sites", await ChromeUtils.import("resource:///modules/ChromeMigrationUtils.jsm").ChromeMigrationUtils.getImportableTopSites())

Assignee: nobody → edilee
Severity: -- → S3
Iteration: --- → 78.2 - May 18 - May 31
status-firefox77: --- → unaffected
status-firefox78: --- → affected
Priority: -- → P1
See Also: → 1640161
Iteration: 78.2 - May 18 - May 31 → 79.1 - June 1 - June 14
status-firefox78: affected → fix-optional
status-firefox79: --- → affected

[Tracking Requested - why for this release]:

tracking-firefox78: --- → ?

Please specify a reason when requesting tracking.

tracking-firefox78: ? → -

Get importable sites from parent then convert to rich icons in child with caching. Render icons if we have them, otherwise show a letter and short url with colors.

Attachment #9154465 - Attachment description: Bug 1637365 - Implement pre-importing topsites for multistage onboarding flow r?pdahiya → Bug 1637365 - Show pre-imported topsites for some multistage onboarding flows r=pdahiya
Pushed by elee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e0746c635241 Show pre-imported topsites for some multistage onboarding flows r=pdahiya

Backed out changeset e0746c635241 (bug 1637365) for browser_aboutwelcome_multistage.js failures.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=VqHuKTBEQBmHs4fzcQPi4A-0&searchStr=mochitest&fromchange=e0746c635241e67dec353f1b94fd35e62207c295&tochange=4ea35d706a6be6e403bfb06d4e1b5a1827110360

Backout link: https://hg.mozilla.org/integration/autoland/rev/4ea35d706a6be6e403bfb06d4e1b5a1827110360

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305284231&repo=autoland&lineNumber=3654

[task 2020-06-06T00:01:28.918Z] 00:01:28     INFO - TEST-START | browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js
[task 2020-06-06T00:01:30.978Z] 00:01:30     INFO - GECKO(3947) | JavaScript error: resource://activity-stream/vendor/react-dom.js, line 86: Error: Minified React error #311; visit https://reactjs.org/docs/error-decoder.html?invariant=311 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
[task 2020-06-06T00:01:32.152Z] 00:01:32     INFO - TEST-INFO | started process screentopng
[task 2020-06-06T00:01:32.495Z] 00:01:32     INFO - TEST-INFO | screentopng: exit 0
[task 2020-06-06T00:01:32.495Z] 00:01:32     INFO - Buffered messages logged at 00:01:28
[task 2020-06-06T00:01:32.495Z] 00:01:32     INFO - Entering test bound test_Multistage_About_Welcome_branches
[task 2020-06-06T00:01:32.498Z] 00:01:32     INFO - Buffered messages logged at 00:01:29
[task 2020-06-06T00:01:32.499Z] 00:01:32     INFO - Console message: [JavaScript Error: "can't access property "createInstance", Cc[("@mozilla.org/profile/migrator;1?app=browser&type=" + aKey)] is undefined" {file: "resource:///modules/MigrationUtils.jsm" line: 790}]
[task 2020-06-06T00:01:32.500Z] 00:01:32     INFO - MU_getMigrator@resource:///modules/MigrationUtils.jsm:790:1
[task 2020-06-06T00:01:32.500Z] 00:01:32     INFO - getImportableSites@resource:///actors/AboutWelcomeParent.jsm:52:43
[task 2020-06-06T00:01:32.501Z] 00:01:32     INFO - async*onContentMessage@resource:///actors/AboutWelcomeParent.jsm:182:16
[task 2020-06-06T00:01:32.502Z] 00:01:32     INFO - receiveMessage@resource:///actors/AboutWelcomeParent.jsm:222:19
[task 2020-06-06T00:01:32.503Z] 00:01:32     INFO - JSActor query*getImportableSites/getImportableSites.cache<@resource:///actors/AboutWelcomeChild.jsm:59:24
[task 2020-06-06T00:01:32.503Z] 00:01:32     INFO - async*getImportableSites@resource:///actors/AboutWelcomeChild.jsm:70:7
[task 2020-06-06T00:01:32.504Z] 00:01:32     INFO - AWGetImportableSites@resource:///actors/AboutWelcomeChild.jsm:202:29
[task 2020-06-06T00:01:32.505Z] 00:01:32     INFO - MultiStageAboutWelcome/</<@resource://activity-stream/aboutwelcome/aboutwelcome.bundle.js:317:51
[task 2020-06-06T00:01:32.505Z] 00:01:32     INFO - MultiStageAboutWelcome/<@resource://activity-stream/aboutwelcome/aboutwelcome.bundle.js:324:7
[task 2020-06-06T00:01:32.506Z] 00:01:32     INFO - Bh@resource://activity-stream/vendor/react-dom.js:126:456
[task 2020-06-06T00:01:32.507Z] 00:01:32     INFO - Dj@resource://activity-stream/vendor/react-dom.js:162:476
[task 2020-06-06T00:01:32.508Z] 00:01:32     INFO - unstable_runWithPriority@resource://activity-stream/vendor/react.js:25:260
[task 2020-06-06T00:01:32.508Z] 00:01:32     INFO - Da@resource://activity-stream/vendor/react-dom.js:60:280
[task 2020-06-06T00:01:32.510Z] 00:01:32     INFO - xb@resource://activity-stream/vendor/react-dom.js:162:231
[task 2020-06-06T00:01:32.510Z] 00:01:32     INFO - Bj/<@resource://activity-stream/vendor/react-dom.js:162:138
[task 2020-06-06T00:01:32.511Z] 00:01:32     INFO - U@resource://activity-stream/vendor/react.js:16:399
[task 2020-06-06T00:01:32.512Z] 00:01:32     INFO - B.port1.onmessage@resource://activity-stream/vendor/react.js:24:130
[task 2020-06-06T00:01:32.513Z] 00:01:32     INFO - EventHandlerNonNull*@resource://activity-stream/vendor/react.js:24:65
[task 2020-06-06T00:01:32.513Z] 00:01:32     INFO - @resource://activity-stream/vendor/react.js:9:167
[task 2020-06-06T00:01:32.514Z] 00:01:32     INFO - @resource://activity-stream/vendor/react.js:9:183
[task 2020-06-06T00:01:32.515Z] 00:01:32     INFO - 
[task 2020-06-06T00:01:32.515Z] 00:01:32     INFO - TEST-PASS | browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js | Should not render main.AW_STEP2 in multistage step 1 - true == true - 
[task 2020-06-06T00:01:32.516Z] 00:01:32     INFO - TEST-PASS | browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js | Should not render main.AW_STEP3 in multistage step 1 - true == true - 
[task 2020-06-06T00:01:32.517Z] 00:01:32     INFO - TEST-PASS | browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js | Navigated to a welcome screen - "about:welcome" == "about:welcome" - 
[task 2020-06-06T00:01:32.518Z] 00:01:32     INFO - Buffered messages logged at 00:01:30
[task 2020-06-06T00:01:32.519Z] 00:01:32     INFO - TEST-PASS | browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js | Should not render main.AW_STEP1 in multistage step 2 - true == true - 
[task 2020-06-06T00:01:32.520Z] 00:01:32     INFO - TEST-PASS | browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js | Should not render main.AW_STEP3 in multistage step 2 - true == true - 
[task 2020-06-06T00:01:32.521Z] 00:01:32     INFO - TEST-PASS | browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js | Should not render div.secondary-cta.top in multistage step 2 - true == true - 
[task 2020-06-06T00:01:32.526Z] 00:01:32     INFO - TEST-PASS | browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js | Navigated to a welcome screen - "about:welcome" == "about:welcome" - 
[task 2020-06-06T00:01:32.527Z] 00:01:32     INFO - TEST-PASS | browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js | Should not render main.AW_STEP1 in multistage step 3 - true == true - 
[task 2020-06-06T00:01:32.528Z] 00:01:32     INFO - TEST-PASS | browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js | Should not render main.AW_STEP2 in multistage step 3 - true == true - 
[task 2020-06-06T00:01:32.528Z] 00:01:32     INFO - TEST-PASS | browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js | Navigated to a welcome screen - "about:welcome" == "about:welcome" - 
[task 2020-06-06T00:01:32.529Z] 00:01:32     INFO - Buffered messages logged at 00:01:31
[task 2020-06-06T00:01:32.530Z] 00:01:32     INFO - Console message: [JavaScript Error: "Error: Minified React error #311; visit https://reactjs.org/docs/error-decoder.html?invariant=311 for the full message or use the non-minified dev environment for full errors and additional helpful warnings." {file: "resource://activity-stream/vendor/react-dom.js" line: 86}]
[task 2020-06-06T00:01:32.531Z] 00:01:32     INFO - Vc@resource://activity-stream/vendor/react-dom.js:86:131
[task 2020-06-06T00:01:32.531Z] 00:01:32     INFO - useState@resource://activity-stream/vendor/react-dom.js:218:226
[task 2020-06-06T00:01:32.532Z] 00:01:32     INFO - d.useState@resource://activity-stream/vendor/react.js:32:381
[task 2020-06-06T00:01:32.533Z] 00:01:32     INFO - MultiStageAboutWelcome@resource://activity-stream/aboutwelcome/aboutwelcome.bundle.js:314:89
[task 2020-06-06T00:01:32.534Z] 00:01:32     INFO - we@resource://activity-stream/vendor/react-dom.js:84:293
[task 2020-06-06T00:01:32.534Z] 00:01:32     INFO - He@resource://activity-stream/vendor/react-dom.js:97:464
[task 2020-06-06T00:01:32.535Z] 00:01:32     INFO - zj@resource://activity-stream/vendor/react-dom.js:228:406
[task 2020-06-06T00:01:32.536Z] 00:01:32     INFO - Th@resource://activity-stream/vendor/react-dom.js:152:225
[task 2020-06-06T00:01:32.536Z] 00:01:32     INFO - tj@resource://activity-stream/vendor/react-dom.js:152:152
[task 2020-06-06T00:01:32.537Z] 00:01:32     INFO - Te@resource://activity-stream/vendor/react-dom.js:146:151
[task 2020-06-06T00:01:32.538Z] 00:01:32     INFO - Pg/<@resource://activity-stream/vendor/react-dom.js:61:68
[task 2020-06-06T00:01:32.539Z] 00:01:32     INFO - unstable_runWithPriority@resource://activity-stream/vendor/react.js:25:260
[task 2020-06-06T00:01:32.539Z] 00:01:32     INFO - Da@resource://activity-stream/vendor/react-dom.js:60:280
[task 2020-06-06T00:01:32.540Z] 00:01:32     INFO - Pg@resource://activity-stream/vendor/react-dom.js:61:16
[task 2020-06-06T00:01:32.541Z] 00:01:32     INFO - ha@resource://activity-stream/vendor/react-dom.js:60:451
[task 2020-06-06T00:01:32.542Z] 00:01:32     INFO - @resource://activity-stream/vendor/react-dom.js:236:59
[task 2020-06-06T00:01:32.542Z] 00:01:32     INFO - Ei@resource://activity-stream/vendor/react-dom.js:41:90
[task 2020-06-06T00:01:32.543Z] 00:01:32     INFO - @resource://testing-common/content-task.js line 110 > eval:9:14
[task 2020-06-06T00:01:32.545Z] 00:01:32     INFO - async*@resource://testing-common/content-task.js:111:29
[task 2020-06-06T00:01:32.545Z] 00:01:32     INFO - MessageListener.receiveMessage*@resource://testing-common/content-task.js:64:19
[task 2020-06-06T00:01:32.546Z] 00:01:32     INFO - 
[task 2020-06-06T00:01:32.547Z] 00:01:32     INFO - TEST-PASS | browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js | Should not render div.multistageContainer in home - true == true - 
[task 2020-06-06T00:01:32.547Z] 00:01:32     INFO - TEST-PASS | browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js | Navigated to about:home - "about:home" == "about:home" - 
[task 2020-06-06T00:01:32.548Z] 00:01:32     INFO - Leaving test bound test_Multistage_About_Welcome_branches
[task 2020-06-06T00:01:32.549Z] 00:01:32     INFO - Entering test bound test_AWMultistage_Primary_Action
[task 2020-06-06T00:01:32.550Z] 00:01:32     INFO - Buffered messages finished
[task 2020-06-06T00:01:32.552Z] 00:01:32     INFO - TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js | Stub was called - 
[task 2020-06-06T00:01:32.552Z] 00:01:32     INFO - Stack trace:
[task 2020-06-06T00:01:32.553Z] 00:01:32     INFO - chrome://mochikit/content/browser-test.js:test_ok:1299
[task 2020-06-06T00:01:32.554Z] 00:01:32     INFO - chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js:test_AWMultistage_Primary_Action:228
[task 2020-06-06T00:01:32.555Z] 00:01:32     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1064
[task 2020-06-06T00:01:32.555Z] 00:01:32     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1104
[task 2020-06-06T00:01:32.556Z] 00:01:32     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:927
[task 2020-06-06T00:01:32.557Z] 00:01:32     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:918
[task 2020-06-06T00:01:32.558Z] 00:01:32     INFO - TEST-PASS | browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js | send telemetry event - "AWPage:TELEMETRY_EVENT" == "AWPage:TELEMETRY_EVENT" - 
[task 2020-06-06T00:01:32.559Z] 00:01:32     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-06-06T00:01:32.569Z] 00:01:32     INFO - TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js | click button event recorded in telemetry - "IMPRESSION" == "CLICK_BUTTON" - JS frame :: chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js :: test_AWMultistage_Primary_Action :: line 234
[task 2020-06-06T00:01:32.570Z] 00:01:32     INFO - Stack trace:
[task 2020-06-06T00:01:32.571Z] 00:01:32     INFO - chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js:test_AWMultistage_Primary_Action:234
[task 2020-06-06T00:01:32.572Z] 00:01:32     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1064
[task 2020-06-06T00:01:32.572Z] 00:01:32     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1104
[task 2020-06-06T00:01:32.573Z] 00:01:32     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:927
[task 2020-06-06T00:01:32.574Z] 00:01:32     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:918
[task 2020-06-06T00:01:32.574Z] 00:01:32     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-06-06T00:01:32.575Z] 00:01:32     INFO - TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js | primary button click source recorded in telemetry - "undefined" == "primary_button" - JS frame :: chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js :: test_AWMultistage_Primary_Action :: line 239
[task 2020-06-06T00:01:32.576Z] 00:01:32     INFO - Stack trace:
[task 2020-06-06T00:01:32.577Z] 00:01:32     INFO - chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js:test_AWMultistage_Primary_Action:239
[task 2020-06-06T00:01:32.577Z] 00:01:32     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1064
[task 2020-06-06T00:01:32.578Z] 00:01:32     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1104
[task 2020-06-06T00:01:32.579Z] 00:01:32     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:927
[task 2020-06-06T00:01:32.579Z] 00:01:32     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:918
[task 2020-06-06T00:01:32.580Z] 00:01:32     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-06-06T00:01:32.581Z] 00:01:32     INFO - TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js | MessageId sent in click event telemetry - "MULTI-STAGE-WELCOME_SITES" == "MULTI-STAGE-WELCOME_AW_STEP1" - JS frame :: chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js :: test_AWMultistage_Primary_Action :: line 244
[task 2020-06-06T00:01:32.582Z] 00:01:32     INFO - Stack trace:
[task 2020-06-06T00:01:32.582Z] 00:01:32     INFO - chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js:test_AWMultistage_Primary_Action:244
[task 2020-06-06T00:01:32.583Z] 00:01:32     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1064
[task 2020-06-06T00:01:32.584Z] 00:01:32     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1104
[task 2020-06-06T00:01:32.584Z] 00:01:32     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:927
[task 2020-06-06T00:01:32.585Z] 00:01:32     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:918
[task 2020-06-06T00:01:32.586Z] 00:01:32     INFO - Leaving test bound test_AWMultistage_Primary_Action
[task 2020-06-06T00:01:32.587Z] 00:01:32     INFO - Entering test bound test_AWMultistage_Secondary_Open_URL_Action
[task 2020-06-06T00:01:32.729Z] 00:01:32     INFO - GECKO(3947) | JavaScript error: resource:///actors/AboutWelcomeChild.jsm, line 59: TypeError: (intermediate value).map is not a function
[task 2020-06-06T00:01:32.730Z] 00:01:32     INFO - Console message: [JavaScript Error: "TypeError: (intermediate value).map is not a function" {file: "resource:///actors/AboutWelcomeChild.jsm" line: 59}]
[task 2020-06-06T00:01:32.731Z] 00:01:32     INFO - getImportableSites/getImportableSites.cache<@resource:///actors/AboutWelcomeChild.jsm:59:62
[task 2020-06-06T00:01:32.732Z] 00:01:32     INFO - async*getImportableSites@resource:///actors/AboutWelcomeChild.jsm:70:7
[task 2020-06-06T00:01:32.733Z] 00:01:32     INFO - AWGetImportableSites@resource:///actors/AboutWelcomeChild.jsm:202:29
[task 2020-06-06T00:01:32.734Z] 00:01:32     INFO - MultiStageAboutWelcome/</<@resource://activity-stream/aboutwelcome/aboutwelcome.bundle.js:317:51
[task 2020-06-06T00:01:32.735Z] 00:01:32     INFO - MultiStageAboutWelcome/<@resource://activity-stream/aboutwelcome/aboutwelcome.bundle.js:324:7
[task 2020-06-06T00:01:32.735Z] 00:01:32     INFO - Bh@resource://activity-stream/vendor/react-dom.js:126:456
[task 2020-06-06T00:01:32.736Z] 00:01:32     INFO - Dj@resource://activity-stream/vendor/react-dom.js:162:476
[task 2020-06-06T00:01:32.737Z] 00:01:32     INFO - unstable_runWithPriority@resource://activity-stream/vendor/react.js:25:260
[task 2020-06-06T00:01:32.738Z] 00:01:32     INFO - Da@resource://activity-stream/vendor/react-dom.js:60:280
[task 2020-06-06T00:01:32.738Z] 00:01:32     INFO - xb@resource://activity-stream/vendor/react-dom.js:162:231
[task 2020-06-06T00:01:32.739Z] 00:01:32     INFO - Bj/<@resource://activity-stream/vendor/react-dom.js:162:138
[task 2020-06-06T00:01:32.740Z] 00:01:32     INFO - U@resource://activity-stream/vendor/react.js:16:399
[task 2020-06-06T00:01:32.741Z] 00:01:32     INFO - B.port1.onmessage@resource://activity-stream/vendor/react.js:24:130
[task 2020-06-06T00:01:32.742Z] 00:01:32     INFO - EventHandlerNonNull*@resource://activity-stream/vendor/react.js:24:65
[task 2020-06-06T00:01:32.743Z] 00:01:32     INFO - @resource://activity-stream/vendor/react.js:9:167
[task 2020-06-06T00:01:32.743Z] 00:01:32     INFO - @resource://activity-stream/vendor/react.js:9:183
[task 2020-06-06T00:01:32.744Z] 00:01:32     INFO - 
[task 2020-06-06T00:01:32.745Z] 00:01:32     INFO - GECKO(3947) | JavaScript error: , line 0: InternalError: Promise rejection value is a non-unwrappable cross-compartment wrapper.
[task 2020-06-06T00:01:32.752Z] 00:01:32     INFO - Console message: [JavaScript Error: "InternalError: Promise rejection value is a non-unwrappable cross-compartment wrapper."]
[task 2020-06-06T00:01:32.753Z] 00:01:32     INFO - MultiStageAboutWelcome/</<@resource://activity-stream/aboutwelcome/aboutwelcome.bundle.js:323:18
[task 2020-06-06T00:01:32.753Z] 00:01:32     INFO - async*MultiStageAboutWelcome/<@resource://activity-stream/aboutwelcome/aboutwelcome.bundle.js:324:7
[task 2020-06-06T00:01:32.754Z] 00:01:32     INFO - Bh@resource://activity-stream/vendor/react-dom.js:126:456
[task 2020-06-06T00:01:32.754Z] 00:01:32     INFO - Dj@resource://activity-stream/vendor/react-dom.js:162:476
[task 2020-06-06T00:01:32.754Z] 00:01:32     INFO - unstable_runWithPriority@resource://activity-stream/vendor/react.js:25:260
[task 2020-06-06T00:01:32.754Z] 00:01:32     INFO - Da@resource://activity-stream/vendor/react-dom.js:60:280
[task 2020-06-06T00:01:32.754Z] 00:01:32     INFO - xb@resource://activity-stream/vendor/react-dom.js:162:231
[task 2020-06-06T00:01:32.754Z] 00:01:32     INFO - Bj/<@resource://activity-stream/vendor/react-dom.js:162:138
[task 2020-06-06T00:01:32.754Z] 00:01:32     INFO - U@resource://activity-stream/vendor/react.js:16:399
[task 2020-06-06T00:01:32.754Z] 00:01:32     INFO - B.port1.onmessage@resource://activity-stream/vendor/react.js:24:130
[task 2020-06-06T00:01:32.754Z] 00:01:32     INFO - EventHandlerNonNull*@resource://activity-stream/vendor/react.js:24:65
[task 2020-06-06T00:01:32.754Z] 00:01:32     INFO - @resource://activity-stream/vendor/react.js:9:167
[task 2020-06-06T00:01:32.754Z] 00:01:32     INFO - @resource://activity-stream/vendor/react.js:9:183
[task 2020-06-06T00:01:32.754Z] 00:01:32     INFO - 
[task 2020-06-06T00:01:32.851Z] 00:01:32     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-06-06T00:01:32.851Z] 00:01:32     INFO - TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js | Stub called twice to handle Open_URL and Telemetry - 
[task 2020-06-06T00:01:32.851Z] 00:01:32     INFO - Stack trace:
[task 2020-06-06T00:01:32.851Z] 00:01:32     INFO - chrome://mochikit/content/browser-test.js:test_ok:1299
[task 2020-06-06T00:01:32.851Z] 00:01:32     INFO - chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js:test_AWMultistage_Secondary_Open_URL_Action:262
[task 2020-06-06T00:01:32.852Z] 00:01:32     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1064
[task 2020-06-06T00:01:32.852Z] 00:01:32     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1104
[task 2020-06-06T00:01:32.853Z] 00:01:32     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:927
[task 2020-06-06T00:01:32.853Z] 00:01:32     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:918
[task 2020-06-06T00:01:32.854Z] 00:01:32     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-06-06T00:01:32.855Z] 00:01:32     INFO - TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js | Got call to handle special action - "AWPage:TELEMETRY_EVENT" == "AWPage:SPECIAL_ACTION" - JS frame :: chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js :: test_AWMultistage_Secondary_Open_URL_Action :: line 269
[task 2020-06-06T00:01:32.856Z] 00:01:32     INFO - Stack trace:
[task 2020-06-06T00:01:32.856Z] 00:01:32     INFO - chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js:test_AWMultistage_Secondary_Open_URL_Action:269
[task 2020-06-06T00:01:32.857Z] 00:01:32     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1064
[task 2020-06-06T00:01:32.858Z] 00:01:32     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1104
[task 2020-06-06T00:01:32.859Z] 00:01:32     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:927
[task 2020-06-06T00:01:32.859Z] 00:01:32     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:918
[task 2020-06-06T00:01:32.861Z] 00:01:32     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-06-06T00:01:32.862Z] 00:01:32     INFO - TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js | Special action OPEN_URL event handled - "undefined" == "OPEN_URL" - JS frame :: chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js :: test_AWMultistage_Secondary_Open_URL_Action :: line 274
[task 2020-06-06T00:01:32.862Z] 00:01:32     INFO - Stack trace:
[task 2020-06-06T00:01:32.863Z] 00:01:32     INFO - chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js:test_AWMultistage_Secondary_Open_URL_Action:274
[task 2020-06-06T00:01:32.864Z] 00:01:32     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1064
[task 2020-06-06T00:01:32.865Z] 00:01:32     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1104
[task 2020-06-06T00:01:32.866Z] 00:01:32     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:927
[task 2020-06-06T00:01:32.866Z] 00:01:32     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:918
[task 2020-06-06T00:01:32.867Z] 00:01:32     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-06-06T00:01:32.868Z] 00:01:32     INFO - TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js | Uncaught exception - at chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js:280 - TypeError: can't access property "args", actionCall.args[1].data is undefined
[task 2020-06-06T00:01:32.869Z] 00:01:32     INFO - Stack trace:
[task 2020-06-06T00:01:32.870Z] 00:01:32     INFO - test_AWMultistage_Secondary_Open_URL_Action@chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js:280:1
[task 2020-06-06T00:01:32.870Z] 00:01:32     INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1064:34
[task 2020-06-06T00:01:32.872Z] 00:01:32     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1104:11
[task 2020-06-06T00:01:32.872Z] 00:01:32     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:927:14
[task 2020-06-06T00:01:32.876Z] 00:01:32     INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:918:23
[task 2020-06-06T00:01:32.879Z] 00:01:32     INFO - Leaving test bound test_AWMultistage_Secondary_Open_URL_Action
[task 2020-06-06T00:01:32.964Z] 00:01:32     INFO - GECKO(3947) | MEMORY STAT | vsize 20975224MB | residentFast 1127MB
[task 2020-06-06T00:01:32.965Z] 00:01:32     INFO - TEST-OK | browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js | took 4058ms
Flags: needinfo?(edilee)
Pushed by elee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f585b6b1a198 Show pre-imported topsites for some multistage onboarding flows r=pdahiya

https://hg.mozilla.org/mozilla-central/rev/f585b6b1a198

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox79: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79

Relanded with tests fixed for asan builds.

QA steps:
0) get some top sites in chrome

  1. set browser.aboutwelcome.overrideContent according to line 3 of https://gist.github.com/punamdahiya/1f6e621e8fef61fe227b2ba97fe255e9#file-about-welcome-message-format-importable-L3
  2. open about:welcome to the import screen

Expect top sites from chrome showing a letter or rich icon with the short host label below, e.g., https://d3kxowhw4s8amj.cloudfront.net/file/data/jvwrbdbhzgftwaxh4z6d/PHID-FILE-nouorqgnppf6unpvqzs3/with_label.png

Alternative step 1 use https://gist.github.com/punamdahiya/49cce603d01e76cf827dcd0a3e20f855#file-about-welcome-message-format-L3 where the only difference should be "id": "multi-stage-welcome", vs "id": "multi-stage-welcome-importable", resulting in the default static sites from bug 1640161 without label under icons.

Telemetry with browser.newtabpage.activity-stream.telemetry=true and browser.ping-centre.log=true should have a message like the following for both importable and static sites…
"event":"IMPRESSION","event_context":"{\"display\":\"importable\",\"importable\":10,\"page\":\"about:welcome\"}","message_id":"MULTI-STAGE-WELCOME-IMPORTABLE_SITES"

Flags: needinfo?(edilee)

Comment on attachment 9154465 [details]
Bug 1637365 - Show pre-imported topsites for some multistage onboarding flows r=pdahiya

Beta/Release Uplift Approval Request

  • User impact if declined: Needed to run multistage about:welcome onboarding experiment in 78. New profiles will be shown the multi-stage onboarding, with a “live” list of top sites shown on import screen (based on pre-import history from Chrome). Without this patch we will not be able to validate if displaying pre-imported topsites will perform better for retention than the current onboarding.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: https://bugzilla.mozilla.org/show_bug.cgi?id=1637365#c10
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This feature is shown in onboarding experience thats behind pref and only shown to users enrolled in experiment
  • String changes made/needed: none
Attachment #9154465 - Flags: approval-mozilla-beta?
Flags: qe-verify+

[Tracking Requested - why for this release]:
Needed to run multistage about:welcome onboarding experiment in 78. New profiles will be shown the multi-stage onboarding, with a “live” list of top sites shown on import screen (based on pre-import history from Chrome). Without this patch we will not be able to validate if displaying pre-imported topsites will perform better for retention than the current onboarding.

tracking-firefox78: - → ?
QA Whiteboard: [qa-triaged]

Comment on attachment 9154465 [details]
Bug 1637365 - Show pre-imported topsites for some multistage onboarding flows r=pdahiya

approved for 78.0b5

Attachment #9154465 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I have verified that the pre-imported topsites (from Google Chrome) are correctly displayed on the "Import screen" of the "about:welcome" page if the browser.aboutwelcome.overrideContent pref is set to the value mentioned in step 1 of the comment 10 using Firefox Beta 78.0b5 (Build ID: 20200609215727), and Firefox Nightly 79.0a1 (Build ID: 20200609151649) on Windows 10 x64.

Status: RESOLVED → VERIFIED
status-firefox78: fixed → verified
status-firefox79: fixed → verified
Flags: qe-verify+
Blocks: 1617759
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: