1644000 - Support browser.identity

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, enhancement)

Description

[kam193]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:77.0) Gecko/20100101 Firefox/77.0

Steps to reproduce:

I want to authorize user in an extension using OAuth2

Actual results:

Thunderbird MailExtension doesn't implement standard browser.identity (https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/identity)

Expected results:

I would like to see browser.identity support in MailExtension

Comment 1

[Geoff Lankow (:darktrojan)]

I didn't know this was a thing! I wish I had known a long time ago now.

Comment 2

[kam193]

I found it last time, but it looks like crucial feature to easily authenticate with OAuth2 in extensions. I hope we can implement it :)

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: 1644000-identity-api-1.diff

This is easy enough to enable, but we'll need bug 1644083 first. All of the code is in toolkit, we just need to link to it from ext-mail.js (it's not linked from ext-toolkit.js because Android Firefox doesn't have it).

The API itself opens a new window with the URL of BROWSER_CHROME_URL, which is for some bizarre reason pointing at messengercompose.xhtml now. I've looked into removing BROWSER_CHROME_URL altogether before, so I know it's okay to change it.

Comment 4

[Geoff Lankow (:darktrojan)]

I tested this with the google-userinfo sample extension. Getting the automated tests for it running isn't possible at the moment because they're mochitest-plain, and we can't run that suite.

Comment 5

[kam193]

Nice to see it! I'm pleased that it looks doable, I spent a few hours working on a workaround unsuccessfully.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3e9b60644f25
Enable browser.identity API. r=mkmelin

Comment 7

[kam193]

Thank you so much! Now in a 0.5h I built draft of the extension I'm working on.

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 9154879 [details] [diff] [review]
1644000-identity-api-1.diff

New WX API implementation (not risky)

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9154879 [details] [diff] [review]
1644000-identity-api-1.diff

Approved for beta

Comment 10

[Geoff Lankow (:darktrojan)]

Thunderbird 78.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/8e1be3cfb3bf