1721671 - Printing from View Source does not work. Throws Uncaught TypeError: can't access property 0, window.arguments is undefined

Status: VERIFIED FIXED

(Thunderbird :: General, defect)

Description

[Lasana Murray]

STR:

1. Open a mail message.
2. Click More > View Source
3. In the View Source window, click File > Print

Expected:
The print dialog comes up for printing.

Actual:
Nothing comes up, error is logged to console.

Comment 1

[Lasana Murray]

Geoff, is it correct for this dialog to use extensionPopup.xhtml to load? I saw BROWSER_CHROME_URL which seems important in mozilla-central was changed to point to it in bug 1644000.

Comment 2

[Richard Marti (:Paenglab)]

How do you want to implement the print preview? As I know there is no stand-alone preview window any more. Maybe the View Source window needs to be in a tab like FX does. Then the tab modal print preview could work again.

Comment 3

[Geoff Lankow (:darktrojan)]

The view source window doesn't have any of the printing UI connected, mostly because I forgot about it. It's not related to the other printing bugs we currently have. It's not really related to bug 1644000 either, but you're right that BROWSER_CHROME_URL is how it ends up trying to open extensionPopup.xhtml (we should never get to that point) and actually that makes me suspect printing in view source has been broken since before the UI changes.

Comment 4

[Geoff Lankow (:darktrojan)]

I'll look after this, there's many levels of crazy going on here and hopefully I can remember them all from last time I fixed the address book printing.

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1721671 - Fix printing in the view source window. r=lasana

Also removes some unused strings from earlier printing bugs.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a0b2b2ad8931
Fix printing in the view source window. r=lasana

Comment 7

[Tom]

This looks broken in TB 91 beta as well.

Comment 8

[Rob Lemley [:rjl]]

Comment on attachment 9232525 [details]
Bug 1721671 - Fix printing in the view source window. r=lasana

[Approval Request Comment]
Verified working on 91 beta test build.

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9232525 [details]
Bug 1721671 - Fix printing in the view source window. r=lasana

[Triage Comment]
Approved for beta

Comment 10

[WaltS48 [:walts48]]

Attachment: Fit to page width.png

The preview for view source is pushed over to the left side when I have "Fit to page width" selected, which is the default. Fills the whole preview when I select Scale: 100%.

Both result in a print out of what the preview shows.

Edit: Apparently it is due to a long line I did not notice and had to use a scrollbar to scroll all the way to the right of the View Source tab to read.

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 91.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/bf60186f3fca

Comment 12

[WaltS48 [:walts48]]

Using Thunderbird 91.0b4 on Windows 10.