Closed Bug 1721671 Opened 3 years ago Closed 3 years ago

Printing from View Source does not work. Throws Uncaught TypeError: can't access property 0, window.arguments is undefined

Categories

(Thunderbird :: General, defect)

defect

Tracking

(thunderbird91 verified, thunderbird92 verified)

VERIFIED FIXED
92 Branch
Tracking Status
thunderbird91 --- verified
thunderbird92 --- verified

People

(Reporter: lasana, Assigned: darktrojan)

References

Details

Attachments

(2 files)

STR:

  1. Open a mail message.
  2. Click More > View Source
  3. In the View Source window, click File > Print

Expected:
The print dialog comes up for printing.

Actual:
Nothing comes up, error is logged to console.

See Also: → 1720713, 1711822, 1714639

Geoff, is it correct for this dialog to use extensionPopup.xhtml to load? I saw BROWSER_CHROME_URL which seems important in mozilla-central was changed to point to it in bug 1644000.

Flags: needinfo?(geoff)
See Also: → 1644000
Assignee: nobody → lasana

How do you want to implement the print preview? As I know there is no stand-alone preview window any more. Maybe the View Source window needs to be in a tab like FX does. Then the tab modal print preview could work again.

The view source window doesn't have any of the printing UI connected, mostly because I forgot about it. It's not related to the other printing bugs we currently have. It's not really related to bug 1644000 either, but you're right that BROWSER_CHROME_URL is how it ends up trying to open extensionPopup.xhtml (we should never get to that point) and actually that makes me suspect printing in view source has been broken since before the UI changes.

Flags: needinfo?(geoff)
See Also: 1720713, 1714639, 1644000

I'll look after this, there's many levels of crazy going on here and hopefully I can remember them all from last time I fixed the address book printing.

Assignee: lasana → geoff
Status: NEW → ASSIGNED

Also removes some unused strings from earlier printing bugs.

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/a0b2b2ad8931
Fix printing in the view source window. r=lasana

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED

This looks broken in TB 91 beta as well.

Target Milestone: --- → 92 Branch

Comment on attachment 9232525 [details]
Bug 1721671 - Fix printing in the view source window. r=lasana

[Approval Request Comment]
Verified working on 91 beta test build.

Attachment #9232525 - Flags: approval-comm-beta?

Comment on attachment 9232525 [details]
Bug 1721671 - Fix printing in the view source window. r=lasana

[Triage Comment]
Approved for beta

Attachment #9232525 - Flags: approval-comm-beta? → approval-comm-beta+
Attached image Fit to page width.png

The preview for view source is pushed over to the left side when I have "Fit to page width" selected, which is the default. Fills the whole preview when I select Scale: 100%.

Both result in a print out of what the preview shows.

Edit: Apparently it is due to a long line I did not notice and had to use a scrollbar to scroll all the way to the right of the View Source tab to read.

Using Thunderbird 91.0b4 on Windows 10.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: