Closed Bug 1645662 Opened 4 months ago Closed 13 days ago

Page Info Tab: help contents is outdated

Categories

(SeaMonkey :: Help Documentation, defect, P4)

SeaMonkey 2.53 Branch

Tracking

(seamonkey2.53? affected, seamonkey2.57esr? affected)

RESOLVED FIXED
seamonkey 2.79
Tracking Status
seamonkey2.53 ? affected
seamonkey2.57esr ? affected

People

(Reporter: RainerBielefeldNG, Assigned: nunojsg)

References

(Blocks 2 open bugs)

Details

(Whiteboard: SM2.53.5)

Attachments

(3 files)

Steps how to reproduce with installation of unofficial (by wg9s) SeaMonkey 2.53.4beta 1 pre Mozilla/5.0 (NT 6.1; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0 Build 20200529210001(Default Classic Theme, newly created User Profile) on German WIN7 64bit:

  1. In Browser on arbitrary page: Menu ˋView → Page Infoˊ
  2. Compare with Help

My attachment contains suggestion for update:
🔧 means: This paragraph contains changes
Texts in read behind 🔧 are my comments concerning suggested changes

Looking at suite/browser/pageinfo/pageInfo.xul, it seems "Expires" is gone (unless it is added somewhere else?); "Expires" and "Source" were removed in bug 339102 [1] ("Rendering mode" was removed there as well, but re-added in bug 386361 [2]).

[1] https://hg.mozilla.org/mozilla-central/rev/14b94576b2dba46552fd9620d9ce33c997343ceb
[2] https://hg.mozilla.org/mozilla-central/rev/9236c556b26f198ae087d3248c45f01a6054a132

The page title used to be at the top, without a "Title:" label, so "the top portion displays the name of the page (if it has one)" probably refers to the title. This was changed in bug 1215856 [3].

[3] https://hg.mozilla.org/mozilla-central/rev/2dd4ac14010db78c2d50b6dbdf1d3fa91d0b0ec4

Blocks: 1655326

A first version of a patch to update the help text.

Assignee: nobody → nunojsg
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #9166152 - Flags: feedback?(iann_bugzilla)

Comment on attachment 9166152 [details] [diff] [review]
1645662-page-info-help-general [checked in comment 6]

[Triage Comment]
Sorry for the delay, LGTM r/a=me

Attachment #9166152 - Flags: feedback?(iann_bugzilla)
Attachment #9166152 - Flags: feedback+
Attachment #9166152 - Flags: approval-comm-release+
Attachment #9166152 - Flags: approval-comm-esr60+
Attachment #9166152 - Flags: review+
Whiteboard: [easyconfirm] → SM2.53.5

A second patch, to update tab order and remove the Privacy tab section (as this tab was removed in bug 366611).

Attachment #9169461 - Flags: feedback?(iann_bugzilla)

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/670e4d48c646
page_info_help.xhtml: update help for General tab. r=IanN

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Keywords: good-first-bug
Target Milestone: --- → seamonkey 2.79

Comment on attachment 9169461 [details] [diff] [review]
1645662-page-info-02-media-privacy
[checked in comment 9]

LGTM r=me

Attachment #9169461 - Flags: feedback?(iann_bugzilla) → review+
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment on attachment 9169461 [details] [diff] [review]
1645662-page-info-02-media-privacy
[checked in comment 9]

[Triage Comment]
a=me too

Attachment #9169461 - Flags: approval-comm-release+
Attachment #9169461 - Flags: approval-comm-esr60+
Summary: General (Page Info Tab): help contents is outdated → Page Info Tab: help contents is outdated

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/6c65cf170853
page_info_help.xhtml, suite-toc.rdf: update tab order and remove Privacy/p3p tab. r=IanN

Status: REOPENED → RESOLVED
Closed: 2 months ago13 days ago
Resolution: --- → FIXED
Attachment #9169461 - Attachment description: 1645662-page-info-02-media-privacy → 1645662-page-info-02-media-privacy [checked in comment 9]
Attachment #9166152 - Attachment description: 1645662-page-info-help-general → 1645662-page-info-help-general [checked in comment 6]
You need to log in before you can comment on or make changes to this bug.