1648171 - Password import suggestion renders without text (MigrationUtils.getBrowserName is not a function)

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect, P1)

Description

[Ed Lee :Mardak]

Attachment: no text rendered for 3 import suggestions

Bug 1618311 is currently experimenting in 77 and 78 and bug 1518234 removed getBrowserName in 79, so if the experiment is successful and decide to turn things on, we'll definitely want to fix this as it also prevents future password popups from rendering too.

Comment 1

[:Gijs (he/him)]

Is there a separate bug on file about adding automated tests for this feature?

Comment 2

[Ed Lee :Mardak]

There's various bugs that have been filed and deferred until the experiment concludes blocking bug 1617759. Looks like there isn't even one yet to turn things on by default where we probably want to rework some bits of how the experiment was implemented as well as adding tests.

For fixing this, looks like we'll want to do something similar for the imported bookmarks folder "From Google Chrome" behavior:
https://searchfox.org/mozilla-central/rev/a87a1c3b543475276e6d57a7a80cb02f3e42b6ed/browser/components/migration/MigrationUtils.jsm#649-654

Comment 3

[:Gijs (he/him)]

(In reply to Ed Lee :Mardak from comment #2)

There's various bugs that have been filed and deferred until the experiment concludes blocking bug 1617759. Looks like there isn't even one yet to turn things on by default where we probably want to rework some bits of how the experiment was implemented as well as adding tests.

For fixing this, looks like we'll want to do something similar for the imported bookmarks folder "From Google Chrome" behavior:
https://searchfox.org/mozilla-central/rev/a87a1c3b543475276e6d57a7a80cb02f3e42b6ed/browser/components/migration/MigrationUtils.jsm#649-654

The problem is that the autocomplete code isn't async, and we can only really get these strings async. I have an alternative patch.

Comment 4

[:Gijs (he/him)]

Attachment: Bug 1648171 - fix password import hint labels not showing up after migration code switching to fluent, r?Mardak!,flod!

This also switches to using individual strings for each browser.
This is very repetitive, but it has a few advantages:

• no need for a second, asynchronous localization pass in the code, which likely
  wouldn't work well for autocomplete code
• it's always clear for localizers what browser names are available
• localizers can do proper grammar around the names of browsers as would be
  appropriate in their language.
• there's no dependency on strings in browser/ from code in toolkit
  (though obviously there's still a dependency on the actual migration code..)

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1518234

Comment 6

[:Gijs (he/him)]

Per discussion with Ed, he wants to try to get a patch that does not require any string changes.

Comment 7

[Ed Lee :Mardak]

Attachment: Bug 1648171 - Password import suggestion renders without text r?MattN

Narrowly fix the regression without string changes by hardcoding english strings for the browsers used in the experiment.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Changing the priority to p1 as the bug is tracked by a release manager for the current beta.
See What Do You Triage for more information

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/411fe764a344
Password import suggestion renders without text r=MattN

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/411fe764a344

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:Mardak, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 12

[Ed Lee :Mardak]

We won't need this in 79