Closed Bug 165255 Opened 23 years ago Closed 23 years ago

Cannot PGUP and PGDOWN in mozilla

Categories

(Core :: DOM: Selection, defect)

Product:
Core
Component:
DOM: Selection
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: antitux, Assigned: Brade)

References

Details

(Keywords: regression)

Attachments

(1 file, 2 obsolete files)

patch, tested and all
5.77 KB, patch
aaronlev
: review+
jag+mozilla
: superreview+
Details | Diff | Splinter Review
Can't PageUp and PageDown in mozilla on MacOSX trunk 2002-08-28-08. This is reproducable on both modern and classic themes. 1. Load a page up that's larger than the browser window. 2. press pgup, and pgdown. 3. watch nothing happen.
Summary: Cannot PGUP and PGDOWN in mozilla → Cannot PGUP and PGDOWN in MacOSX mozilla
these need to be added to <browser> tag inside http://lxr.mozilla.org/mozilla/source/content/xbl/builtin/mac/platformHTMLBindings.xml <handler event="keypress" keycode="VK_PAGE_UP" command="cmd_scrollPageUp" /> <handler event="keypress" keycode="VK_PAGE_DOWN" command="cmd_scrollPageDown" /> I'll take this bug.
Assignee: mjudge → brade
any idea why this happened? is this from my changes or did something change the bindinge?
Same thing for MAC OS 9.1, Same build
apparently I missed some keybinding changes that are needed for <browser>
Status: NEW → ASSIGNED
Keywords: regression
OS: MacOS X → All
Hardware: Macintosh → All
Attached patch patch for win/unix/mac platforms (obsolete) — — Splinter Review
this patch includes the previous patch as well as the unix and windows specific bindings; these should allow for caret browsing to work
Attachment #97053 - Attachment is obsolete: true
Comment on attachment 97057 [details] [diff] [review] patch for win/unix/mac platforms sr=kin@netscape.com
Attachment #97057 - Flags: superreview+
*** Bug 165267 has been marked as a duplicate of this bug. ***
Comment on attachment 97057 [details] [diff] [review] patch for win/unix/mac platforms r=bzbarsky, though I'm not sure why we can't just leave these on the "baseBrowser" binding like they used to be...
Attachment #97057 - Flags: review+
Summary: Cannot PGUP and PGDOWN in MacOSX mozilla → Cannot PGUP and PGDOWN in mozilla
The reason we can't leave it on the base file is because the definitions are different on each platform. This is needed to keep platform behaviors with regards to caret browsing. I think this was explained in some comment in some bug (4302?) but regardless, here's the explanation again. :-) fix checked in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
*** Bug 165464 has been marked as a duplicate of this bug. ***
*** Bug 165479 has been marked as a duplicate of this bug. ***
*** Bug 165479 has been marked as a duplicate of this bug. ***
I'm still seeing the bug in a tree pulled after this was checked in. Linux, pulled 29 Aug 10:45a PDT.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
because of bug 115232 (or bug 144844 ? ), and this bug, it is sometimes impossible to scroll by page.
*** Bug 165548 has been marked as a duplicate of this bug. ***
I'm seeing this, too (Page up/down keys don't scroll, but spacebar does scroll down so I know focus is okay), on linux release build 2002082908.
OK. The problem is that nsGlobalWindow does not support the movepage* commands...
Attachment #97057 - Attachment is obsolete: true
Comment on attachment 97236 [details] [diff] [review] patch, tested and all r=aaronl If you want, add a comment that explains that cmd_scrollPage* is used for mac, and cmd_movePage* is used for other platforms, since mac doesn't move the caret on pageup/pagedown, even in browse with caret mode.
Attachment #97236 - Flags: review+
Comment on attachment 97236 [details] [diff] [review] patch, tested and all r=aaronl If you want, add a comment that explains that cmd_scrollPage* is used for mac, and cmd_movePage* is used for other platforms, since mac doesn't move the caret on pageup/pagedown, even in browse with caret mode.
Comment on attachment 97236 [details] [diff] [review] patch, tested and all sr=jag
Attachment #97236 - Flags: superreview+
Fix checked in.
Status: REOPENED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
Thanks! I can verify that it fixes the problem in my build.
*** Bug 165696 has been marked as a duplicate of this bug. ***
*** Bug 165762 has been marked as a duplicate of this bug. ***
*** Bug 165895 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: