1653248 - Cleanup ScopeCreationData stencil structures

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Ted Campbell [:tcampbell]]

After Bug 1651880, we allocate the js::Scopes from ScopeCreationData in a bulk operation. This now allows us to simplify the ScopeCreationData type to not have js::Scope point inline.

TODO

• Move scope_ field from ScopeCreationData to CompilationInfo
• Merge EnvironmentShapeCreationData with ScopeCreationData
• Replace JSClass* member with enum or make implicit
• Replace use of AbstractScopePtr if possible
• Rename to ScopeStencil or similar.
• Eliminate BindingIter field if possible.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1653248 - Add BASESHAPE_FLAGS to EnvironmentObject subclasses

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1653248 - Add js::BindingIter constructor for environment shape deferral

Depends on D84885

Comment 3

[Ted Campbell [:tcampbell]]

Attachment: Bug 1653248 - Remove EnvironmentShapeCreationData structure

TODO: Why does this fail tests?

Depends on D84886

Comment 4

[Ted Campbell [:tcampbell]]

Attachment: Bug 1653248 - Remove ScopeCreationData::scope_ field

Replace this field with a vector on CompilationInfo in a similar way to how
JSFunctions are handled.

Depends on D84887

Comment 5

[Ted Campbell [:tcampbell]]

Attachment: Bug 1653248 - Remove AbstractScopePtr from ScopeCreationData

Replace the enclosing scope field with a Maybe<ScopeIndex> field. When the
enclosing scope is an existing concrete scope, the CompilationInfo data will
be used instead.

Depends on D84888

Comment 6

[Ted Campbell [:tcampbell]]

Attachment: Bug 1653248 - Rename ScopeCreationData to ScopeStencil

Depends on D84889

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0967a48ff1e9
Add BASESHAPE_FLAGS to EnvironmentObject subclasses r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/54fe44a4fb99
Add js::BindingIter constructor for environment shape deferral r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/d3804a6daa30
Remove ScopeCreationData::scope_ field r=arai
https://hg.mozilla.org/integration/autoland/rev/e0384bee76bb
Remove EnvironmentShapeCreationData structure r=arai
https://hg.mozilla.org/integration/autoland/rev/1e4afa0fa381
Remove AbstractScopePtr from ScopeCreationData r=arai
https://hg.mozilla.org/integration/autoland/rev/c71cd0098f80
Rename ScopeCreationData to ScopeStencil r=arai

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/0967a48ff1e9
https://hg.mozilla.org/mozilla-central/rev/54fe44a4fb99
https://hg.mozilla.org/mozilla-central/rev/d3804a6daa30
https://hg.mozilla.org/mozilla-central/rev/e0384bee76bb
https://hg.mozilla.org/mozilla-central/rev/1e4afa0fa381
https://hg.mozilla.org/mozilla-central/rev/c71cd0098f80