1653588 - Preference mail.server.serverX.server_sub_directory not saved when set through GUI (Advanced Account Settings)

Status: VERIFIED FIXED

(Thunderbird :: Account Manager, defect)

Description

[beuguissime]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:72.0) Gecko/20100101 Firefox/72.0

Steps to reproduce:

Hello,

1/ Run Thunderbird 78 on Linux (freshly downloaded at http://ftp.mozilla.org/pub/thunderbird/releases/78.0b4/linux-x86_64/en-GB/thunderbird-78.0b4.tar.bz2)
2/ Try to force a value for "IMAP server directory" in the window "Advanced Account Settings".
3/ Confirm & close Thunderbird
4/ When reopened, the field is empty

It works when the pref is manually added to prefs.js

Actual results:

The input value is not saved to prefs.js as expected.
It seems also that any changes (e.g. untick "Allow server to override these namespace") made through the window "Advanced Account Settings" is reverted when Thunderbird is restarted.

Comment 3

[Khushil Mistry [:khushil324]]

Attachment: Bug-1653588_am-server-advanced-not-saving-0.patch

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9165344 [details] [diff] [review]
Bug-1653588_am-server-advanced-not-saving-0.patch

Review of attachment 9165344 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! r=mkmelin

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a46a437d6008
Fix preference mail.server.serverX.server_sub_directory not saved when set through GUI. r=mkmelin

Comment 7

[Khushil Mistry [:khushil324]]

Comment on attachment 9165344 [details] [diff] [review]
Bug-1653588_am-server-advanced-not-saving-0.patch

[Approval Request Comment]
Regression caused by (bug #): 1610445
User impact if declined: Users will not be able to save advanced server settings.
Testing completed (on c-c, etc.): 
Risk to taking this patch (and alternatives if risky): Low

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9165344 [details] [diff] [review]
Bug-1653588_am-server-advanced-not-saving-0.patch

This missed 79 beta. So it will appear in 80 beta after the merge. 

Taking this for 78.1.0 to avoid complexity of needing to remember doing this later with bug 1655210, even though it didn't go through beta.

NI Rob so it is clear, per bug 1655210 comment 4.
NI Walt so someone remembers to test advanced settings with steps of comment 0

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 78.1.0:
https://hg.mozilla.org/releases/comm-esr78/rev/fc9ca43c2ab8

Comment 10

[WaltS48 [:walts48]]

Walt never heard of "IMAP server directory" in Advanced Account Settings and the Configuration Options article wasn't much help.

The [Gmail] folder isn't the default?

I'm not sure how I would test this.

Comment 11

[Christian W.]

I've installed the Thunderbird V78.1.0 and I can confirm that the value in "IMAP server directory" ist set and saved in prefs.js

Comment 12

[Thomas D. (:thomas8)]

(In reply to Christian Wichner from comment #11)

I've installed the Thunderbird V78.1.0 and I can confirm that the value in "IMAP server directory" ist set and saved in prefs.js

Thanks!

(In reply to WaltS48 [:walts48] from comment #10)

I'm not sure how I would test this.

I guess that we could set an existing sub dir of IMAP as Imap server dir but I wouldn't try that on live accounts.
Instead, we could test this like this: setting up a non-existing IMAP account, tweaking the settings and checking if the respective prefs are created and their values preserved over restarts of TB (like Christian did).

Comment 13

[beuguissime]

Hi,
Thanks for the good work! Tested on v78.1.0 on a fresh profile and the bug seems indeed to be gone.

Comment 14

[WaltS48 [:walts48]]

(In reply to Thomas D. from comment #12)

(In reply to WaltS48 [:walts48] from comment #10)

I'm not sure how I would test this.

I guess that we could set an existing sub dir of IMAP as Imap server dir but I wouldn't try that on live accounts.
Instead, we could test this like this: setting up a non-existing IMAP account, tweaking the settings and checking if the respective prefs are created and their values preserved over restarts of TB (like Christian did).

I also didn't understand what Christian did.

Very happy it is working.