1688096 - Use Software WebRender for popups when using Hardware Webrender on Windows

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

We use basic for popups right now. It would be better if we used SW-WR. We should do this for anyone using SW-WR. Eventually we should consider doing this for HW-WR, but we'll use the SW-WR users as the test bed for this.

Comment 1

[Chris Peterson [:cpeterson]]

Andrew, do you expect to fix this bug to use SW-WR for popups before SW-WR rides the trains to Beta and Release?

This bug is breaking some WebExtensions popup UI when Fission is enabled: bug 1656086 and bug 1672470.

Comment 2

[Jim Mathies [:jimm]]

We're still determining our plans here. This bug is for that investigation.

Comment 3

[Chris Peterson [:cpeterson]]

Jeff and I chatted on Element. Jeff recommends that we defer this bug from M6c to M7. Of the bugs mentioned above as possibly related, both are M7. And bug 1656086 has been downgraded to just "incorrect spacing" (but still usable) and bug 1672470 is a test case with no known affected sites or extensions.

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1688096 - Part 1. Merge SW-WR and WR render texture host paths to allow mixed compositors.

Comment 5

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1688096 - Part 2. Add flag to CompositorOptions to allow SW-WR on a per widget basis.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6471b0910f45
Part 1. Merge SW-WR and WR render texture host paths to allow mixed compositors. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/6cdfa0af2278
Part 2. Add/use flag to CompositorOptions to allow SW-WR on a per widget basis. r=mattwoodrow

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing linux debug build bustage in layers/KnowsCompositor

Backout link: https://hg.mozilla.org/integration/autoland/rev/9837f1f237a7bbf0c64f8dd70715d32d39ae6624

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Crunning%2Cpending%2Crunnable&fromchange=888b284a38d9b9fff76acd3c988ded5cbe9d1d0c&searchStr=linux%2Cx64%2Cdebug%2Cbuild-linux64-base-toolchains%2Fdebug%2Cbb&selectedTaskRun=PXcbEUlEQMKCXxG5EmEU4A.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=330392125&repo=autoland&lineNumber=6322

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ad2f4d0c317
Part 1. Merge SW-WR and WR render texture host paths to allow mixed compositors. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/aa0d1698aff8
Part 2. Add/use flag to CompositorOptions to allow SW-WR on a per widget basis. r=mattwoodrow

Comment 9

[Cosmin Sabou [:CosminS]]

Backed out for win webrender sw_compositor related crashes.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&searchStr=bc%2Cwebrender&revision=aa0d1698aff83e2b433ea19f72197770556927f8&group_state=expanded&selectedTaskRun=aMOinqIhTLS_L1xkySFq5g.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=330416362&repo=autoland&lineNumber=2735

Backout link: https://hg.mozilla.org/integration/autoland/rev/7215fb5f0a224c4938b2480f667d395b93c1ff1a

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b63a3c2fb751
Part 1. Merge SW-WR and WR render texture host paths to allow mixed compositors. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/7e0fefcb981c
Part 2. Add flag to CompositorOptions to allow SW-WR on a per widget basis. r=mattwoodrow

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b63a3c2fb751
https://hg.mozilla.org/mozilla-central/rev/7e0fefcb981c