1672470 - Iframe in Popup window will be empty if "filter" CSS style is used and Fission is active

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[juraj.masiar]

Attachment: src.zip

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:83.0) Gecko/20100101 Firefox/83.0

Steps to reproduce:

1. make sure your Fission is active! (fission.autostart=true)
2. create an iframe in the popup with some filter style, for example:

<iframe src="http://benchmark.fastaddons.com/" style="filter: grayscale(50%)"></iframe>

I've prepared extension in attachment, so just load it and click the popup icon.

Actual results:

iframes with filter style won't load (or are not visible).

Expected results:

Filter should work on iframe in popup, it works when loaded into a tab, only in popup it's broken

Comment 1

[Chris Peterson [:cpeterson]]

Thanks for the test case, Juraj!

Nika can reproduce the bug with the test case.

kmag will investigate and then probably delegate to someone on the Graphics team.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Presumably this is due to bug 1559251, it's an issue on non-WebRender. And unfortunately we don't (yet) enable WebRender in popup windows.

Comment 3

[Neha Kochar [:neha]]

This is a Graphics issue and I'm hoping someone in the Graphics team can debug and work on this issue using the clear STR in this bug.

Comment 4

[Jim Mathies [:jimm]]

Hey Neha, this is non-webrender issue. Does the fission team care about this then?

Comment 5

[Jim Mathies [:jimm]]

Attachment: popup.jpg

Comment 6

[Jim Mathies [:jimm]]

Actually, never mind.

Comment 7

[Jeff Muizelaar [:jrmuizel]]

We should probably be using software webrender for those windows.

Comment 8

[Jim Mathies [:jimm]]

Attachment: webrender popup.jpg

Comment 9

[Jim Mathies [:jimm]]

We're thinking sw-wr for popups will fix this.

Comment 10

[Jeff Muizelaar [:jrmuizel]]

I tried enabling hardware webrender on those windows they failed to have transparency

Comment 11

[Jim Mathies [:jimm]]

https://searchfox.org/mozilla-central/search?q=WidgetTypeSupportsAcceleration&redirect=false

Comment 12

[Jeff Muizelaar [:jrmuizel]]

We'll need bug 1687124 fixed to get proper transparency.

Comment 13

[Tomislav Jovanovic :zombie]

If this is only for (iframes, in a popup, with a css filter), it can probably be M7.

Comment 14

[Jim Mathies [:jimm]]

Should be fixed by bug 1688096.

Comment 15

[juraj.masiar]

I see bug 1688096 is fixed, so should this be now fixed in Nightly 88.0a1 (2021-02-26)? Because I can still reproduce the issue.
Also I've noticed my Developer Edition is now affected as well, seems like the Fission got activated.

I'm using filter style to implement dark mode in my Web Translate addon, so this bug breaks it completely. Should I start looking for a different solution or is this gonna be fixed before it reaches Release channel? I don't know what M7 means.

Comment 16

[Neha Kochar [:neha]]

Jim, the reporter says this is still reproducible with Fission. Can someone from Graphics team look into this?

Comment 17

[Neha Kochar [:neha]]

juraj.masiar , Fission is now available to be enabled via the pref in Beta and Release (via Bug 1674871) so that's why you are able to observe the effect in your dev edition version too. You can turn Fission on/off using fission.autostart pref followed by a restart.

We are hoping to finish Fission M7 work in Fx88, which goes to Beta on March 22 and to Release on April 20. https://wiki.mozilla.org/Release_Management/Calendar has all the branch release dates for your reference.

Comment 18

[Jim Mathies [:jimm]]

Attachment: Updated addon src

Comment 19

[Jim Mathies [:jimm]]

Attachment: capture.jpg

Comment 20

[Jim Mathies [:jimm]]

This is fixed, however the new feature is behind a pref at the moment - gfx.webrender.software.unaccelerated-widget.allow

Comment 21

[juraj.masiar]

Was the software WebRender disabled again for popups?
Because this bug reapers for me in the current Beta 89.0b13.