1656938 - Editing a message filter produces an elongated dialog that sometimes crashes (the dialog, not the whole app)

Status: RESOLVED WORKSFORME

(Thunderbird :: Filters, defect)

Description

[stevem]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.105 Safari/537.36

Steps to reproduce:

This is occurring in 78.1.0 (64-bit) on Windows 10 version 2004 build 19041.423.
Tools|Message Filters, then in the combo box next to "Filters for:" I select an account. I see a list of filters for that account.
When I "Edit..." any particular filter, a dialog pops up as expected but it's non-scrollable no matter many matches are in the list. So I see a vertically elongated Edit dialog for many of these filters.
For one of my filters which has a very long list of matches, I'll describe what happens after I click "Edit..." for it:
The dialog takes a long while to load.
After it loads, I see a vertical dialog that stretches beyond the bottom of my screen.
If I try to move or resize this dialog, it vanishes/crashes and I can't see any way to retrieve it.
The "Message Filters" window is stuck and I can't do anything with it.
I can however go to the main Thunderbird window and do other things. But "Message Filters" is frozen.
I have to go to Windows Task Manager and end the Thunderbird task(s) and open Thunderbird again to have normal full use (including working with filters) again.

Actual results:

Steps to reproduce explain what happened.

Expected results:

The dialog for editing filters shouldn't have been vertically elongated and the list of matches should be scrollable. If that was the case, there likely would be no dialog vanishing/crash if the match list was very long.

Comment 1

[Wayne Mery (:wsmwk)]

One of these perhaps https://mzl.la/33msuMT ?

Comment 2

[stevem]

Another bug references the non-scrollability of the matches, but I didn't see anything about the edit dialog crash and freezing of "Message Filters".

Comment 3

[stevem]

Bug 1633306 is the one about non-scrollability, btw.

Comment 4

[Wayne Mery (:wsmwk)]

bug 1588155 is a hang (referred to by bug 1655338)

Comment 5

[stevem]

(In reply to Wayne Mery (:wsmwk) from comment #4)

bug 1588155 is a hang (referred to by bug 1655338)

That's not what I'm reporting in this bug.

Comment 6

[Wayne Mery (:wsmwk)]

Your bug title indicates a crash - which is more often a hang and why i referenced that bug report.
If it is really a crash, please post your crash ID here. see https://support.mozilla.org/en-US/kb/mozilla-crash-reporter-tb

Comment 7

[stevem]

It's the vanishing or crash of a dialog. Of course, I see a hang on the way to that dialog crash and feature freeze, which are the keys to the uniqueness of this report, unless another report I haven't seen is around somewhere.

Comment 8

[stevem]

The unique part of this report (as far as I can tell at this point):

If I try to move or resize this dialog, it vanishes/crashes and I can't see any way to retrieve it.
The "Message Filters" window is stuck and I can't do anything with it.
I can however go to the main Thunderbird window and do other things. But "Message Filters" is frozen.

Comment 9

[stevem]

I forgot to note that this problem didn't exist in version 68.
Also, to further clarify the unique aspect of this bug, the "unique part" in Comment 8 applies only when I have a long list of matches (>28) in the filter. And it's when I resize the dialog that it vanishes/crashes -- I'm able to move it around as of today (I'm not sure what changed). Last, I was mistaken about having to go to Task Manager and end Thunderbird tasks. I can go to the main Thunderbird window and File|Exit.

So, following are reworked Steps to Reproduce based on the above:

Tools|Message Filters, then in the combo box next to "Filters for:" I select an account. I see a list of filters for that account.
When I "Edit..." any particular filter, a dialog pops up as expected but it's non-scrollable no matter many matches are in the list. So I see a vertically elongated Edit dialog for many of these filters.
For one of my filters which has a very long list of matches (>28), I'll describe what happens after I click "Edit..." for it:
The dialog takes a long while to load.
After it loads, I see a vertical dialog that stretches beyond the bottom of my screen.
If I try to resize this dialog, it vanishes/crashes and I can't see any way to retrieve it.
The "Message Filters" window is frozen and I can't do anything with it.
I can however go to the main Thunderbird window and do other things. But "Message Filters" is frozen.
I have to go to the main window, do File|Exit and open Thunderbird again to have normal full use (including working with filters) again.

Comment 10

[Twixy]

Hello,

I have the same problem.
i have a filter with lot's of rules inside (near 50).
i can't edit the filter because there's no scrolling vertical bar with the editing windows and the windows is to small for sea all.
under thunderbird 68 there was no problem with it.
since i passed in the new version it make very slow to edit the windows filter and in can't validate the rules because no button under.
it's freezing a moment and i can only close the windows (by clicking the cross on the right top of the window).

Comment 11

[Magnus Melin [:mkmelin]]

Twixy: bug 1633306.

stewem: please attach a screenshot

Comment 12

[stevem]

I'm not sure how to do a screenshot of a crash. I think my description of the problem is pretty thorough.

Comment 13

[Magnus Melin [:mkmelin]]

Not of the crash but of the "After it loads, I see a vertical dialog that stretches beyond the bottom of my screen"

Comment 14

[Twixy]

https://www.noelshack.com/2020-34-1-1597674814-filtres.jpg

Comment 15

[stevem]

Attachment: Geo2vYkJxV.png

This is a top-to-bottom slice of my desktop, showing the elongated dialog. Note that my Windows taskbar is set to be at the top, and the blue portion is from another app.

Comment 16

[Wayne Mery (:wsmwk)]

After it loads, I see a vertical dialog that stretches beyond the bottom of my screen.
If I try to move or resize this dialog, it vanishes/crashes and I can't see any way to retrieve it.

Sounds similar to the issue Richard worked on

Comment 17

[Richard Marti (:Paenglab)]

Attachment: msgFilterRules.dat

Yes, the tall dialog is what I should have fixed in bug 1633306.

But we could use this bug for the slowness of opening the dialog (which could look like a crash). Attached is a simple filterRules file which shows already a opening delay of some seconds. Sometimes also a non-responsive feedback. And this on a Rizen 7.

Comment 18

[Magnus Melin [:mkmelin]]

No that's bug 1588155 .

Comment 19

[Richard Marti (:Paenglab)]

Then this bug should be duped to one of the two others.

Comment 20

[stevem]

If I try to resize this dialog, it vanishes/crashes and I can't see any way to retrieve it.

Is this duplicated anywhere?

Comment 21

[stevem]

This is fixed for me in 78.2.0. Thanks everyone!