Closed Bug 1588155 Opened 5 years ago Closed 2 years ago

Long message filter (e.g. 100 rule filters) hangs Thunderbird, after de-xbl

Categories

(Thunderbird :: Filters, defect, P2)

Tracking

(thunderbird_esr68- wontfix, thunderbird_esr78+ affected, thunderbird_esr102 unaffected)

RESOLVED FIXED
95 Branch
Tracking Status
thunderbird_esr68 - wontfix
thunderbird_esr78 + affected
thunderbird_esr102 --- unaffected

People

(Reporter: jdundas, Assigned: henry-x)

References

()

Details

(5 keywords, Whiteboard: [needs profile][regression:tb68][filtermgmt])

Attachments

(4 files)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

I have a Message Filter with 615 matching OR conditions. This filter is used to delete unwanted senders. Other, much shorter filters also exist for other functions.

Actual results:

Attempting to edit the long filter causes Thunderbird to hang for a minute or so. Eventually the GUI comes up and allows editing. Saving or Canceling the edit operation causes Thunderbird to hang again, at least a minute, maybe two. Eventually the application is usable again. The entire application is unresponsive while this is going on.

Expected results:

The GUI should have been more responsive, maybe 1 second to open the filter editor, maybe 2 seconds to save, no latency at all to cancel. The remainder of the application should be responsive regardless of the editor.

Yes, I can also see this with a 100 rule filter. Just opening the Edit fitler dialog takes minutes on a top of the line CPU.
I think this was better in the past. I could be a regression of all the conversions from listitem to richlistitem and from XBL to Custom elements.

But for me clicking Cancel is fast.

Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: perf
OS: Unspecified → All
Hardware: Unspecified → All
See Also: → 444793
Keywords: regression

should be easy to generate a testcase, or get one.
who to resolve?

Severity: normal → critical
Flags: needinfo?(mkmelin+mozilla)
Whiteboard: [regression:tb68]

Depends on what the cause turns out to be. The regression-window would be useful. But for that, a test-case filter file would be good.

Flags: needinfo?(mkmelin+mozilla)
Keywords: testcase-wanted
Summary: Long message filter hangs Thunderbird → Long message filter (e.g. 100 rule filters) hangs Thunderbird

I doubt the filter contents matter so surely any developer can create a testcase, or ask the reporter for his copy.
So in that case, which developer gets to debug?

Flags: needinfo?(mkmelin+mozilla)

Well still simpler if someone already has a test case they can share.
Code should be around https://searchfox.org/comm-central/rev/7239cf2f15a50c02fb7a004c9ee0eee2afe088b0/mailnews/base/search/content/FilterEditor.js#69

I'd like to wait until we have the requested data and info before anyone is assigned.

Flags: needinfo?(mkmelin+mozilla)

jdundas can you share your filter file with magnus please?

Flags: needinfo?(jdundas)

If jdundas doest not reply, here is an example of a long filter that is problematic with 60.9.1 (works with error message 'Filter failed') and 68.3.1 (editing hangs). The new entries were added at the top, so removing the first 10 entries will probably reset normal operation.

name="From"
enabled="yes"
type="17"
action="Custom"
customId="filtaquilla@mesquilla.com#noBiff"
action="Move to folder"
actionValue="imap://pa.com@imap.free.fr/Junk"
condition="OR (from,contains,no-reply@lefil.com) OR (from,is,medecine) OR (from,contains," par ") OR (from,contains,nba ) OR (from,contains,pression.fr) OR (from,contains,pierre ricaud) OR (from,contains,derhy.com) OR (from,contains,giftcard) OR (from,contains,gift card) OR (from,contains,newsletter@email.andertons.co.uk) OR (from,contains,pompe à chaleur) OR (from,contains,yves rocher) OR (from,contains,coup de coeur) OR (from,contains,distribution-conso) OR (from,contains,intermarché) OR (from,contains,parapluie) OR (from,contains,damart) OR (from,contains,burger king) OR (from,contains,aide-ménagère) OR (from,contains,national-instant) OR (from,contains,vie plus simple) OR (from,contains,super maison) OR (from,contains,andrew zhan) OR (from,contains,bureau du tourisme) OR (from,contains,dressage) OR (from,contains,isolez) OR (from,contains,révélation) OR (from,contains,revelation) OR (from,contains," jus ") OR (from,contains,prix cassé) OR (from,contains,courses en ligne) OR (from,contains,monnaie virtuelle) OR (from,contains,urinaire) OR (from,contains,rosé) OR (from,contains," par ") OR (from,contains," by ") OR (from,contains,isolation) OR (from,contains,emerige) OR (from,contains,autobutle) OR (from,contains,elite rencontre) OR (from,contains,loi Pope) OR (from,contains,emprunt) OR (from,contains,animal) OR (from,contains,medi-market) OR (from,contains,astucesenfolie) OR (from,contains,aphrodisiaque) OR (from,contains,santé articulaire) OR (from,contains,incomparable) OR (from,contains,dispositif gouvernemental) OR (from,contains,sauna) OR (from,contains,avoscartons) OR (from,contains,chewing) OR (from,contains,homéo) OR (from,contains,alcoo) OR (from,contains,reprise auto) OR (from,contains,bonplan) OR (from,contains,pépite) OR (from,is,groupon) OR (from,contains,interdit au public) OR (from,contains,cheptel) OR (from,contains,devis assurance) OR (from,contains,solabaie) OR (from,contains,CCTV) OR (from,contains,légume) OR (from,contains,comptoir des langues) OR (from,contains,douleur) OR (from,contains,high tech) OR (from,contains,montre) OR (from,contains,pocket mouse) OR (from,contains,croquette) OR (from,contains,de qualités) OR (from,contains,problème de santé) OR (from,contains,méthode naturelle) OR (from,contains,laitier responsable) OR (from,contains,atomiseur x) OR (from,contains,interdit au public) OR (from,contains,perte de poids) OR (from,contains,expert auto) OR (from,contains,cheptel laitier) OR (from,contains,assurance obsèques) OR (from,contains,openclassrooms) OR (from,contains,magique) OR (from,contains,ceinture chauffante) OR (from,contains,vin rouge) OR (from,contains,vin rosé) OR (from,contains,vin rose) OR (from,contains,vin blanc) OR (from,contains,annee blanche) OR (from,contains,année blanche) OR (from,contains,vinci immobilier) OR (from,contains,voyage culinaire) OR (from,contains,suite à votre demande) OR (from,contains,suite a votre demande) OR (from,contains,smart drive) OR (from,contains,redbysfr) OR (from,contains,bluffe) OR (from,contains,vins et champagnes) OR (from,contains,guide du trader) OR (from,contains,cannatrade) OR (from,is,ETAI) OR (from,contains,mode éthique) OR (from,contains,petit bateau) OR (from,contains,patrimoneuf) OR (from,contains,leservicedesastuces) OR (from,contains,fonction publique) OR (from,contains,dolce vita) OR (from,contains,sfr by) OR (from,contains,sfr par) OR (from,contains,2019) OR (from,contains,résides études) OR (from,contains,officiel des vacances) OR (from,contains,scenesafe) OR (from,contains,monte-escalier) OR (from,contains,curcu) OR (from,contains,anti-age) OR (from,contains,e.leclerc) OR (from,contains,loopas) OR (from,contains,lokéo) OR (from,contains,atlas for men) OR (from,contains,cap petite enfance) OR (from,contains,SFR par) OR (from,contains,SFR by) OR (from,contains,S F R) OR (from,contains,café) OR (from,contains,bureau de support) OR (from,contains,à domicile) OR (from,contains,keikoslim) OR (from,contains,autoemotion) OR (from,contains,enquete carrefour) OR (from,contains,archibien) OR (from,contains,idees maison) OR (from,contains,teammarketing) OR (from,contains,topdomainsalexa) OR (from,contains,performance-assurance) OR (from,contains,info finance) OR (from,contains,carrefour banque) OR (from,contains,plan voyage) OR (from,contains,vinaigre) OR (from,contains,leclerc ticket) OR (from,contains,salaun holidays) OR (from,contains,epicerie fine) OR (from,contains,maladie rare) OR (from,contains,pharmaclic) OR (from,contains,hiscox) OR (from,contains,velux) OR (from,contains,Meilleurtaux.com) OR (from,contains,Immobulle) OR (from,contains,teammarketing13.fr) OR (from,contains,Feng Shui) OR (from,contains,culbir.fr) OR (from,contains,morbur.fr) OR (from,contains,foncia via) OR (from,contains,solaireshop) OR (from,contains,colis-free.fr) OR (from,contains,worldpanel) OR (from,contains,Infos Santé) OR (from,contains,gumcyl.fr) OR (from,contains,lavinia) OR (from,contains,fininvester.fr) OR (from,contains,cilnar.fr) OR (from,contains,ski express) OR (from,contains,immobilier neuf) OR (from,contains,devis alarme) OR (from,contains,Catherine OVIER) OR (from,contains,cinedrahivine.fr) OR (from,contains,loisirsetfinances.fr) OR (from,contains,catchinnews.fr) OR (from,contains,88jobs.fr) OR (from,contains,laboratoire sante) OR (from,contains,matinconso.fr) OR (from,contains,vinaigre madeleine) OR (from,contains,solsal.fr) OR (from,contains,etai.fr) OR (from,contains,ultra premium) OR (from,contains,one budget) OR (from,contains,coursdeclic.fr) OR (from,contains,big moustache) OR (from,contains,chauffage via) OR (from,contains,Bartholomée Sayant) OR (from,contains,taculeubaver.fr) OR (from,contains,CroisiEurope) OR (from,contains,matinconso.fr) OR (from,contains,Vertbaudet) OR (from,contains,LilChild) OR (from,contains,kunague.fr) OR (from,contains,justfab) OR (from,contains,elixir) OR (from,contains,jardinices.fr) OR (from,contains,be-info) OR (from,contains,lemhu.fr) OR (from,contains,Reduction Fiscale) OR (from,contains,loslas.fr) OR (from,contains,gratuite en ligne) OR (from,contains,melimela.fr) OR (from,contains,travelski) OR (from,contains,lecielouvert.fr) OR (from,contains,incroyable-divers.fr) OR (from,contains,ete indien) OR (from,contains,été indien) OR (from,contains,DR. Marthe MERLIN) OR (from,contains,truitoibe.fr) OR (from,contains,Complémentaire santé) OR (from,contains,lebon-jour) OR (from,contains,Résidence Etudiante) OR (from,contains,lugbir.fr) OR (from,contains,Vilain secret) OR (from,contains,luisayneuf.fr) OR (from,contains,news-technologie.fr) OR (from,contains,Fitness) OR (from,contains,auto-montre.fr) OR (from,contains,Hippopotamus) OR (from,contains,solcal.fr) OR (from,contains,KeepCool) OR (from,contains,tati) OR (from,contains,forfait power) OR (from,contains,senioriale) OR (from,contains,Biotyfull) OR (from,contains,physioth) OR (from,contains,cultura) OR (from,contains,dettes) OR (from,contains,un secret) OR (from,contains,Chausport) OR (from,contains,Residences Etudiantes) OR (from,contains,merck.DevelopmmentApp.com) OR (from,contains,shave club) OR (from,contains,immobilier de france) OR (from,contains,yves saint laurent) OR (from,contains,temps-des-consos) OR (from,contains,enquête routière) OR (from,contains,Enquête Essence) OR (from,contains,incontournable) OR (from,contains,amour physique) OR (from,contains,independance royale) OR (from,contains,comme j'aime) OR (from,contains,shopping deal) OR (from,contains,devis gratuit) OR (from,contains,maniatwo.fr) OR (from,contains,axa banque) OR (from,contains,buffalo gril) OR (from,contains,il x elle) OR (from,contains,traveline) OR (from,contains,curcuma) OR (from,contains,MarketingShort.com) OR (from,contains,Léon de Bruxelles) OR (from,contains,infos-direct.fr) OR (from,contains,vacances d'été) OR (from,contains,mieuxplacer) OR (from,contains,Votre animal) OR (from,contains,pataterie) OR (from,contains,millionnaires) OR (from,contains,via point Divers) OR (from,contains,Cigna.com) OR (from,contains,Isolation & Travaux) OR (from,contains,lingerie) OR (from,contains,entretien jardin) OR (from,contains,excursion) OR (from,contains,grandbonjour.fr) OR (from,contains,z-eshop) OR (from,contains,l'express) OR (from,contains,galaxy) OR (from,contains,atita sasu) OR (from,contains,anti-âge) OR (from,contains,obseques) OR (from,contains,oferting) OR (from,contains,villages nature) OR (from,contains,depart-imminent) OR (from,contains,demande de prêt) OR (from,contains,Audrey blanchard) OR (from,contains,départ immédiat) OR (from,contains,fimmobu) OR (from,contains,nocibe) OR (from,contains,chauffeur privé) OR (from,contains,frichti) OR (from,contains,actu people) OR (from,contains,center parc) OR (from,contains,adoucisseur) OR (from,contains,box voyage) OR (from,contains,psychologie) OR (from,contains,juliette trudeau) OR (from,contains,body slim) OR (from,contains,promod) OR (from,contains,f_r_) OR (from,contains,complements Alimentaires) OR (from,contains,couponandgo.com) OR (from,contains,Prêt bancaire) OR (from,contains,merci) OR (from,contains,meetic) OR (from,contains,bravo) OR (from,contains,free-fr) OR (from,contains,dfgd) OR (from,contains,articulations) OR (from,contains,air-france) OR (from,contains,fortunespeed) OR (from,contains,Pierre&Vacances) OR (from,contains,service~mobile) OR (from,contains,-) OR (from,contains,formula swiss) OR (from,is,free.fr) OR (from,contains,C_B_D) OR (from,contains,2018) OR (from,contains,Test0) OR (from,contains,pour la vie) OR (from,contains,clicplan) OR (from,contains,FREE_mo) OR (from,contains,sync team) OR (from,contains,) OR (from,contains,votre voiture) OR (from,contains,testo) OR (from,contains,piscine) OR (from,contains,balsamik) OR (from,contains,plaisir sexuel) OR (from,contains,boutique plaisir) OR (from,contains,maillot officiel) OR (from,contains,IS0LATION) OR (from,contains,healsy) OR (from,contains,1euro) OR (from,contains,netflix) OR (from,contains,winamax) OR (from,contains,f-r-e) OR (from,contains,-R) OR (from,contains,leader senior) OR (from,contains,residences seniors) OR (from,contains,d.i.s) OR (from,contains,boxtal) OR (from,contains,guide archi) OR (from,contains,deezer) OR (from,contains,auditif) OR (from,contains,f.r.e) OR (from,contains,catalogue de vacances) OR (from,contains,ventes-privees) OR (from,contains,point assurance) OR (from,contains,weight watchers) OR (from,contains,extension de maison) OR (from,contains,Little Cigogne) OR (from,contains,Coeur d'Or) OR (from,contains,packlink) OR (from,contains,hotel lotus) OR (from,contains,FIFA) OR (from,contains,le point) OR (from,contains,Guide innovation) OR (from,contains,megabase) OR (from,contains,’) OR (from,contains,edf enr) OR (from,contains,imprim encre) OR (from,contains,tapisserie) OR (from,contains,supermarché) OR (from,contains,camif) OR (from,contains,zago) OR (from,contains,vacances express) OR (from,contains,point auto) OR (from,contains,leader patrimoine) OR (from,contains,gymgem) OR (from,contains,boostez) OR (from,contains,Salle de Bain) OR (from,contains,guess) OR (from,contains,Conseil Finances) OR (from,contains,quitoque) OR (from,contains,cosmétologue) OR (from,contains,secret jeunesse) OR (from,contains,autobiz) OR (from,contains,alinea) OR (from,contains,courir.com) OR (from,contains,surprise) OR (from,contains,les-moments-forts) OR (from,contains,24H le Mans) OR (from,contains,tout savoir) OR (from,contains,SFR) OR (from,contains,SVA France) OR (from,contains,Vacances-Location.net) OR (from,contains,amplifon) OR (from,contains,Maisons du Monde) OR (from,contains,Mercedes-Benz) OR (from,contains,Douleurs articulaires) OR (from,contains,Tuba) OR (from,contains,🔴) OR (from,contains,mensualité) OR (from,contains,choisir.com) OR (from,contains,Estée Lauder) OR (from,contains,norauto) OR (from,contains,super-tech.fr) OR (from,contains,Le Slip) OR (from,contains,MonAlbumPhoto) OR (from,contains,crédit) OR (from,contains,Abris de Piscine) OR (from,contains,Abri de piscine) OR (from,contains,ECOFIT) OR (from,contains,vins) OR (from,contains,Croisières) OR (from,contains,Bouygues) OR (from,contains,Crypto-Monnaie) OR (from,contains,leyroy) OR (from,contains,24h du Mans) OR (from,contains,histoire d'or) OR (from,contains,prêt personnel) OR (from,contains,Aviva Vie) OR (from,contains,Emotion Gaz) OR (from,contains,beauty box) OR (from,contains,maquillage) OR (from,contains,MOVIE FLIX) OR (from,contains,brulafine) OR (from,contains,2O18) OR (from,contains,santiane.fr) OR (from,contains,tshirt) OR (from,contains,Volkswagen Driving Experience) OR (from,contains,Lafuma immobilier) OR (from,contains,douche) OR (from,contains,azureva) OR (from,contains,matelas) OR (from,contains,minounou.fr) OR (from,contains,DevisTresVite) OR (from,contains,endettement) OR (from,contains,epidemie silencieuse) OR (from,contains,airfrance) OR (from,contains,derma institute) OR (from,contains,menage) OR (from,contains,armani) OR (from,contains,loi pinel) OR (from,contains,Loi Pinel) OR (from,contains,troubles digestifs) OR (from,contains,travaux de peinture) OR (from,contains,radiateur) OR (from,contains,Réduisez vos impôts) OR (from,contains,tryvexan) OR (from,contains,arthrose) OR (from,contains,mafinea) OR (from,contains,boutique du plaisir) OR (from,contains,rentinvest) OR (from,contains,amazonaws) OR (from,contains,Lanieri) OR (from,contains,vétérinaire) OR (from,contains,cannabis) OR (from,contains,outilstactiques) OR (from,contains,Rénovation électrique) OR (from,contains,CommeJaime) OR (from,contains,BOSE) OR (from,contains,prix canon) OR (from,contains,DYS0N) OR (from,contains,flashlight) OR (from,contains,credit) OR (from,contains,adidas) OR (from,contains,recompense) OR (from,contains,---) OR (from,contains,dyson) OR (from,contains,stream) OR (from,contains,AIRFRANCE 2O18) OR (from,contains,zara) OR (from,contains,Slip Français) OR (from,contains,primark) OR (from,contains,crdits) OR (from,contains,curcuma) OR (from,contains,anti-douleur) OR (from,contains,digestion) OR (from,contains,tompress) OR (from,contains,sondage) OR (from,contains,B00KIN) OR (from,contains,//) OR (from,contains,micronutrition) OR (from,contains,une-belle-option) OR (from,contains,bien dormir) OR (from,contains,reside etude) OR (from,contains,expert radiateur) OR (from,contains,mobalpa) OR (from,contains,prostate) OR (from,contains,isolation des combles) OR (from,contains,point voyages) OR (from,contains,Roth-hybride) OR (from,contains,Willemse) OR (from,contains,mobilhome) OR (from,contains,devis isolation) OR (from,contains,vive mon casino) OR (from,contains,fenetre) OR (from,contains,celuraid) OR (from,contains,RomanceDates) OR (from,contains,Leon de Bruxelles) OR (from,contains,felicitations) OR (from,contains,Test0-Ultra) OR (from,contains,érection) OR (from,contains,Crypto curve) OR (from,contains,Test0-Ultra) OR (from,contains,épice indienne) OR (from,contains,TryVexin) OR (from,contains,nike) OR (from,contains,Cell'Innov) OR (from,contains,seat) OR (from,contains,Puressentiel) OR (from,contains,neamour) OR (from,contains,service-free.fr) OR (from,contains,Domitys) OR (from,contains,AIIIREFRANCE) OR (from,contains,F_R_E) OR (from,contains,A-M) OR (from,contains,follicle) OR (from,contains,douche) OR (from,contains,land rover) OR (from,contains,voyance) OR (from,contains,village nature) OR (from,contains,cancer) OR (from,contains,nutella) OR (from,contains,Stream_Direct) OR (from,contains,0-neam0ur) OR (from,contains,minceur) OR (from,contains,[E.D.F]) OR (from,contains,Olliscience) OR (from,contains,la-mode) OR (from,contains,regardez) OR (from,contains,Reducavenue) OR (from,contains,par data) OR (from,contains,saamsung) OR (from,contains,vos impots vous informe) OR (from,contains,pandora par) OR (from,contains,infos finance) OR (from,contains,perfume) OR (from,contains,regroupement de crédits) OR (from,contains,Cellinnov) OR (from,contains,captainlove) OR (from,contains,bonnesnouvelles) OR (from,contains,via rodeo) OR (from,contains,bouygues immobilier) OR (from,contains,loi pinel) OR (from,contains,point finance) OR (from,contains,c.adeau) OR (from,contains,peinture via) OR (from,contains,LPOSTE) OR (from,contains,Bouygues immobilier) OR (from,contains,congrats) OR (from,contains,perfume) OR (from,contains,esmailselysees) OR (from,contains,Placement Bitcoin) OR (from,contains,Geant CSN) OR (from,contains,Service.C) OR (from,contains,E-lecle) OR (from,contains,gagnant) OR (from,contains,L-IDL) OR (from,contains,ampoules) OR (from,contains,) OR (from,contains,pierre et vacance) OR (from,contains,Pharmasimple) OR (from,contains,vendre sa voiture) OR (from,contains,animal de compagnie) OR (from,contains,Look Voyages) OR (from,contains,La_Poste) OR (from,contains,L-I_D) OR (from,contains,E-D.F) OR (from,contains,La_Poste) OR (from,contains,Cogedim) OR (from,contains,Amz0nX) OR (from,contains,spar) OR (from,contains,votre laboratoire) OR (from,contains,AMAZ0N2018) OR (from,contains,lid.l) OR (from,contains,lumière du jour) OR (from,contains,asterix) OR (from,contains,air**france) OR (from,contains,magasin vert) OR (from,contains,Solutions immobilières) OR (from,contains,LP Promotion) OR (from,contains,A-M-A_-Z_-O_-N) OR (from,contains,aspirateur) OR (from,contains,Cellinnov) OR (from,contains,economie) OR (from,contains,mes-solutions-patrimoine.fr) OR (from,contains,Scandale) OR (from,contains,Lingette) OR (from,contains,Ehpad) OR (from,contains,Dernier-jour) OR (from,contains,estimez ) OR (from,contains,newsletter@loisiplay.fr) OR (from,contains,assuria) OR (from,contains,[AMZ0N]) OR (from,contains,Helline) OR (from,contains,mademoiselle lingerie) OR (from,contains,Test0Ultra) OR (from,contains,Immoconcept) OR (from,contains,guillaume-conseil.fr) OR (from,contains," Felicitati0ns") OR (from,contains,Assurance emprunteur) OR (from,contains,Bebloom) OR (from,contains,EUODIA) OR (from,contains,L'Agence MD) OR (from,contains,Tara Jarmon) OR (from,contains,Locat'me) OR (from,contains,AUCHAN_2O18) OR (from,contains,Eco_PlaneteVerte) OR (from,contains,support@flea.orderjournal.com) OR (from,contains,FIFA2018) OR (from,contains,BPD Marignan) OR (from,contains,indemniflight) OR (from,contains,u-investir) OR (from,contains,locatour) OR (from,contains,culligan) OR (from,contains,mediaveil) OR (from,contains,recettes) OR (from,contains,simulez) OR (from,contains,bitcoinbank) OR (from,contains,fatigue) OR (from,contains,miracle) OR (from,contains," par ") OR (from,contains," by ") OR (from,contains,promod) OR (from,contains,abrisud) OR (from,contains,desmarques) OR (from,contains,so premium) OR (from,contains,uneffort) OR (from,contains,auchan.fr) OR (from,contains,parfum) OR (from,contains,bijou) OR (from,contains,mcdonalds) OR (from,contains,tabac) OR (from,contains,réside etudes) OR (from,contains,casin0) OR (from,contains,isolation combles) OR (from,contains,tickbox) OR (from,contains,casinodream) OR (from,contains,bonjourinfos) OR (from,contains,ciel-info) OR (from,contains,vacances-camping) OR (from,contains,atomiseurx) OR (from,contains,laboratoire lescuyer) OR (from,contains,lafuma mobilier) OR (from,contains,agrihome) OR (from,contains,les-belles-annees) OR (from,contains,plan assurance) OR (from,contains,point finance) OR (from,contains,probiotic) OR (from,contains,by pointfinance) OR (from,contains,par data) OR (from,contains,par trippy) OR (from,contains,m-e-r-c-i) OR (from,contains,inter-marche) OR (from,contains,par la bonne info) OR (from,contains,hypertension) OR (from,contains,mutuhall) OR (from,contains,f-r-e-e) OR (from,contains,e_leclerc) OR (from,contains,préfon) OR (from,contains,enchantier.com) OR (from,contains,reside etudes) OR (from,contains,lefil.com) OR (from,contains,ventes privées) OR (from,contains,vente privée) OR (from,contains,vente privee) OR (from,contains,ventes privees) OR (from,contains,pierre & vacances) OR (from,contains,Volkswagen par) OR (from,contains,sfr via) OR (from,contains,Volkswagen via) OR (from,contains,Volkswagen by) OR (from,contains,sfr par) OR (from,contains,excedence) OR (from,contains,leader price) OR (from,contains,conserves d'autrefois) OR (from,contains,see by c) OR (from,contains,doctuba) OR (from,contains,bandit box) OR (from,contains,SFR by) OR (from,contains,investissement bitcoin) OR (from,contains,empruntis) OR (from,contains,cuisine actuelle) OR (from,contains,monoprix) OR (from,contains,medium amanda) OR (from,contains,l'exception) OR (from,contains,guide de l'immobilier) OR (from,contains,extension maison) OR (from,contains,pat'patrouille) OR (from,contains,immovesting) OR (from,contains,diaqueucar) OR (from,contains,lagrandeinfo.fr) OR (from,contains,point shopping) OR (from,contains,docteur jaquer) OR (from,contains,perfclic) OR (from,contains,innovationnature) OR (from,contains,zenlife) OR (from,contains,pandora) OR (from,contains,weltauto) OR (from,contains,jaguar) OR (from,contains,modair) OR (from,contains,center parcs) OR (from,contains,dorcel) OR (from,contains,tryba) OR (from,contains,bazarchic) OR (from,contains,locservice) OR (from,contains,mon habitat) OR (from,contains,devis peinture) OR (from,contains,criteo) OR (from,contains,bien ici) OR (from,contains,buzionweb) OR (from,contains,expertisemail) OR (from,contains,cplussur) OR (from,contains,hand spinner) OR (from,contains,sommeil) OR (from,contains,réside étude) OR (from,contains,lampe torche) OR (from,contains,animaux) OR (from,contains,linvosges) OR (from,contains,ray-ban) OR (from,contains,alinéa) OR (from,contains,instalavista) OR (from,contains,sans commission) OR (from,contains,mon magasin général) OR (from,contains,audika) OR (from,contains,dr rmi) OR (from,contains,rgime) OR (from,contains,impts) OR (from,contains,monte escalier) OR (from,contains,pierre et vacances) OR (from,contains,télésurveillance) OR (from,contains,easyshower) OR (from,contains,galeries lafayette) OR (from,contains,marc dorcel) OR (from,contains,evaluation auto) OR (from,contains,opel) OR (from,contains,aterno) OR (from,contains,alfa roméo) OR (from,contains,aide à domicile) OR (from,contains,astuce étonnante) OR (from,contains,cap vacances) OR (from,contains,chaussures femmes) OR (from,contains,expert-fenetre) OR (from,contains,sport plus) OR (from,contains,france isolation) OR (from,contains,sephora) OR (from,contains,nao) OR (from,contains,youpicar) OR (from,contains,coca-cola) OR (from,contains,atlas for men) OR (from,contains,mycrazybox) OR (from,contains,vigneron) OR (from,contains,Mathon) OR (from,contains,Picard) OR (from,contains,Skoda) OR (from,contains,verisure) OR (from,contains,Censi-Bouvard) OR (from,contains,presbyte) OR (from,contains,lexus) OR (from,contains,Pinel) OR (from,contains,jobijoba) OR (from,contains,ludokado) OR (from,contains,contrat.electronique) OR (from,contains,HallesPrivees) OR (from,contains,courrier@apreslachat.com) OR (from,contains,yakarouler.com) OR (from,contains,newsletter@email.photobox.fr) OR (from,contains,ca-pyreneesgascognemailing.fr) OR (from,contains,newsletter@ebuyclub.com) OR (from,contains,charles@maxoutil.com) OR (from,contains,beauxlivres@etai.ccemails.net) OR (from,contains,venteprivee.com) OR (from,contains,Tookam Direct) OR (from,contains,noreply@lefil.com) OR (from,contains,cfr-recouvrement) OR (from,contains,newsletter-edf) OR (from,contains,etai@etai) OR (from,contains,mutuelle) OR (from,contains,easy shower) OR (from,contains,monmagasingénéral)"

Thanks Pierre

Flags: needinfo?(mkmelin+mozilla)

(In reply to Wayne Mery (:wsmwk) from comment #7)

jdundas can you share your filter file with magnus please?

Yes:
name="Immediate Delete"
enabled="yes"
type="17"
action="JunkScore"
actionValue="100"
action="Delete"
condition="OR (from,contains,winhosting) OR (from,contains,osius) OR (from,contains,powerpr4@la.twcbc.com) OR (from,contains,kaspersky) OR (from,contains,marlabs) OR (from,contains,couchbase) OR (from,contains,northbay-networks.com) OR (from,contains,aujas.com) OR (from,contains,onixnet.com) OR (from,contains,str8creative.to) OR (from,contains,techhealthsummit.com) OR (from,contains,powerprinc.com) OR (from,contains,send2nd.com) OR (from,contains,kisco.com) OR (from,contains,youvisit.com) OR (from,contains,kimco.com) OR (from,contains,integrationpartners.com) OR (from,contains,ubertal.co) OR (from,contains,indexengines.com) OR (from,contains,alteryx.com) OR (from,contains,cognitiveis.com) OR (from,contains,raisecom.us) OR (from,contains,cprime) OR (from,contains,procureadvisor) OR (from,contains,cpacinc) OR (from,contains,dataconnectors) OR (from,contains,iresq.com) OR (from,contains,atimi.com) OR (from,contains,binarytree.com) OR (from,contains,itechnodesk.com) OR (from,contains,omnikronsystems.com) OR (from,contains,contact-client.com) OR (from,contains,genesys.com) OR (from,contains,focusite.com) OR (from,contains,birdrockusa.com) OR (from,contains,getgsi.com) OR (from,contains,decideconsulting.com) OR (from,contains,trapptechnology.com) OR (from,contains,luminanetworks.com) OR (from,contains,logicmonitor) OR (from,contains,fireeye) OR (from,contains,webroot) OR (from,contains,emtecinc) OR (from,contains,eschoolnews.com) OR (from,contains,getrdx.com) OR (from,contains,kelltontech.com) OR (from,contains,sadasystems.com) OR (from,contains,datrium.com) OR (from,contains,alteryx.com) OR (from,contains,treasuredatainsights.com) OR (from,contains,execrank.com) OR (from,contains,seamgen.com) OR (from,contains,oracle) OR (from,contains,mellanox.com) OR (from,contains,demandblue.com) OR (from,contains,gopanterra.com) OR (from,contains,calpion.com) OR (from,contains,regulatorywebinar.com) OR (from,contains,virsec.com) OR (from,contains,logdna.com) OR (from,contains,streamsets.com) OR (from,contains,thevcstore.com) OR (from,contains,foxitpdf.com) OR (from,contains,guardicore.com) OR (from,contains,learnnowonlinemail.com) OR (from,contains,polycom.com) OR (from,contains,altaisystems.com) OR (from,contains,panopta.net) OR (from,contains,datarpm) OR (from,contains,thetotalemaildelivery) OR (from,contains,synegi) OR (from,contains,jbmerchant-capital) OR (from,contains,sonicwall.com) OR (from,contains,catalystux.com) OR (from,contains,aerospike.com) OR (from,contains,1105data.com) OR (from,contains,snowflake.net) OR (from,contains,rackspace.com) OR (from,contains,lenovo.com) OR (from,contains,technosolutionsdesk.com) OR (from,contains,amtekbd.com) OR (from,contains,itrootinfo.com) OR (from,contains,innominds.com) OR (from,contains,adp.com) OR (from,contains,cyflare.com) OR (from,contains,sap.com) OR (from,contains,werty.biz) OR (from,contains,sprint.com) OR (from,contains,cmmiinstitute.com) OR (from,contains,lynbrooksolutions.com) OR (from,contains,carlsonwagonlit.com) OR (from,contains,partnerinpublishing.com) OR (from,contains,fusionstorm.com) OR (from,contains,vmc-capital.net) OR (from,contains,anythingcloud.us) OR (from,contains,cloudyincalifornia.com) OR (from,contains,kemptechnologies.com) OR (from,contains,crowdstrike.com) OR (from,contains,lookerdata.com) OR (from,contains,cogecopeer1.com) OR (from,contains,irsinvoice.com) OR (from,contains,techjini.co) OR (from,contains,anansysstaffing.com) OR (from,contains,cxo.com) OR (from,contains,accelerance.com) OR (from,contains,cio.com) OR (from,contains,guest-touch.com) OR (from,contains,thlmun.org) OR (from,contains,skillsoft.com) OR (from,contains,citrix.com) OR (from,contains,d3security.com) OR (from,contains,techtrendsmedia.com) OR (from,contains,trendmicro.com) OR (from,contains,vpnalternative.com) OR (from,contains,growthzone.com) OR (from,contains,progress.net) OR (from,contains,theprofessional.co) OR (from,contains,radware.com) OR (from,contains,netapp.com) OR (from,contains,gadgetellsolutions.com) OR (from,contains,li9.com) OR (from,contains,ecampusnews.com) OR (from,contains,techinforoot.com) OR (from,contains,softserveinc.com) OR (from,contains,accedian.com) OR (from,contains,donomasoftware.com) OR (from,contains,adarit.com) OR (from,contains,zerostack.com) OR (from,contains,aspect-consulting.us) OR (from,contains,miroconsulting-mail.com) OR (from,contains,FDACOMPLIANCEPANEL.COM) OR (from,contains,HEALTHCOMPLIANCEPANEL.COM) OR (from,contains,aqscences.com) OR (from,contains,globalsign.com) OR (from,contains,ringcentral-phone.us) OR (from,contains,talener.com) OR (from,contains,shirucafe.com) OR (from,contains,destinationdelivers.com) OR (from,contains,vertical-knowledge.com) OR (from,contains,quickstart.com) OR (from,contains,netspi.com) OR (from,contains,lookerdata.com) OR (from,contains,workmarket.com) OR (from,contains,sixdisciplines.co) OR (from,contains,softnice.com) OR (from,contains,paseahotel.com) OR (from,contains,gmx.com) OR (from,contains,corero.com) OR (from,contains,ontargetsolutions.co) OR (from,contains,onica.com) OR (from,contains,gitprime.co) OR (from,contains,w3global.com) OR (from,contains,growthaccelerationpartners.com) OR (from,contains,trajectus.com) OR (from,contains,bluevoyant.com) OR (from,contains,complianceiq.com) OR (from,contains,cambaycs.com) OR (from,contains,cmmiinstitute.com) OR (from,contains,iocorp.com) OR (from,contains,coresite.com) OR (from,contains,diamanti.com) OR (from,contains,kitrum.com) OR (from,contains,execrank.com) OR (from,contains,bigpanda.io) OR (from,contains,intelliswift.com) OR (from,contains,directtechtalent.com) OR (from,contains,TS-Marketing.solutions) OR (from,contains,cybercoders.com) OR (from,contains,verizonenterprise.com) OR (from,contains,itnewswire.com.au) OR (from,contains,3marketeers) OR (from,contains,teknofornow) OR (from,contains,onmailpro) OR (from,contains,mapr) OR (from,contains,comparebusinessproducts) OR (from,contains,todaysreport) OR (from,contains,infofocus) OR (from,contains,prosertifications) OR (from,contains,vhtcx) OR (from,contains,cbts) OR (from,contains,tech-talksummits) OR (from,contains,stablepath) OR (from,contains,eggplant.io) OR (from,contains,superiorexecutiveservices) OR (from,contains,mktgimpactcouncil) OR (from,contains,involvesoft) OR (from,contains,rigidbits) OR (from,contains,b2bwhitepaperhub) OR (from,contains,strategicrp) OR (from,contains,dataragroup) OR (from,contains,analytixds) OR (from,contains,customerdynamics) OR (from,contains,xledger) OR (from,contains,meritagecollection.com) OR (from,contains,globalcyberinstitute) OR (from,contains,sios) OR (from,contains,dimensiondata) OR (from,contains,sourcemedianews) OR (from,contains,qtsdatacenters) OR (from,contains,wework) OR (from,contains,graviebenefits) OR (from,contains,e-lansa.com) OR (from,contains,techsolutions) OR (from,contains,truglo) OR (from,contains,evoketechnologies) OR (from,contains,interrait) OR (from,contains,dorgresearch) OR (from,contains,corsa) OR (from,contains,avepoint) OR (from,contains,solutionsgroup.services) OR (from,contains,videoconferencestore) OR (from,contains,enterpriseservices.business) OR (from,contains,procurebizmedia) OR (from,contains,thechannelcompany) OR (from,contains,cio-leadership) OR (from,contains,vonage) OR (from,contains,frescodata) OR (from,contains,citspl.co) OR (from,contains,goacs.io) OR (from,contains,bitsighttech) OR (from,contains,smurgles) OR (from,contains,superiorexecutiveservices) OR (from,contains,mainnerve) OR (from,contains,source-forge.net) OR (from,contains,reduxio.com) OR (from,contains,gitprimehq.com) OR (from,contains,neohiresouth) OR (from,contains,lscpu) OR (from,contains,crowdstrikecommunications) OR (from,contains,wallarm) OR (from,contains,tech-information) OR (from,contains,comakeit) OR (from,contains,andiamo) OR (from,contains,snaplogic) OR (from,contains,synerzip) OR (from,contains,Crayon) OR (from,contains,argyleannouncements) OR (from,contains,volumecases.com) OR (from,contains,mondo.com) OR (from,contains,infotechrg.com) OR (from,contains,techtalk-summits.com) OR (from,contains,techtalksummits.com) OR (from,contains,qconnects.com) OR (from,contains,egmonitors.com) OR (from,contains,rdxdbas.com) OR (from,contains,acceptic) OR (from,contains,tbi-events) OR (from,contains,reloadux) OR (from,contains,argyleforum) OR (from,contains,rubrik) OR (from,contains,thesecureitad) OR (from,contains,surgeappdev) OR (from,contains,evosecurity) OR (from,contains,novoscale) OR (from,contains,qlik) OR (from,contains,netsuite) OR (from,contains,cintra) OR (from,contains,boxboat) OR (from,contains,crowdstrikec) OR (from,contains,keepabl) OR (from,contains,aciinfotech) OR (from,contains,area1security) OR (from,contains,mimeo.com) OR (from,contains,vplssolutions) OR (from,contains,newcityinsuranceinc) OR (from,contains,bairesdev) OR (from,contains,objectivity) OR (from,contains,dscomm) OR (from,contains,sourcesoftsolutions) OR (from,contains,atomve) OR (from,contains,recruitingforless) OR (from,contains,execusearchllc) OR (from,contains,strongboxdata) OR (from,contains,lennonwright) OR (from,contains,bridgestonegolf) OR (from,contains,expansion-capital) OR (from,contains,na-ca-mail) OR (from,contains,alldarlings) OR (from,contains,fetchcerts) OR (from,contains,sterlinghoffman) OR (from,contains,ptcom) OR (from,contains,emailneed) OR (from,contains,karyaservices) OR (from,contains,toriihq) OR (from,contains,nonprofitwebadvisor) OR (from,contains,dell.com) OR (from,contains,docauthority) OR (from,contains,alliedc2) OR (from,contains,destinationhotels) OR (from,contains,curvature) OR (from,contains,techcounsel) OR (from,contains,eno8apps) OR (from,contains,rawvma) OR (from,contains,pcm.com) OR (from,contains,ecxsystems) OR (from,contains,arissearch) OR (from,contains,help4access) OR (from,contains,snowflake) OR (from,contains,indiumsoft) OR (from,contains,voxility) OR (from,contains,dialpad) OR (from,contains,fortitudetechnology) OR (from,contains,sunrisehitek) OR (from,contains,netapplicationpro) OR (from,contains,grceducators) OR (from,contains,aditumpartners) OR (from,contains,expertforitilforcert) OR (from,contains,9star) OR (from,contains,msofficewebinars) OR (from,contains,newcloudmail) OR (from,contains,clearedin) OR (from,contains,emailmit) OR (from,contains,audiosolutionzs) OR (from,contains,qemailserver) OR (from,contains,bitdefender) OR (from,contains,crosscodepanoptics) OR (from,contains,ciowest) OR (from,contains,expertforpmpcert) OR (from,contains,lifesize) OR (from,contains,stonebranch) OR (from,contains,testframework) OR (from,contains,securelink) OR (from,contains,apintegration) OR (from,contains,ipv4connect) OR (from,contains,bpmonline) OR (from,contains,cloudian) OR (from,contains,paloaltonetworks) OR (from,contains,employ.io) OR (from,contains,infogovworld) OR (from,contains,ktsnetworks) OR (from,contains,premierbpo) OR (from,contains,twolinecode) OR (from,contains,yitsol) OR (from,contains,intacct) OR (from,contains,zixcorp) OR (from,contains,betterinternetproject) OR (from,contains,koakea) OR (from,contains,incenter) OR (from,contains,cloveretl) OR (from,contains,execmagic) OR (from,contains,tetherview) OR (from,contains,atmecs) OR (from,contains,stig) OR (from,contains,ostendio) OR (from,contains,levelaccess) OR (from,contains,j4systems) OR (from,contains,eg-monitors) OR (from,contains,xcelservicesgroup) OR (from,contains,covalense) OR (from,contains,wobi) OR (from,contains,eg-monitoring) OR (from,contains,sourcecoders) OR (from,contains,research-and-markets) OR (from,contains,kitrumdevs) OR (from,contains,freshworks) OR (from,contains,markitelligence) OR (from,contains,igtraining) OR (from,contains,pulsesecure) OR (from,contains,connectlab) OR (from,contains,ucsfirst) OR (from,contains,a5econsulting) OR (from,contains,vartechnologyfinance) OR (from,contains,channelfutures) OR (from,contains,techoinsightmedia) OR (from,contains,vcube) OR (from,contains,cybercodersrecruiting) OR (from,contains,dowjones) OR (from,contains,ibo.) OR (from,contains,ddnstorage) OR (from,contains,looker) OR (from,contains,b2binfowire) OR (from,contains,iconmn) OR (from,contains,csky) OR (from,contains,harveynashusa) OR (from,contains,extrahop) OR (from,contains,logigear) OR (from,contains,rezilyens) OR (from,contains,ezuce) OR (from,contains,itknowledgestore) OR (from,contains,ExhibitorInvites) OR (from,contains,idg.com) OR (from,contains,techeventmedia) OR (from,contains,rht.com) OR (from,contains,telzio) OR (from,contains,thechannelco) OR (from,contains,peopleten) OR (from,contains,tuv-sud-america) OR (from,contains,pronixinc) OR (from,contains,comodo) OR (from,contains,itapplicationspro) OR (from,contains,mushroom) OR (from,contains,4mitpro) OR (from,contains,lanairgroup) OR (from,contains,tadapix) OR (from,contains,peopletechgroup) OR (from,contains,lagash) OR (from,contains,datamaticssolutions) OR (from,contains,onlinewhitepaper) OR (from,contains,knowbe4) OR (from,contains,customerfirstcommunications) OR (from,contains,verticalresponse) OR (from,contains,vresp) OR (from,contains,continuent) OR (from,contains,tech-funnel) OR (from,contains,thirddoormedia) OR (from,contains,ethiov) OR (from,contains,chit-te) OR (from,contains,TrimaxAmericas) OR (from,contains,wxwcsy) OR (from,contains,impigertech) OR (from,contains,itreports-pub) OR (from,contains,select-tel) OR (from,contains,acquia) OR (from,contains,vantagesoftworks) OR (from,contains,compliancecertified) OR (from,contains,starshotregional) OR (from,contains,managedserviceconsult) OR (from,contains,idgenterprise) OR (from,contains,techrestore) OR (from,contains,fieldsquared) OR (from,contains,portworx) OR (from,contains,dlink) OR (from,contains,go-ringcentral) OR (from,contains,digitalnetworksgroup) OR (from,contains,researchandmarkets) OR (from,contains,bluerose-tech) OR (from,contains,talentlogic) OR (from,contains,wirewheel) OR (from,contains,patriot) OR (from,contains,generationaldevelopment) OR (from,contains,mangoapps) OR (from,contains,razorthink) OR (from,contains,rippling) OR (from,contains,psi-staffing) OR (from,contains,ctoadvice) OR (from,contains,marketing) OR (from,contains,toyaja) OR (from,contains,zailab) OR (from,contains,nadevops) OR (from,contains,avanan) OR (from,contains,atlas7) OR (from,contains,lexisnexis) OR (from,contains,filesgroup) OR (from,contains,itempcorp) OR (from,contains,jamf) OR (from,contains,taskontips) OR (from,contains,mist) OR (from,contains,empirix) OR (from,contains,invokecloud) OR (from,contains,happiestminds) OR (from,contains,tigerdirect) OR (from,contains,convergence) OR (from,contains,armorpoint) OR (from,contains,isomglobal) OR (from,contains,omt.business) OR (from,contains,dinCloud) OR (from,contains,quick-updates) OR (from,contains,hotelviking) OR (from,contains,wdnetlabs) OR (from,contains,simx) OR (from,contains,marketinfos) OR (from,contains,clarencepoint) OR (from,contains,ali-inc) OR (from,contains,nttamerica) OR (from,contains,mbdainvisiontour) OR (from,contains,t5datacenters) OR (from,contains,bravesoft) OR (from,contains,zscaler) OR (from,contains,msprojectsgroup) OR (from,contains,erp-staff) OR (from,contains,thestorrance) OR (from,contains,pmtech) OR (from,contains,menlo-technologies) OR (from,contains,devtechstaff) OR (from,contains,bradfordsystems) OR (from,contains,on-target) OR (from,contains,teamlogicitca) OR (from,contains,stonefly) OR (from,contains,tetratech) OR (from,contains,ctamericas) OR (from,contains,networkafterwork) OR (from,contains,blockchain) OR (from,contains,orangebeats) OR (from,contains,.club) OR (from,contains,weka.) OR (from,contains,doinggoodagency) OR (from,contains,avogtal) OR (from,contains,amtechwebresources) OR (from,contains,mapanything) OR (from,contains,company.online) OR (from,contains,sincusa) OR (from,contains,method360webinars) OR (from,contains,spirion) OR (from,contains,bluecatnetworks) OR (from,contains,nextleveltraining) OR (from,contains,protelligentdev) OR (from,contains,infotech) OR (from,contains,riverbed) OR (from,contains,nastel) OR (from,contains,zammadvisors) OR (from,contains,inrule) OR (from,contains,morningstarcorp) OR (from,contains,amcomsolutions) OR (from,contains,grceduwebinars) OR (from,contains,singlemindconsulting) OR (from,contains,codefresh) OR (from,contains,tpxevents) OR (from,contains,readwritelabs) OR (from,contains,wisdominterface) OR (from,contains,servicenow) OR (from,contains,solutions-driven) OR (from,contains,acumatica) OR (from,contains,qnary) OR (from,contains,getlore) OR (from,contains,coreinfrasecurities) OR (from,contains,allstream) OR (from,contains,rsystems) OR (from,contains,tonic) OR (from,contains,studio98) OR (from,contains,laplink) OR (from,contains,surgedevapp) OR (from,contains,avtexs) OR (from,contains,iconsshops) OR (from,contains,careerlearning) OR (from,contains,upiq) OR (from,contains,bankersweb) OR (from,contains,otava) OR (from,contains,ptc) OR (from,contains,xplentyetl) OR (from,contains,Energyprosnow) OR (from,contains,h5datacenters) OR (from,contains,prutech) OR (from,contains,langspire) OR (from,contains,shieldx) OR (from,contains,intelligonetworks) OR (from,contains,intagleo) OR (from,contains,kpievents) OR (from,contains,enjoythecourses) OR (from,contains,uipep) OR (from,contains,vgpersonnel) OR (from,contains,levitatemedia) OR (from,contains,hitachivantara) OR (from,contains,wavecrestcomputing) OR (from,contains,avantleadership) OR (from,contains,protelligent) OR (from,contains,mode2) OR (from,contains,kloudone) OR (from,contains,velosio) OR (from,contains,harness) OR (from,contains,internationalexecusearch) OR (from,contains,usclaro) OR (from,contains,dminc) OR (from,contains,onixnetworking) OR (from,contains,secureends) OR (from,contains,blueappt) OR (from,contains,rsisecurity) OR (from,contains,softniceinc) OR (from,contains,communityinsightinitiative) OR (from,contains,tpx) OR (from,contains,computacenter) OR (from,contains,shapesecurity) OR (from,contains,edify) OR (from,contains,saasspace) OR (from,contains,8x8webinars) OR (from,contains,stackpath) OR (from,contains,quazo-systems) OR (from,contains,techinfoevent) OR (from,contains,disrupt) OR (from,contains,onetelcloud) OR (from,contains,floorly) OR (from,contains,vibriefingdelivers) OR (from,contains,trilogyed) OR (from,contains,fibercircuit) OR (from,contains,aotmp) OR (from,contains,infoane) OR (from,contains,ensable) OR (from,contains,carouselindustrieswebinars) OR (from,contains,appmix-intro) OR (from,contains,Trianz) OR (from,contains,cloudcheckr) OR (from,contains,bearcloudtech) OR (from,contains,gotomeeting) OR (from,contains,unsubscribe-services) OR (from,contains,idevnews) OR (from,contains,gent-corp) OR (from,contains,waytocert) OR (from,contains,voipxchange) OR (from,contains,ciovisions) OR (from,contains,scylladb) OR (from,contains,craftcareers) OR (from,contains,linkedin) OR (from,contains,sumologic) OR (from,contains,langfort) OR (from,contains,techjini-inc) OR (from,contains,copyrightengine) OR (from,contains,survivecyber) OR (from,contains,talend) OR (from,contains,jobot) OR (from,contains,quartzevents) OR (from,contains,comersson) OR (from,contains,citrix) OR (from,contains,francis-partners) OR (from,contains,dinsmoresteelehr) OR (from,contains,selectconferencing) OR (from,contains,quartznetwork) OR (from,contains,extremenetworks) OR (from,contains,tekmindz) OR (from,contains,zspace) OR (from,contains,alm.com) OR (from,contains,banzaihq) OR (from,contains,ivalu8) OR (from,contains,excensureitexcellence) OR (from,contains,gigadatacenters) OR (from,contains,cortekx) OR (from,contains,salesforce)"

Flags: needinfo?(jdundas)

My filter produces (harmless) error when running in Thunderbird 60.9.1. By removing a chunk from top, the error disappears.
In Thunderbird 68.3.1, editing my filter hangs, even editing the shorter version hangs.
I confirm totally the description of John Dundas.

I have no add-on and I have disabled all extensions.

Apparently it's the createSearchRow that is slow, or rather appendChild that happens there is slow, like 100-150ms per row, which obviously adds up. I tried changing it to using a DocumentFragment and appending that fragment in one go, but it didn't help much :(

While I see a few possible improvements that could be made to the custom elements in question, none of them seem to have any larger effect.

 let row = document.createXULElement("menulist");
 row.appendChild(document.createXULElement("menupopup"));
 something.appendChild(row);

The above is 10-11ms on avg in my testing, which certainly seems like a lot. Compared to appending an<html:select> which around 0.02ms.

Brian, any thoughts?

Flags: needinfo?(mkmelin+mozilla) → needinfo?(bgrinstead)

(In reply to Magnus Melin [:mkmelin] from comment #15)

While I see a few possible improvements that could be made to the custom elements in question, none of them seem to have any larger effect.

 let row = document.createXULElement("menulist");
 row.appendChild(document.createXULElement("menupopup"));
 something.appendChild(row);

The above is 10-11ms on avg in my testing, which certainly seems like a lot. Compared to appending an<html:select> which around 0.02ms.

Brian, any thoughts?

Could you take a profile of the slow behavior? I'm curious if we are seeing time spent inside the custom elements implementations themselves or if this is DOM-related.

Flags: needinfo?(bgrinstead) → needinfo?(mkmelin+mozilla)

As I could not stay forever with an outdated version of Thunderbird, I sorted, broke apart 820 rules into 17 filters, each having at most 50 rules. With Thunderbird 68.4.2 I don't have the spinning wheel of death (I am on a Mac), the delay to edit one filter is a few seconds (instead of unnoticeable with the older version 60.9.1).

One component has slowed down from 60.9.1 to 68.4.2.
This component is sensitive to rule number (or rule order ? this is unlikely).
It could be some sorting operation that was added in a library.

Also the interface is not adapted to handling hundreds of rules. Some thinking is required.

Flags: needinfo?(mkmelin+mozilla)
Whiteboard: [regression:tb68] → [needs profile][regression:tb68]

Hello, I see this bug report is slowly chugging along, and I would like to offer some info. I also have extreme hangs with the filter, but not for the reasons the reporter notes.

I have an incredible hang when first opening a filter for editing, even if the filter is not complex. I have a filter with 16 "Message starts with" rules that completely freezes Thunderbird for ~5min on first open. Each time I hit the add filter button after that completely freezes Thunderbird for 1-3 minutes before the box for a new filter is displayed.

I am on Ubuntu 16.04 with 16GB ram and an Intel i7, so I do not believe my computer is that slow for this to be expected behavior. If anyone can guide me, I would be happy to profile my install or share some offending rulesets.

I feel that my original report perhaps is misunderstood. The hanging of the system does not occur with a higher number filters but when one of the filters starts to contain more than about 100 emailadresses (and rules). I have for example 22 filters and one of them contains 850 emailadresses (and of course rules) and is growing daily. In particular when I want to add a new emailadress to this filter 850 entries it takes up the computer completely for 1½ minutes before releasing it for the actual editing. This time is increasing while I add more emailadresses. The other filters with few entries come up quickly for editing.

Huh, my bug might be different then. I have 25 filters (because I split some of them into many parts as a futile attempt at a solution), but it hangs Thunderbird for a full minute to bring up the edit screen for a filter I have with 1 filter and 1 action.

Alex, may you have many folders? What is your TB version?

The info I get in the about page confirms what I thought, I am on Thunderbird 68.10.0 (64-bit). I am on Ubuntu 16.04 (64-bit), I do not know if I said that already.

I am not sure what you mean by 'folder' here, so I will try to answer all the different things I think you might mean:

  • Mail Folders - I have 25/49 depending on whether you count archives, I compact these regularly despite never having other speed problems with Thunderbird (seriously, I am not sure if the filter slowness would even be noticed with some clients)
  • Message Filters - I have 25 top-level filters, and I am not aware of any to make sub-filters, so this can't be it
  • Operations Inside a Filter - I do not think this is it, at least within specific filters. I just clocked 43 seconds to open a filter with ALL(to-is, subject-begins-with, subject-ends-with), and I'm pretty sure this is not intended. I do have filters that are longer, but it seems that other people have similar speeds despite having 500 filters, so I think there is some other thing slowing it down.

If it was something else, just say and I'll update you!

Severity: critical → S1
Keywords: testcase-wanted

Alice, could you find the regression window for this? (requested by Wayne in comment 3 and Magnus in comment 4)

Choose one testcase between attachment 9167719 [details] and attachment 9167721 [details], and copy that into an existing text file named msgFilterRules.dat on the test profile (stub file should exist, overwrite the 2 lines of content). Profile folder: Account settings > Server settings > Local Directory.
If you're using mozregression-gui, you can persist the profile between test runs.

Flags: needinfo?(alice0775)

This is from de-xbl.

Flags: needinfo?(alice0775)

(In reply to Alex from comment #24)

Huh, my bug might be different then. I have 25 filters (because I split some of them into many parts as a futile attempt at a solution), but it hangs Thunderbird for a full minute to bring up the edit screen for a filter I have with 1 filter and 1 action.

OK, so you do not have many folders (which was also a reason for slowness in one bug). If it takes you 1 minute to open a filter with a single action, then we need more info on what it it. Does it have many rules/conditions in the filter?

Okay, I have what I think is a super helpful clue to the cause of the slowness. I just opened up my message filters and hit 'new'. This took 13 full seconds to load on its own, during which the filters menu was unresponsive. I believe, because of this, that there may be a few different slowdown periods that are being added together here.

Aceman, it took me a minute to figure out which filter I had been referring to, but here is what it is:
ALL-OF(TO-IS(USER@EXAMPLE.COM)) => MOVE-MESSAGE('/Foo/Bar')
I (obviously) renamed things, but this is the exact structure of the message, including moving into a folder in a folder. Selected options are apply when "Manually Run", "Getting new Mail: Filter before Junk Classification" and no others. Filter name is short and ascii-only, as are the email and folder names.

I have another filter of the same form that is one higher in the filter ordering that also takes 13 seconds (I measured the same time, so it is consistent), another filter (3 SUBJECT-IS, ANY, 1 MOVE action) takes 41 seconds, and another filter (7 FROM-IS & 4 TO-IS, ANY, 1 MOVE action) takes 120 seconds. This all suggests a roughly linear time per filter rule (I got 10.6x+4.33 in a regression, but I can test more if you think that would be helpful) with some startup cost as well.

Thanks for your effort, I appreciate it as this is my ONLY problem I've ever had with Thunderbird.

OK, so if you see it also with "New" filter, this bug isn't for you :) This one is strictly about the super-modern widgets for filter rules being slower than the old ones.
Yours looks more like bug 1504141.

Blocks: 1656938
See Also: → 1660597
Whiteboard: [needs profile][regression:tb68] → [needs profile][regression:tb68][filtermgmt]

This would be from de-xbl.

Flags: needinfo?(bugzilla2007)
Flags: needinfo?(acelists)

Right now every time I bring TB to the front after bringing my Macbook out of sleep TB goes busy (rotating rainbow) for several minutes, without me doing anything, haven't touched any of the user interface at all.

Actually I don't even have to bring the Macbook out of sleep. Every time I bring TB back into focus I get the spinning rainbow. A real pain in the butt.

V78.2.2

Just now I got the rotating rainbow in the middle of editing an email message. I've gotten them now in several different places in TB. I'm thinking maybe there's some sort of garbage creation/collection problem maybe?

(In reply to Magnus Melin [:mkmelin] from comment #39)

This would be from de-xbl.

Shouldn't be difficult then given we have a testcase (comment 8). Can you assign someone? If comment 8 isn't sufficient then one of the effected users can provide a testcase.

(In reply to Doug Hockin from comment #43)

I've gotten them now in several different places in TB. I'm thinking maybe there's some sort of garbage creation/collection problem maybe?

This bug is strictly about a specific issue only in filters, not a general problem. Your issue may be one of these https://mzl.la/3cIMfRe Please CC yourself on one or more of them to stay informed, but please only comment if you have a set of steps which reliably reproduces the issue, and is likely to allow someone else to reproduce using those steps.

Flags: needinfo?(enzo.o) → needinfo?(mkmelin+mozilla)

ORA funziona CORRETTAMENTE
Grazie

Alex, can you look at this regression? It has testcase data.

Flags: needinfo?(mkmelin+mozilla) → needinfo?(alessandro)
Summary: Long message filter (e.g. 100 rule filters) hangs Thunderbird → Long message filter (e.g. 100 rule filters) hangs Thunderbird, after de-xbl

Based on what was highlighted by Magnus in comment 14 and comment 15, this seems to be tricky.
Also, the overall interface of that filter edit dialog doesn't really scale well when dealing with multiple filters, so that's something else to consider for future improvements.

I'll take a look at this later this week to leverage a multi-thread worker.
Maybe we could overcome this issue temporarily by letting the edit window load and load the filter list in another thread in the background, showing a loading message in the richlistitem area.

Flags: needinfo?(alessandro)

It's the actual appending to the dom that's slow, so threads can't help.

See Also: → 1465076

(In reply to Magnus Melin [:mkmelin] from comment #48)

It's the actual appending to the dom that's slow, so threads can't help.

which solution is more doable now to dig ourselves out of this hole, doing bug 1465076, working around the xpcom issue, or some other approach?

Severity: S1 → S2
Flags: needinfo?(mkmelin+mozilla)

I think we first need to find out (through profiling) why appending is so slow, and hopefully fix it.
Maybe some hybrid approach is also needed so that 20 rules are loaded at start, and more, in chunks(?) once the dialog has loaded.

Flags: needinfo?(mkmelin+mozilla)
Priority: -- → P2

Can you create a performance profile please where the filter size is say 50-70, and post the url here?
SEe instructions at https://support.mozilla.org/en-US/kb/profiling-thunderbird-performance

Flags: needinfo?(ron-eefje)
Flags: needinfo?(bugzilla)

I confirm the issue with TB 78.
I created a filter for undesired senders (spam) which is approximatively 200 items OR conditions
When tryin to edit (add an item): the windows "filter rules" freeze for at least 30 s and sometimes never end.

I confirm the issue with TB 78.6.1 (64-bit
I created a filter for finance important which is over 230 items
When trying to edit (add an item): the windows "filter rules" freeze never end.
There is nothing wrong with TB to alleviate the situation I have set up finance important2 which works perfectly. The first filter still works as a filter but will not edit or accept new items

I can confirm this issue. It's a regression I first noticed when running 78.7.0 32-bit, though it may have been there a while as I don't edit my filters often. I resolved it by removing old entries until my filter was small enough to load quickly. I have 35 entries now, I used to have around 100, and it would take around 15 seconds to load.

Can you create a performance profile please where the filter size is say 50-70, and post the url here?

See instructions at https://support.mozilla.org/en-US/kb/profiling-thunderbird-performance

@Wayne Mery (:wsmwk) could you please specify who is "you"? I assume any of the affected reporters? Or anyone with a test file?

(In reply to Thilo.Ertel from comment #61)

@Wayne Mery (:wsmwk) could you please specify who is "you"? I assume any of the affected reporters? Or anyone with a test file?

anyone who can reproduce - so both

Sorry for the delay as I've been moving, but the included profile should work. Although I have no idea how many filters I have offhand, I assume this will be more useful than nothing in figuring out what is going on.

Before starting the recording, I opened the "Message Filters" box. I then started the recording and attempted to edit a filter. That is all that is happening in TB during this recording.

https://share.firefox.dev/3uysRxS

Flags: needinfo?(bugzilla)
See Also: → 1504141

Hey Henry, are you able to investigate this?
Most likely there's something sketchy going on with the creation of the search row and the consequential append of that element to the DOM.
https://searchfox.org/comm-central/rev/97df616aa8cdd0eeaa4af84c13994402bb4099d8/mailnews/search/content/searchTerm.js#395-400

I'm not sure if the row element itself with all those child elements (multiple menulsits and logic to show/hide options based on selected elements) is causing the slow down, or is the append itself.

We should also consider loading only an initial subset of filters and then load the rest on scroll.

Flags: needinfo?(henry)

Hello, if can be useful for you, I've seen that if I delete the file global-messages-db.sqlite all works better, but just for a short time.
My file is reaching 5GB in more or less 1 week. The maximum amount that I've seen is about 8GB, but in this case all become very slow and unstable.
I don't know if there's a correlation between this file and the number of filters lines, but take into account that I have no free slots for ram modules and I've already reached the maximum amount of supported memory. When physical memory ends, the system allocate a lot of memory in swap partition on the physical disk and the computer slowing down a lot..

(In reply to Alessandro Castellani [:aleca] from comment #65)

Hey Henry, are you able to investigate this?
Most likely there's something sketchy going on with the creation of the search row and the consequential append of that element to the DOM.
https://searchfox.org/comm-central/rev/97df616aa8cdd0eeaa4af84c13994402bb4099d8/mailnews/search/content/searchTerm.js#395-400

I'm not sure if the row element itself with all those child elements (multiple menulsits and logic to show/hide options based on selected elements) is causing the slow down, or is the append itself.

We should also consider loading only an initial subset of filters and then load the rest on scroll.

ok, I can have a look.

As some first thoughts, should we just try and rebuild in html? The current structure is

<richlistbox> <!-- Note, the richlistbox selection is unused and cant be used to skip rows with a keyboard. -->
  <richlistitem>
    <hbox>
      <search-attribute>
        <menulist>
          <menupopup>
            <menuitem>
              <hbox>
                ...
  ...
</richlistbox>

This is far more expensive than we need, which is

<ul>
  <li>
    <select>
      <option>
  ...

I also suspect that the custom element <search-attribute>'s connected callback might be slow https://searchfox.org/comm-central/source/mailnews/search/content/searchWidgets.js#518

If it is still slow, we can also construct the whole list (not just individual rows) as a DocumentFragment and see if that helps.

Flags: needinfo?(henry)

ok, I did some profiling using the filter from comment 10 (615 OR conditions).

filterEditorOnLoad itself takes ~16 seconds.

The first ~12 seconds is spent in initializeSearchRows https://searchfox.org/comm-central/rev/461a63b4e564c1eabccc8dcba538b4cb11307f06/mailnews/search/content/searchTerm.js#193

~1 second to select all the text in #filterName https://searchfox.org/comm-central/rev/461a63b4e564c1eabccc8dcba538b4cb11307f06/mailnews/search/content/FilterEditor.js#199

~3 seconds to focus it https://searchfox.org/comm-central/rev/461a63b4e564c1eabccc8dcba538b4cb11307f06/mailnews/search/content/FilterEditor.js#201

The fact that selecting and focusing take so long suggests to me that the UI is bloated. Once the dialog is opened, resizing it is very laggy.

initializeDialog

Each call to createSearchRow takes ~21ms. Almost all of this is in <search-attribute>'s connectedCallback https://searchfox.org/comm-central/source/mailnews/search/content/searchWidgets.js#518

Doing some digging I found that ~10ms is spent on this line alone https://searchfox.org/comm-central/rev/461a63b4e564c1eabccc8dcba538b4cb11307f06/mailnews/search/content/searchWidgets.js#724-821 . The stack trace is:

chrome://messenger/content/searchWidgets.js 724 connectedCallback
chrome://messenger/content/searchWidgets.js 378 set value/< (call to customElements.upgrade)
chrome://messenger/content/searchWidgets.js 377 set value
chrome://messenger/content/searchWidgets.js 462 refreshList
chrome://messenger/content/searchWidgets.js 653 set parentValue
chrome://messenger/content/searchWidgets.js 372 set value/<
chrome://messenger/content/searchWidgets.js 370 set value
chrome://messenger/content/searchWidgets.js 462 refreshList
chrome://messenger/content/searchWidgets.js 315 set searchScope
chrome://messenger/content/searchTerm.js 72 set searchScope
chrome://messenger/content/searchTerm.js 426 initializeTermFromIndex
chrome://messenger/content/searchTerm.js 420 initializeTermFromId
chrome://messenger/content/searchWidgets.js 520 connectedCallback
chrome://messenger/content/searchTerm.js 402 createSearchRow
chrome://messenger/content/searchTerm.js 196 initializeSearchRows
chrome://messenger/content/FilterEditor.js 403 initializeDialog
chrome://messenger/content/FilterEditor.js 96 filterEditorOnLoad

And about ~3ms is spent here https://searchfox.org/comm-central/rev/461a63b4e564c1eabccc8dcba538b4cb11307f06/mailnews/search/content/searchWidgets.js#1199-1205 (also called from <search-value>'s connectedCallback).

These are the most significant chunks of computation time I could find.

Note that most of this code (the use of custom elements) comes from bug 1534345.

Given all this, I think a switch to using html <select> elements, where possible, would help. And using <select is="custom-select">, rather than <custom-select>, if we still need custom classes.

(In reply to Henry Wilkes [:henry] from comment #68)

Doing some digging I found that ~10ms is spent on this line alone https://searchfox.org/comm-central/rev/461a63b4e564c1eabccc8dcba538b4cb11307f06/mailnews/search/content/searchWidgets.js#724-821 .

Just to expand on this, each condition row has a <search-value> element, which contains 7 xul:menulists and 2 html:inputs children, but only shows up to one at any given time (using hidden on the rest). So with 100 rules, that means there are 700 xul:menulists in the DOM, with most being unused.

So an easy fix to get some speed up might be to only construct one of these children at any given point. And rebuild with each call to showChildAt.

Fantastic analysis, thank you so much!

I think your suggestions and recommendations make sense and we should do them.
This can easily turn into a massive rebuild, so let's split the work with incremental improvements.

So an easy fix to get some speed up might be to only construct one of these children at any given point. And rebuild with each call to showChildAt.

This is definitely the first thing to do as we should already see massive improvements from this change.

Given all this, I think a switch to using html <select> elements, where possible, would help.

This could be the second step.

As final step, I'd be okay with dropping the richlistbox and simplifying the HTML structure, but we need to be careful as I'm not sure we might lose some needed functionalities. That structure looks unnecessarily complicated nonetheless.

Assignee: nobody → henry
Status: NEW → ASSIGNED
Attached image menulist.png

I noticed that these menulists have a strange styling.
Pinging Richard to see if he can tackle this.

Flags: needinfo?(richard.marti)

This is because m-c added in bug 1738084 a shadow on the menus. To show the shadow they added a 4px margin. This interferes now with the themeableDialog.css rules we use to colour the menupopups.

Flags: needinfo?(richard.marti)

(In reply to Henry Wilkes [:henry] from comment #71)

Created attachment 9248078 [details]
Bug 1588155 - Stop creating all possible inputs in <search-value>'s connectedCallback. r=aleca

Instead, we only create the child input as needed.

This gives ~50% decrease in loading time for the case I tested in comment 68. To bring this down even more would require some bigger changes, so I'll revisit this bug later.

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/6bcfde504ba5
Stop creating all possible inputs in <search-value>'s connectedCallback. r=aleca

Regressions: 1782392

Let's close this. Remaining work can be done in on of the see-also bugs.

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Flags: needinfo?(ron-eefje)
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
See Also: → 672835
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: