1657977 - Make test_restore_form_elements.html to pass on Fission

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P3)

Comment 1

[Chris Peterson [:cpeterson]]

Session history blocks our Nightly experiment so tracking session history test failures for Fission Nightly milestone M6b.

Comment 2

[Mirko Brodesser (:mbrodesser-Igalia), offline until 10th of Feb]

./mach mochitest --setpref="fission.sessionHistoryInParent=true" --enable-xorigin-tests --enable-fission dom/html/test/forms/test_restore_form_elements.html yields:

 0:50.63 TEST_START: http://mochi.test:8888/tests/dom/html/test/forms/test_restore_form_elements.html
 0:52.10 GECKO(8010) [Child 8180, Main Thread] WARNING: NS_ENSURE_TRUE(mRequest) failed: file /home/mirko/src/firefox/gecko2/netwerk/base/nsBaseChannel.cpp, line 925
 0:54.05 GECKO(8010) [Parent 8010, Main Thread] WARNING: Not implemented in the parent process!: file /home/mirko/src/firefox/gecko2/docshell/shistory/SessionHistoryEntry.cpp, line 407
 0:54.85 GECKO(8010) [8347, Unnamed thread 7fc974d8b4c0] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /home/mirko/src/firefox/gecko2/xpcom/base/nsTraceRefcnt.cpp, line 202
 0:54.85 GECKO(8010) ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpJJMQHt.mozrunner/runtests_leaks.log
 0:54.85 GECKO(8010) [8347, Unnamed thread 7fc974d8b4c0] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /home/mirko/src/firefox/gecko2/xpcom/base/nsTraceRefcnt.cpp, line 202
 0:54.85 GECKO(8010) [8347, Main Thread] WARNING: XPCOM_MEM_BLOAT_LOG is set, disabling native allocations.: file /home/mirko/src/firefox/gecko2/tools/profiler/core/platform.cpp, line 246
 0:55.77 GECKO(8010) [Child 8233, Main Thread] WARNING: '!topWindow', file /home/mirko/src/firefox/gecko2/dom/html/HTMLIFrameElement.cpp, line 241
 0:56.10 GECKO(8010) Assertion failure: mHistory, at /home/mirko/src/firefox/gecko2/docshell/shistory/ChildSHistory.cpp:180
Initializing stack-fixing for the first stack frame, this may take a while...

Hence, this seems to be a bug in Gecko, not in the test.

fission.sessionHistoryInParent=true is necessary, otherwise the test fails at other places.

Comment 4

[Jens Stutte [:jstutte]]

Hi Neha, this blocks bug 1652554 which is marked M6b. Should we detach it from there?

Comment 5

[Andreas Farre [:farre]]

With the patch for bug 1662410 this crashes at https://searchfox.org/mozilla-central/source/docshell/base/CanonicalBrowsingContext.cpp#428 due to https://searchfox.org/mozilla-central/source/docshell/base/CanonicalBrowsingContext.cpp#412,416 because https://searchfox.org/mozilla-central/source/docshell/shistory/SessionHistoryEntry.cpp#1130-1133

Comment 6

[Mirko Brodesser (:mbrodesser-Igalia), offline until 10th of Feb]

For the record, apparently :peterv has a fix pending for c5.

Comment 7

[Neha Kochar [:neha]]

(In reply to Jens Stutte [:jstutte] (REO for FF 81) from comment #4)

Hi Neha, this blocks bug 1652554 which is marked M6b. Should we detach it from there?

Same as Bug 1657982 Comment 4.

Comment 8

[Neha Kochar [:neha]]

Although the dependency is on the fix of bug 1662410, it really won't take effect with fission until session history pref is enabled with fission (bug fission-history-m6b).

Comment 9

[Peter Van der Beken [:peterv]]

This was fixed and then reenabled as part of bug 1668357 (as part of a disabling patch, just to be confusing).