Closed Bug 1662410 Opened 5 years ago Closed 5 years ago

Remove usage of ChildSHistory::LegacySHistory when session history in the parent is enabled

Categories

(Core :: DOM: Navigation, defect, P2)

Product:
Core
Component:
DOM: Navigation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
82 Branch
Project Flags:
Fission Milestone M6b
Tracking Flags:
Tracking Status
firefox82 --- fixed

People

(Reporter: peterv, Assigned: farre)

References

(Regressed 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: patches pushed)

Attachments

(3 files, 5 obsolete files)

Bug 1662410 - Part 1: Fix usage of ChildSHistory.legacySHistory . r=peterv
47 bytes, text/x-phabricator-request
Details | Review
Bug 1662410 - Part 2: Fix test infrastructure usage of legacySHistory. r=peterv
47 bytes, text/x-phabricator-request
Details | Review
Bug 1662410 - Part 3: Fix tests that use legacySHistory. r=peterv
47 bytes, text/x-phabricator-request
Details | Review
No description provided.
Assignee: nobody → afarre
Blocks: 1662420
Severity: -- → S3
Status: NEW → ASSIGNED
Fission Milestone: --- → M6b
Priority: -- → P2

ChildSHistory.legacySHistory isn't valid for content processes when
session history in the parent is enabled. We try to fix this by either
delegating to the parent by IPC or move the implementation partially
or as a whole to the parent.

All the uses of ChildSHistory::LegacySHistory have been annotated for
easy inspection. If you change those lines, be sure to keep the
annotation.

Attachment #9174672 - Attachment description: Bug 1662410 - Fix ChildSHistory legacy from native calls. r=peterv → Bug 1662410 - Part 1: Fix ChildSHistory legacy from native calls. r=peterv
Attachment #9174861 - Attachment is obsolete: true
Attachment #9174860 - Attachment is obsolete: true
Attachment #9174859 - Attachment is obsolete: true
Attachment #9174862 - Attachment is obsolete: true
Attachment #9174672 - Attachment description: Bug 1662410 - Part 1: Fix ChildSHistory legacy from native calls. r=peterv → Bug 1662410 - Part 1: Fix usage of ChildSHistory.legacySHistory . r=peterv
No longer blocks: 1657979
No longer blocks: 1662420
No longer blocks: 1657983, 1657978
No longer blocks: 1662718
No longer blocks: 1657981, 1657977
Blocks: 1657979
Blocks: 1662420
Blocks: 1657983
Blocks: 1657978
Blocks: 1662718
Blocks: 1657981
Blocks: 1657977

Andreas, should we move the disabling of tests to another bug so this can be closed with the fixes?

Flags: needinfo?(afarre)
Whiteboard: fixes ready to land, test disablement can probably be done separately

Patches not ready to land just yet, because of one remaining orange.

Flags: needinfo?(afarre)
Pushed by afarre@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7502521982a7 Part 1: Fix usage of ChildSHistory.legacySHistory . r=peterv https://hg.mozilla.org/integration/autoland/rev/a11117d72dce Part 2: Fix test infrastructure usage of legacySHistory. r=peterv https://hg.mozilla.org/integration/autoland/rev/22879caaa142 Part 3: Fix tests that use legacySHistory. r=peterv
Regressions: 1665492
Whiteboard: fixes ready to land, test disablement can probably be done separately → patches pushed
Regressions: 1666025
Regressed by: 1665609
Has Regression Range: --- → yes
Attachment #9174864 - Attachment is obsolete: true
Regressions: 1667811
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: