Closed Bug 1658878 Opened 4 years ago Closed 4 years ago

Isolate BlobURLs per agent-cluster

Categories

(Core :: Privacy: Anti-Tracking, task)

task

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: baku, Assigned: baku)

References

(Blocks 1 open bug, Regressed 1 open bug, )

Details

Attachments

(4 files)

BlobURLs can be used as a tracking vector. We want to limit them by agent-cluster.

See: https://github.com/w3c/FileAPI/issues/153

It isn't clear to me why we want this. I have similar questions what mkruisselbrink has.
I'm probably missing something obvious.

Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3609760c1e5d
Isolate BlobURLs per agent-cluster, r=smaug
https://hg.mozilla.org/integration/autoland/rev/a8620aecc29f
Isolate BlobURLs per agent-cluster - tests, r=smaug
https://hg.mozilla.org/integration/autoland/rev/20401a2adaa6
Isolate BlobURLs per agent-cluster - pref, r=smaug
https://hg.mozilla.org/integration/autoland/rev/f69f80e5659f
Isolate BlobURLs per agent-cluster - cleanup remove method, r=smaug
Flags: needinfo?(amarchesini)
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/16a33c7b4ff3
Isolate BlobURLs per agent-cluster, r=smaug
https://hg.mozilla.org/integration/autoland/rev/33c4b81f99a1
Isolate BlobURLs per agent-cluster - tests, r=smaug
https://hg.mozilla.org/integration/autoland/rev/a5af0e097560
Isolate BlobURLs per agent-cluster - pref, r=smaug
https://hg.mozilla.org/integration/autoland/rev/0288ef9ab65b
Isolate BlobURLs per agent-cluster - cleanup remove method, r=smaug

Backed out 4 changesets (bug 1658878) for blob related leaks.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=CTtu_axkQI-F2XHRQ6T3Nw.0&fromchange=0288ef9ab65b6211fd2e96ae6ead9284c41f02fd&tochange=26091ecbe5db8031e056c220ef4e09c12df21209&searchStr=linux%2C18.04%2Cx64%2Cdebug%2Cweb%2Cplatform%2Ctests%2Ctest-linux1804-64%2Fdebug-web-platform-tests-e10s%2Cwpt12

Backout link: https://hg.mozilla.org/integration/autoland/rev/26091ecbe5db8031e056c220ef4e09c12df21209

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313051685&repo=autoland&lineNumber=14827
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313051685&repo=autoland&lineNumber=15759

[task 2020-08-14T19:25:08.129Z] 19:25:08     INFO - TEST-START | /encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-errors-han.html?2001-3000
[task 2020-08-14T19:25:08.130Z] 19:25:08     INFO - Closing window 182
[task 2020-08-14T19:25:08.145Z] 19:25:08     INFO - Got chrome assert count 1
[task 2020-08-14T19:25:08.153Z] 19:25:08     INFO - TEST-UNEXPECTED-FAIL | /html/cross-origin-embedder-policy/blob.https.html | assertion count 1 is more than expected 0 assertions
[task 2020-08-14T19:25:08.154Z] 19:25:08     INFO - ......
[task 2020-08-14T19:25:08.155Z] 19:25:08     INFO - TEST-OK | /html/cross-origin-embedder-policy/blob.https.html | took 1621ms
...
[task 2020-08-14T19:26:27.836Z] 19:26:27     INFO - TEST-INFO | leakcheck | default leaked 2 nsSimpleURI
[task 2020-08-14T19:26:27.836Z] 19:26:27     INFO - TEST-INFO | leakcheck | default leaked 11 nsStandardURL
[task 2020-08-14T19:26:27.836Z] 19:26:27     INFO - TEST-INFO | leakcheck | default leaked 813 nsStringBuffer
[task 2020-08-14T19:26:27.837Z] 19:26:27     INFO - TEST-INFO | leakcheck | default leaked 41 nsTArray_base
[task 2020-08-14T19:26:27.837Z] 19:26:27     INFO - TEST-INFO | leakcheck | default leaked 1 nsThread
[task 2020-08-14T19:26:27.838Z] 19:26:27     INFO - TEST-INFO | leakcheck | default leaked 2 nsVariant
[task 2020-08-14T19:26:27.839Z] 19:26:27     INFO - TEST-UNEXPECTED-FAIL | leakcheck | default 21692 bytes leaked (BackstagePass, BlobURL, BlobURLInputStream, BrowsingContext, BrowsingContextGroup, ...)
[task 2020-08-14T19:26:27.839Z] 19:26:27     INFO - 
[task 2020-08-14T19:26:27.840Z] 19:26:27     INFO - Closing logging queue
Flags: needinfo?(amarchesini)
Flags: needinfo?(amarchesini)
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/da55dec738c5
Isolate BlobURLs per agent-cluster, r=smaug
https://hg.mozilla.org/integration/autoland/rev/703f9a9e5fde
Isolate BlobURLs per agent-cluster - tests, r=smaug
https://hg.mozilla.org/integration/autoland/rev/27d5d028b1af
Isolate BlobURLs per agent-cluster - pref, r=smaug
https://hg.mozilla.org/integration/autoland/rev/626c0384ddb8
Isolate BlobURLs per agent-cluster - cleanup remove method, r=smaug
Regressions: 1661990

:baku, according to mozregression, this seems to have broken the firefox screenshots feature which uses blob URIs for the screenshot/preview, see issue 5438. Do you have any suggestions on what we need to do to fix it?

Flags: needinfo?(amarchesini)

(In reply to Sam Foster [:sfoster] (he/him) from comment #13)

:baku, according to mozregression, this seems to have broken the firefox screenshots feature which uses blob URIs for the screenshot/preview, see issue 5438. Do you have any suggestions on what we need to do to fix it?

I see this is already filed in bugzilla as bug 1660651. The need-info should stand though - any suggestions there appreciated.

We have a separate bug for this regression. Let's move the discussion there.

Flags: needinfo?(amarchesini)
Blocks: 1686111
Regressions: 1692016
Regressions: 1728192
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: