1662420 - Enable "test_bug345339.html" and "test_bug398243.html" for xorigin iframes with Fission

Status: RESOLVED DUPLICATE of bug 1668357

(Core :: DOM: Core & HTML, defect, P3)

Description

[Mirko Brodesser (:mbrodesser-Igalia)]

Running ./mach mochitest --setpref="fission.sessionHistoryInParent=true" --enable-xorigin-tests --enable-fission dom/base/test/test_bug345339.html yields:

 0:49.63 TEST_START: http://mochi.test:8888/tests/dom/base/test/test_bug345339.html
 0:52.68 GECKO(22338) [22669, Unnamed thread 7f727828b4c0] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /home/mirko/src/firefox/gecko2/xpcom/base/nsTraceRefcnt.cpp, line 202
 0:52.68 GECKO(22338) ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpea0_NH.mozrunner/runtests_leaks.log
 0:52.68 GECKO(22338) [22669, Unnamed thread 7f727828b4c0] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /home/mirko/src/firefox/gecko2/xpcom/base/nsTraceRefcnt.cpp, line 202
 0:52.68 GECKO(22338) [22669, Main Thread] WARNING: XPCOM_MEM_BLOAT_LOG is set, disabling native allocations.: file /home/mirko/src/firefox/gecko2/tools/profiler/core/platform.cpp, line 246
 0:52.95 GECKO(22338) [Child 22509, Main Thread] WARNING: NS_ENSURE_TRUE(mRequest) failed: file /home/mirko/src/firefox/gecko2/netwerk/base/nsBaseChannel.cpp, line 925
 0:54.40 GECKO(22338) [Child 22562, Main Thread] WARNING: '!topWindow', file /home/mirko/src/firefox/gecko2/dom/html/HTMLIFrameElement.cpp, line 241
 0:54.84 GECKO(22338) [Parent 22338, Main Thread] WARNING: Not implemented in the parent process!: file /home/mirko/src/firefox/gecko2/docshell/shistory/SessionHistoryEntry.cpp, line 407
 0:55.34 GECKO(22338) Assertion failure: mHistory, at /home/mirko/src/firefox/gecko2/docshell/shistory/ChildSHistory.cpp:180
Initializing stack-fixing for the first stack frame, this may take a while...

The test itself embeds another <iframe>, which it modifies and reloads. IIUC, this shouldn't be affected by xorigin iframes and Fission, so the test itself seems valid. Hence, there seems to be a problem in Gecko which requires further analysis.

Test "test_bug398243.html" does the same (and violates the same assertion), just for different types of elements.

Comment 1

[Neha Kochar [:neha]]

Mirko, try this also with fission.sessionHistoryInParent pref.

Comment 2

[Mirko Brodesser (:mbrodesser-Igalia)]

Neha: with fission.sessionHistoryInParent=true an assertion is violated. I've updated c0.

Comment 3

[Neha Kochar [:neha]]

Thanks, Mirko. This will be fixed in bug 1662410. I've added the dependency here.

Comment 4

[Andreas Farre [:farre]]

Same as Bug 1657977 Comment 5

Comment 5

[Neha Kochar [:neha]]

same fission milestone as Bug 1657977 (similar category of failure).

Comment 6

[Neha Kochar [:neha]]

Although the dependency is on the fix of bug 1662410, it really won't take effect with fission until session history pref is enabled (bug fission-history-m6b).

Comment 7

[Mirko Brodesser (:mbrodesser-Igalia)]

Both tests were already enabled in bug 1668357.