1663935 - Address book: Searching in displayed mailing list directory fails with display artifacts

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect, P2)

Description

[bazinou]

Attachment: After search

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:80.0) Gecko/20100101 Firefox/80.0

Steps to reproduce:

Select a List in the address book, and then type a existing string in the search box.

Actual results:

The email list is not filtered.
And if I drag the mouse over the email list, all fields become blank.

Expected results:

The email list must be filtered, as It does when we search on Address book root or at the root of Personal Adress

Comment 1

[bazinou]

Attachment: Before search

Comment 2

[Thomas D. (:thomas8)]

Confirming exactly as described for 82.0a1 (2020-09-07) (64-bit) and 78.2.1 (64-bit). Couldn't find a dupe.
Odd. Can we fix this fast?

Comment 3

[Alice0775 White]

STR for bisecting:

1. Create mailing list using 68esr with new profile and quit
2. Start a comm-central build with the profile of step1
3. Select a List in the address book, and then type a existing string in the search box

#1 Regression window: Search does not work. i.e nothing happens.
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=e7476e934b191ffac787208323191c9c034049ce&tochange=72b1cec1260e68511a8b99d0e72fd8b0cefd44dc
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3fa65bda1e506a314ea90d936f763c7e840ab98a&tochange=3fa65bda1e506a314ea90d936f763c7e840ab98a

#2 Regression window: Search does not work. i.e nothing happens. And list items(except icon) disappear when mouse over list.
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=ffa711650cb168714e3e6179267ab8656e8d47b5&tochange=a34c59e873c92c1d65c9dd3715d260698083d887
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a34695d9b99d1e9098e846b751c9adf1f52ee760&tochange=a34695d9b99d1e9098e846b751c9adf1f52ee760

Comment 4

[Magnus Melin [:mkmelin]]

Bug 1633620 is in the range so should be from that.

Comment 5

[Geoff Lankow (:darktrojan)]

I knew it was that bug the moment I saw it.

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1663935 - Implement nsIAbDirectory.search in mailing lists. r?mkmelin

This is the same as the implementation in AddrBookDirectory except without the mailing list pieces
(mailing lists don't have mailing lists).

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b168d5981f41
Implement nsIAbDirectory.search in mailing lists. r=mkmelin

Comment 9

[Magnus Melin [:mkmelin]]

Comment on attachment 9174810 [details]
Bug 1663935 - Implement nsIAbDirectory.search in mailing lists. r?mkmelin

[Approval Request Comment]
Regression caused by (bug #): bug 1633620
User impact if declined: can't search within mailing list

Should take this on 78 after some beta testing.

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9174810 [details]
Bug 1663935 - Implement nsIAbDirectory.search in mailing lists. r?mkmelin

[Triage Comment]
Approved for esr78

Comment 13

[Thomas D. (:thomas8)]

Does this need any more flags to land on ESR78?

Comment 15

[Magnus Melin [:mkmelin]]

No.

Comment 16

[Rob Lemley [:rjl]]

Thunderbird 78.2.3:
https://hg.mozilla.org/releases/comm-esr78/rev/e0d24cd283ad