[cocoa] need support for modeOpenMultiple for nsIFilePicker

RESOLVED FIXED

Status

()

Core
XUL
RESOLVED FIXED
16 years ago
15 years ago

People

(Reporter: (not reading, please use seth@sspitzer.org instead), Assigned: Simon Fraser)

Tracking

Trunk
PowerPC
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

12.63 KB, patch
Mike Pinkerton (not reading bugmail)
: review+
Brian Ryner (not reading)
: superreview+
Details | Diff | Splinter Review
[cocoa] need support for modeOpenMultiple for nsIFilePicker

you need to override ::GetFiles()

see http://bugzilla.mozilla.org/show_bug.cgi?id=121122 for the windows impl.
Depends on: 121122

Updated

16 years ago
OS: Windows 2000 → MacOS X
Hardware: PC → Macintosh
-> dagley
Assignee: pinkerton → sdagley

Comment 2

16 years ago
Any rush on a Cocoa version of this?  AFAIK it's a request for mail/news to
allow selection of multiple attachments at once and since we don't have
mail/news in Chimera...
no, but the carbon version might be nice.
how about for opening multiple files within the browser (eg, chimera)?

if that's possible, then each file would open in a separate browser window or
tab, depending on the user's prefs.

Comment 5

15 years ago
Since I don't report into Internet Technologies anymore this bug needs a new
owner -> saari
Assignee: sdagley → saari

Comment 6

15 years ago
pinkerton, might be nice or necessary?
(Assignee)

Comment 7

15 years ago
It's pretty important (and easy).
Assignee: saari → sfraser

Updated

15 years ago
Blocks: 169179
one place this makes a difference to the user is for bug #43015:
"Cannot add multiple attachment in Attach File dialog (mail compose)"
Blocks: 43015
(Assignee)

Comment 9

15 years ago
Created attachment 119340 [details] [diff] [review]
Patch to nsFilePicker.mm/h
(Assignee)

Updated

15 years ago
Attachment #119340 - Flags: superreview?(bryner)
Attachment #119340 - Flags: review?(pinkerton)
(Assignee)

Updated

15 years ago
Status: NEW → ASSIGNED
Attachment #119340 - Flags: superreview?(bryner) → superreview+
(Assignee)

Comment 10

15 years ago
Created attachment 119766 [details] [diff] [review]
Patch addressing comments

Patch addressing comments made in bug 167149.
Attachment #119340 - Attachment is obsolete: true
(Assignee)

Updated

15 years ago
Attachment #119766 - Flags: superreview?(bryner)
Attachment #119766 - Flags: review?(pinkerton)
Attachment #119766 - Flags: superreview?(bryner) → superreview+
Comment on attachment 119766 [details] [diff] [review]
Patch addressing comments

r=pink

+  NSURL *fileURL = [[NSURL alloc] initWithString:[thePanel filename]
relativeToURL:dirURL];

i remember (a year ago) in chimera we had problems with NSURL not being able to
handle certain things and freaking out so we had to abandon its use. Do you
remember why? I don't, nor does conrad, but i remember we couldn't keep using
them. *shrug*
Attachment #119766 - Flags: review?(pinkerton) → review+
(Assignee)

Comment 12

15 years ago
Wasn't it the crashes with very long filenames or file paths? Since, in this
case, the NSURL is coming from the file picker, it should be safe to use directly.
or maybe it was incorrectly formatted urls...either way, you're right, it
shouldn't be a worry here.
(Assignee)

Comment 14

15 years ago
Fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Attachment #119340 - Flags: review?(pinkerton)
You need to log in before you can comment on or make changes to this bug.