1673109 - Re-introduce tests that got lost as part of the ASRouter rearchitecture work

Status: RESOLVED FIXED

(Firefox :: Messaging System, task, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

In bug 1614465, a big refactor occurred with ASRouter, which changes how it initializes, and also changes it's underlying communications infrastructure.

As part of that change, some unit tests from ASRouter.test.js were removed because certain methods were removed. Per this comment from andreio, we should audit the removed tests and reintroduce new ones where it makes sense.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Hey - if it's alright, I'm going to keep this assigned to me - I've already got a patch halfway done that reintroduces a bunch of tests.

Comment 2

[Andrei Oprea [:andreio]]

Thanks! I was confused as to why I couldn't find the bug anymore (I was looking by bugs assigned to me) :)
I came across some unused/dead-code that was accidentally added in (probably an artifact of the numerous rebases) that I was planning to add as a todo to this bug but maybe it should be a separate bug?

Comment 3

[Mike Conley (:mconley) (:⚙️)]

(In reply to Andrei Oprea [:andreio] from comment #2)

Thanks! I was confused as to why I couldn't find the bug anymore (I was looking by bugs assigned to me) :)
I came across some unused/dead-code that was accidentally added in (probably an artifact of the numerous rebases) that I was planning to add as a todo to this bug but maybe it should be a separate bug?

Hi! Yep, that dead code is one of the things my patch removes. I'm still in the midst of adding the tests back, but I'll post what patches I have so far that are ready for review.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1673109 - Make sure we properly enter "snippets preview mode" when using a preview endpoint. r?andreio!

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1673109 - Get rid of unused dismissById function on ASRouterUtils. r?andreio!

Depends on D95791

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1673109 - Make sure ASRouter.updateTargetingParameters returns the correct Trailhead parameter. r?andreio!

Depends on D95792

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1673109 - Remove dead code that calls a non-existing function. r?andreio!

Depends on D95793

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1673109 - Reintroduce tests that got lost as part of the ASRouter rearchitecture work. r?andreio!

Depends on D95794

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1673109 - Remove unused ASRouter.renderWNMessages method. r?emcminn!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/071ed11caa2d
Make sure we properly enter "snippets preview mode" when using a preview endpoint. r=andreio
https://hg.mozilla.org/integration/autoland/rev/9db16fa5d64f
Get rid of unused dismissById function on ASRouterUtils. r=andreio
https://hg.mozilla.org/integration/autoland/rev/2d9cf2b4e8a9
Make sure ASRouter.updateTargetingParameters returns the correct Trailhead parameter. r=andreio
https://hg.mozilla.org/integration/autoland/rev/ec95e0de1ad4
Remove dead code that calls a non-existing function. r=andreio
https://hg.mozilla.org/integration/autoland/rev/a9f96e3afaab
Remove unused ASRouter.renderWNMessages method. r=emcminn
https://hg.mozilla.org/integration/autoland/rev/8b291152d074
Reintroduce tests that got lost as part of the ASRouter rearchitecture work. r=andreio

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/071ed11caa2d
https://hg.mozilla.org/mozilla-central/rev/9db16fa5d64f
https://hg.mozilla.org/mozilla-central/rev/2d9cf2b4e8a9
https://hg.mozilla.org/mozilla-central/rev/ec95e0de1ad4
https://hg.mozilla.org/mozilla-central/rev/a9f96e3afaab
https://hg.mozilla.org/mozilla-central/rev/8b291152d074