Closed Bug 1673402 Opened 1 year ago Closed 1 year ago

Don't show the bookmarks toolbar on the New Tab page if the toolbar will appear empty

Categories

(Firefox :: Toolbars and Customization, defect, P3)

defect

Tracking

()

VERIFIED FIXED
84 Branch
Tracking Status
firefox84 --- verified

People

(Reporter: jaws, Assigned: jaws)

References

Details

Attachments

(1 file)

Bug 727668 will show the bookmarks toolbar when on the New Tab page, but if there are no bookmarks in the Bookmarks Toolbar folder (or customizing the Bookmarks Toolbar Items to a different toolbar) and there are no bookmarks in the Other Bookmarks folder (bug 1664053) and the user either has run Import, customized it away, or upgraded from a previous install and thus doesn't have the button (bug 1665442), then there will be nothing in the toolbar.

The result is making the navigation toolbar a few pixels taller due to internal margins/padding in the bookmarks toolbar. We just shouldn't show it in this case.

Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ddfb6f0d4fc5
Don't show the bookmarks toolbar on the new tab page if there are no contents. r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (84.0a1 Build ID - 20201029095639) installed, on Windows 10 x64, Ubuntu 18.04 x64, and Mac 10.15. Now I can confirm the "Bookmarks Toolbar" is not displayed if is empty and the "Only on New Tab" option is checked.

Status: RESOLVED → VERIFIED

I'm on latest nightly 84.0a1 (2020-10-29) and I still see the bookmarks toolbar when empty (I manually deleted all entries through right-click delete on the bookmarks in there) and set to "Only on New Tab". I did however move the "Bookmark Toolbar Items" out via the mouse drag mechanism, maybe that did confuse something. But the empty bookmark toolbar space is definitely still taking up vertical space for me on any new tab, and it's somewhat visually annoying.

(In reply to Ellie from comment #5)

Can you go to about:config and share the value you have for browser.uiCustomization.state?

Flags: needinfo?(kittens)

browser.uiCustomization.state:

{"placements":{"widget-overflow-fixed-list":["screenshots_mozilla_org-browser-action","_contain-facebook-browser-action","geckoprofiler_mozilla_com-browser-action","user-agent-switcher_ninetailed_ninja-browser-action"],"nav-bar":["back-button","forward-button","stop-reload-button","home-button","customizableui-special-spring1","urlbar-container","customizableui-special-spring2","downloads-button","library-button","abp-toolbarbutton","_75afe46a-7a50-4c6b-b866-c43a1075b071_-browser-action","useragentoverrider-button","_d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d_-browser-action","cors-everywhere_spenibus-browser-action","_27c3c9d8-95cd-44e6-ae9c-ff537348b9f3_-browser-action","ublock0_raymondhill_net-browser-action"],"toolbar-menubar":["menubar-items"],"TabsToolbar":["tabbrowser-tabs","new-tab-button","alltabs-button"],"PersonalToolbar":["managed-bookmarks"]},"seen":["webcompat-reporter-button","pocket-button","developer-button","abp-toolbarbutton","_75afe46a-7a50-4c6b-b866-c43a1075b071_-browser-action","webide-button","screenshots_mozilla_org-browser-action","ublock0_raymondhill_net-browser-action","_d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d_-browser-action","user-agent-switcher_ninetailed_ninja-browser-action","_ed102056-8b4f-43a9-99cd-6d1b25abe87e_-browser-action","cors-everywhere_spenibus-browser-action","feed-button","_27c3c9d8-95cd-44e6-ae9c-ff537348b9f3_-browser-action","_contain-facebook-browser-action","geckoprofiler_mozilla_com-browser-action","profiler-button"],"dirtyAreaCache":["PersonalToolbar","nav-bar","TabsToolbar","toolbar-menubar","PanelUI-contents","addon-bar","widget-overflow-fixed-list"],"currentVersion":16,"newElementCount":10}

Flags: needinfo?(kittens)

Great, thank you. I see you have "managed-bookmarks" in there, and I was wondering if that was the case.

Component: New Tab Page → Toolbars and Customization
Depends on: 1674160

I've filed bug 1674160 and put it in our backlog to get fixed soon. Thanks!

You need to log in before you can comment on or make changes to this bug.