1674135 - Printing via the “Print using the system dialog” option is not working for about pages

Status: VERIFIED FIXED

(Toolkit :: Printing, defect, P2)

Description

[Emil Ghitta, QA [:emilghitta]]

Attachment: printSelectionAboutPages.gif

Affected versions

• Firefox 84.0a1 (BuildId:20201029095639)
• Firefox 83.0b5 (BuildId:20201027175448)

Unaffected versions

• Firefox 82.0.2 (BuildId:20201027185343)

Affected platforms

• Windows 10 64bit
• Ubuntu 20.04 64bit
• macOS 10.15

Steps to reproduce

1. Launch Firefox.
2. Access the about:support page.
3. Select a random text.
4. Hit Ctrl + P in order to open the print preview.
5. Select an actual physical printer from the destination list.
6. Click on the “Print using the system dialog” option.
7. Print.

Expected result

• The print job is successfully initiated and the print selection gets successfully printed.

Actual result

• No print job is initiated and the print preview fails to reopen (via hamburger menu, context Print Selection option or via ctrl + p) until the tab is refreshed.

Regression Range

• This seems to be a regression:
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=600f47bbfeb2b8dd8feb52dc9b0df0c72e01da9e&tochange=049532251e7af69edd01049d853166250c190654
• Possible Regressor: Bug 1662336

Notes

• This seems to affect other about pages as well.
• No error message is being thrown inside the browser console.
• [Suggested Severity] I think that S3 fits for this issue.
• This seems to be reproducible with both Fission enabled and Fission disabled
• This is not reproducible using the old UI
• Tentatively marking this to be tracked for print2020_v84

Comment 1

[Sean Voisen (:svoisen)]

ni? Emilio just as FYI, but putting this as a P2 because I don't think this is a very common workflow.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

So this is not only an issue for print selection, as far as I can tell.

Printing from the system dialog seems mostly working by chance. Bug 1660665 made it so that this call happens after hiding the dialog, which removes the preview <browser>.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1674135 - Don't destroy frames from hideDialog() as we rely on printing hidden frames. r=Gijs

Using visibility preserves frames of the content inside the dialog,
which we rely on to print the preview <browser> element.

This was working before bug 1662336 mostly by chance, because we were
doing an extra clone and that happened to mostly not rely on the cloned
document being rendered.

I'd rather fix it in the front-end (by not trying to print a
display: none <browser>) than going back to do a separate clone,
because that can get expensive (specially with fission).

It's not super-clear to me how to best test the "print from system
dialog" case, but ideas certainly welcome.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7f0c3d87325
Don't destroy frames from hideDialog() as we rely on printing hidden frames. r=Gijs

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57fcc7dd2219
Update test expectations since we changed the overlay inline style.

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset 57fcc7dd2219 (bug 1674135) for browser/components/preferences/ mochitest failures.

Pushes with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=812988%2C812993%2C813011%2C813062%2C813051%2C813049&fromchange=86639f67d5877e1dc3ab0f8ca92f069972a67144&tochange=c2a6b0dbd11fd514ab0b778843e6ca3a1a755861&selectedTaskRun=A_NsBsLeTo2DFT9ftsehrQ.0

Backout links: https://hg.mozilla.org/integration/autoland/rev/a7fff0ad909d18f6ab6ba74f79cc6b9cdd5e232b
https://hg.mozilla.org/integration/autoland/rev/c2a6b0dbd11fd514ab0b778843e6ca3a1a755861

Failures logs: https://treeherder.mozilla.org/logviewer?job_id=320510401&repo=autoland&lineNumber=3097

https://treeherder.mozilla.org/logviewer?job_id=320514044&repo=autoland&lineNumber=2529

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3cc7771c487c
Don't destroy frames from hideDialog() as we rely on printing hidden frames. r=Gijs,preferences-reviewers

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9185117 [details]
Bug 1674135 - Don't destroy frames from hideDialog() as we rely on printing hidden frames. r=Gijs

Beta/Release Uplift Approval Request

• User impact if declined: Printing about: pages from the system dialog with the new print UI fails.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively straight-forward change (mostly test changes) for an 83 regression.
• String changes made/needed: none

Comment 9

[Dorel Luca [:dluca]]

Backed out changeset 3cc7771c487c (bug 1674135) for Browser-chrome failures in preferences/tests/siteData/browser_siteData.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=320604786&repo=autoland

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=XsNSL68hTRmH7FCSL_tGTQ.0&revision=3cc7771c487c0677de4911457040fec5ccfaaa5e

Backout:
https://hg.mozilla.org/integration/autoland/rev/44a0ce7342bd5427444de94d0ca50398344db66f

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Third time's the charm.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5330b68ce05
Don't destroy frames from hideDialog() as we rely on printing hidden frames. r=Gijs,preferences-reviewers

Comment 12

[Razvan Maries]

Backed out for perma failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=b5330b68ce05d2037f14ca49e8554362373cf339&failure_classification_id=2

Log: https://treeherder.mozilla.org/logviewer?job_id=320662738&repo=autoland&lineNumber=4354

Backout: https://hg.mozilla.org/integration/autoland/rev/d9ba3a868d49fee39b14288f0d80262bd5fd8b43

Comment 13

[Pascal Chevrel:pascalc]

Comment on attachment 9185117 [details]
Bug 1674135 - Don't destroy frames from hideDialog() as we rely on printing hidden frames. r=Gijs

The fix was backed out 3 times and we have only one beta left that we build tomorrow, I think this is not ready yet for an uplift to 83, thanks.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9392496ccdc
Don't destroy frames from hideDialog() as we rely on printing hidden frames. r=Gijs,preferences-reviewers

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5cf1aca4c85d
Fix lint failure in siteData/head.js a=lint-fix

Comment 16

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/c9392496ccdc
https://hg.mozilla.org/mozilla-central/rev/5cf1aca4c85d

Comment 17

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 84.0a1 (BuildID:20201109215349) on Windows 10 64bit, macOS 10.14 and Ubuntu 20.04.