1676174 - Dismissing sponsored topsites can change other tiles' positions

Status: NEW

(Firefox :: Top Sites, defect, P3)

Description

[Adrian Florinescu [:aflorinescu] [PTO until Aug 26]]]

[Suggested Severity:]

S3

[Description:]

Toggling pin/unpin context menu on a sponsored topsite would modify other tiles positions. This can be reproduced on a clean profile easily by pinning a topsite with some empty spaces between as shown in the actual result recording , but can be reproduced on frecency rich profile as well.

[Environment:]

Windows 10
83.0b10-trybuild

[Preconditions:]

There are sponsored tiles listed in the topsites.

[Steps:]

1. Download and install RO localized Firefox.
2. Create an user.js and set: browser.topsites.useRemoteSetting = true and browser.search.region to "RO", connecting to the staging main-preview.
3. Start the browser with the predefined profile.
4. Open a new tab.
5. Pick any sponsored topsite and choose to pin it using the menu.

[Actual Result:]

Different pinned tile changes position.
(see screen-cast)

[Expected Result:]

The tiles are reorganized based on the frequency/pinned status only.

Comment 1

[Dão Gottwald [:dao]]

Can you still reproduce this in Nightly with bug 1676185 being fixed?

Comment 2

[Adrian Florinescu [:aflorinescu] [PTO until Aug 26]]]

(In reply to Dão Gottwald [::dao] from comment #1)

Can you still reproduce this in Nightly with bug 1676185 being fixed?

Yes, still reproducible.

Tested with 84.0a1 2020-11-12 / Windows 10 & Ubuntu 18.04.

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 1676174 - WIP

Comment 4

[Maria Heres, inactive, contact Ecosystem QA]

Starting with Firefox 88, the Sponsored Topsites can no longer be pinned (Bug 1682602). However, a similar result as the one described in this issue can be observed using the following scenarios (on Firefox Nightly 88.0a1 Build ID: 20210311093001):

• dismissing a Sponsored top site will move other pinned top sites.
• introducing a new Sponsored top site will move other pinned top sites.
• if a Sponsored top site has been moved or pinned in a version prior to Bug 1682602, unpinning it will reinstate its Sponsored form and move other pinned top sites.

I am leaving this comment as it seems relevant combined with the WIP that has previously been attached to this bug.