Closed Bug 1677126 Opened 5 years ago Closed 4 years ago

Split UrlbarProviderRemoteTabs from UnifiedComplete

Categories

(Firefox :: Address Bar, task, P3)

Product:
Firefox
Component:
Address Bar
Type:
task
Points:
5

Tracking

()

Status:
RESOLVED FIXED
Milestone:
91 Branch
Iteration:
90.2 - May 3 - May 16
Tracking Flags:
Tracking Status
firefox91 --- fixed

People

(Reporter: bugzilla, Assigned: bugzilla)

References

(Blocks 1 open bug)

Details

Attachments

(4 files, 1 obsolete file)

Bug 1677126 - Part 1 - Factor UrlbarProviderRemoteTabs out from UnifiedComplete and PlacesRemoteTabsAutocompleteProvider.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1677126 - Part 3 - Remove PlacesRemoteTabsAutocompleteProvider.jsm and remote tab code in UnifiedComplete.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1677126 - Part 4 - Port remote tab tests and update them to expect result flex.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1677126 - Part 5 - Improve sorting of remote tabs so more recent tabs are more likely to be shown first.
48 bytes, text/x-phabricator-request
Details | Review
No description provided.
Iteration: 85.1 - Nov 16 - Nov 29 → 87.1 - Jan 25 - Feb 7
Iteration: 87.1 - Jan 25 - Feb 7 → 87.2 - Feb 8 - Feb 21
Blocks: 1691162

I'll likely get to this after work on Proton.

Iteration: 87.2 - Feb 8 - Feb 21 → ---

This is its own part since it is a behaviour change. After adding recent tabs, we can add as many stale tabs as we want because the muxer will flex them with other results.

Depends on D114895

Try up to and including Part 3: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a3edfccc61d9102f54f4ae9f6fd8c6c99f210349

Try up to and including Part 4, which contains behaviour changes: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0cd696c6415f1bd4182487815e29e93141bfe556

Iteration: --- → 90.2 - May 3 - May 16
Attachment #9221429 - Attachment description: WIP: Bug 1677126 - Part 1 - Factor UrlbarProviderRemoteTabs out from UnifiedComplete and PlacesRemoteTabsAutocompleteProvider. → Bug 1677126 - Part 1 - Factor UrlbarProviderRemoteTabs out from UnifiedComplete and PlacesRemoteTabsAutocompleteProvider.
Attachment #9221430 - Attachment description: WIP: Bug 1677126 - Part 2 - Remove PlacesRemoteTabsAutocompleteProvider.jsm and remote tab code in UnifiedComplete. → Bug 1677126 - Part 2 - Remove PlacesRemoteTabsAutocompleteProvider.jsm and remote tab code in UnifiedComplete.
Attachment #9221431 - Attachment description: WIP: Bug 1677126 - Part 3 - Port remote tab tests and update them to expect result flex. → Bug 1677126 - Part 3 - Port remote tab tests and update them to expect result flex.
Attachment #9221432 - Attachment description: WIP: Bug 1677126 - Part 4 - Improve sorting of remote tabs so more recent tabs are more likely to be shown first. → Bug 1677126 - Part 4 - Improve sorting of remote tabs so more recent tabs are more likely to be shown first.

Depends on D114893

Attachment #9221430 - Attachment description: Bug 1677126 - Part 2 - Remove PlacesRemoteTabsAutocompleteProvider.jsm and remote tab code in UnifiedComplete. → Bug 1677126 - Part 3 - Remove PlacesRemoteTabsAutocompleteProvider.jsm and remote tab code in UnifiedComplete.
Attachment #9221431 - Attachment description: Bug 1677126 - Part 3 - Port remote tab tests and update them to expect result flex. → Bug 1677126 - Part 4 - Port remote tab tests and update them to expect result flex.
Attachment #9221432 - Attachment description: Bug 1677126 - Part 4 - Improve sorting of remote tabs so more recent tabs are more likely to be shown first. → Bug 1677126 - Part 5 - Improve sorting of remote tabs so more recent tabs are more likely to be shown first.

Try up to and including Part 4, which is now the part that doesn't contain (major) behavioural changes: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c49349ee98c320dbbff3810d5a4e72195e8f0693

Try up to and including Part 5, which changes behaviour: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d9ed9f6f9ab988be21dcf95b8a791271146abff

Attachment #9221432 - Attachment description: Bug 1677126 - Part 5 - Improve sorting of remote tabs so more recent tabs are more likely to be shown first. → WIP: Bug 1677126 - Part 5 - Improve sorting of remote tabs so more recent tabs are more likely to be shown first.
Attachment #9221432 - Attachment description: WIP: Bug 1677126 - Part 5 - Improve sorting of remote tabs so more recent tabs are more likely to be shown first. → Bug 1677126 - Part 5 - Improve sorting of remote tabs so more recent tabs are more likely to be shown first.

Comment on attachment 9221670 [details]
Bug 1677126 - Part 2 - Migrate result buckets pref. r?adw!

Revision D115014 was moved to bug 1662167. Setting attachment 9221670 [details] to obsolete.

Attachment #9221670 - Attachment is obsolete: true
Pushed by htwyford@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eb5fafa391db Part 1 - Factor UrlbarProviderRemoteTabs out from UnifiedComplete and PlacesRemoteTabsAutocompleteProvider. r=adw https://hg.mozilla.org/integration/autoland/rev/fcb5e3ade2ad Part 3 - Remove PlacesRemoteTabsAutocompleteProvider.jsm and remote tab code in UnifiedComplete. r=adw https://hg.mozilla.org/integration/autoland/rev/c8b874d7e637 Part 4 - Port remote tab tests and update them to expect result flex. r=adw https://hg.mozilla.org/integration/autoland/rev/cdcdcbc2e6b0 Part 5 - Improve sorting of remote tabs so more recent tabs are more likely to be shown first. r=adw
Regressions: 1714268
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: