1678629 - Investigate what to do with onItemChanged("keyword")

Status: RESOLVED FIXED

(Toolkit :: Places, task, P3)

Description

[Marco Bonardo [:mak]]

If we remove bookmark keywords, this may not be necessary anymore.

Comment 1

[Marco Bonardo [:mak]]

We're not ready for the removal, and it's unclear if in the future keywords may become nicknames. Thus we'll still have to convert it for now.

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1678629: Implement a mechanism to fire bookmark-keyword-changed event.

Depends on D129603

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1678629: Apply bookmark-keyword-changed event.

Depends on D130439

Comment 4

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1678629: Observe bookmark-guid-changed event to up score.

Depends on D130440

Comment 5

[Phabricator Automation]

Comment on attachment 9249377 [details]
Bug 1678629: Observe bookmark-guid-changed event to up score.

Revision D130441 was moved to bug 1744866. Setting attachment 9249377 [details] to obsolete.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:daisuke, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 7

[Daisuke Akatsuka (:daisuke)]

The patches I posted are dependent on the patch of bug 1678628.
Thus, I will land them after fixing the bug.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb9d2c0fca25
Implement a mechanism to fire bookmark-keyword-changed event. r=mak
https://hg.mozilla.org/integration/autoland/rev/dacbe4a52e44
Apply bookmark-keyword-changed event. r=mak

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/bb9d2c0fca25
https://hg.mozilla.org/mozilla-central/rev/dacbe4a52e44