Closed Bug 1678629 Opened 4 years ago Closed 1 year ago

Investigate what to do with onItemChanged("keyword")

Categories

(Toolkit :: Places, task, P3)

task

Tracking

()

RESOLVED FIXED
111 Branch
Tracking Status
firefox111 --- fixed

People

(Reporter: mak, Assigned: daisuke)

References

Details

Attachments

(2 files, 1 obsolete file)

If we remove bookmark keywords, this may not be necessary anymore.

We're not ready for the removal, and it's unclear if in the future keywords may become nicknames. Thus we'll still have to convert it for now.

Assignee: nobody → daisuke
Status: NEW → ASSIGNED

Depends on D130439

Depends on D130440

Comment on attachment 9249377 [details]
Bug 1678629: Observe bookmark-guid-changed event to up score.

Revision D130441 was moved to bug 1744866. Setting attachment 9249377 [details] to obsolete.

Attachment #9249377 - Attachment is obsolete: true

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:daisuke, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(mak)
Flags: needinfo?(daisuke)

The patches I posted are dependent on the patch of bug 1678628.
Thus, I will land them after fixing the bug.

Depends on: 1678628
Flags: needinfo?(mak)
Flags: needinfo?(daisuke)
Blocks: 1733045
Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bb9d2c0fca25
Implement a mechanism to fire bookmark-keyword-changed event. r=mak
https://hg.mozilla.org/integration/autoland/rev/dacbe4a52e44
Apply bookmark-keyword-changed event. r=mak
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
Blocks: 1816339
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: