Closed Bug 1733045 Opened 3 years ago Closed 1 year ago

Remove nsINavBookmarkObserver

Categories

(Toolkit :: Places, task, P3)

task

Tracking

()

RESOLVED FIXED
112 Branch
Tracking Status
firefox112 --- fixed

People

(Reporter: daisuke, Assigned: daisuke)

References

Details

Attachments

(1 file, 1 obsolete file)

This is a follow-up bug for bug 1678624 especially Marco's comment in https://phabricator.services.mozilla.com/D103148#4110377.
After we replace all event system with new, we should remove nsINavBookmarkObserver.
https://searchfox.org/mozilla-central/rev/79f93e7a8b9aa1903f1349f2dd46fb71596f2ae9/toolkit/components/places/nsINavBookmarksService.idl#17

I think this is part of the changes to replace the old system, thus inverting depends/blocks.

Blocks: 1473530
No longer depends on: 1473530

Also rename test_nsINavBookmarkObserver.js

Severity: -- → S4
Priority: -- → P3
Assignee: nobody → daisuke
Status: NEW → ASSIGNED

Daisuke, could you please mark as dependencies all the bugs that should land before this one can?

Flags: needinfo?(daisuke)

I'm sorry for my delay. I did it.

Flags: needinfo?(daisuke)

The following patch is waiting for review from an inactive reviewer:

ID Title Author Reviewer Status
D131754 Bug 1733045: Remove nsINavBookmarkObserver daisuke mak: Back Aug 21, 2022

:daisuke, could you please find another reviewer or abandon the patch if it is no longer relevant?

For more information, please visit auto_nag documentation.

Flags: needinfo?(daisuke)
Flags: needinfo?(daisuke)
Attachment #9251830 - Attachment description: Bug 1733045: Remove nsINavBookmarkObserver → Bug 1733045: Remove nsINavBookmarkObserver.
Attachment #9316942 - Attachment is obsolete: true
Regressions: 1816821
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
Regressions: 1817094
Blocks: 1818119
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: