Change set to default prompt from an infobar to a modal
Categories
(Firefox :: Messaging System, enhancement, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox89 | --- | fixed |
People
(Reporter: RT, Assigned: Mardak)
References
(Blocks 1 open bug)
Details
(Whiteboard: [proton-modals][proton-onboarding][priority:2a])
User Story
Given poor test results with the current infobar we're having to adjust the set to default dialogue from an infobar to a modal. Acceptance criteria: - Switch behavior to call the modal currently implemented on release and stop showing the infobar for users who don't have Firefox set to default and users who did not disable the "Always perform this check when starting Firefox" checkbox (i.e current modal behavior unchanged) - Refresh UI and copy of the current modal dialogue to match Proton visual design - Ensure that the modal dialogue does not get displayed on the session where existing user onboarding gets displayed (this is bug 1697222) Visual spec is available on Figma (pending copy review) Stretch goal: - add new pinning functionality to it - if done, review copy
Attachments
(1 file)
|
Reporter | |
Updated•4 years ago
|
|
|
Reporter | |
Comment 1•4 years ago
|
||
Emanuela, can you please help us with a visual spec for this modal?
|
|
Reporter | |
Updated•4 years ago
|
|
|
Reporter | |
Updated•4 years ago
|
|
|
Reporter | |
Comment 2•4 years ago
|
||
Alex can you please help validate the requirements in the user story?
|
||
Updated•4 years ago
|
|
|
Reporter | |
Updated•4 years ago
|
|
|
Reporter | |
Updated•4 years ago
|
|
||
Comment 3•4 years ago
|
||
Visual spec is available on Figma (pending copy review)
|
||
Updated•4 years ago
|
|
|
Reporter | |
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
|
||
Comment 4•3 years ago
|
||
To be clear, someone from the User Journey team (andreio, I believe?) will be working on this.
|
Assignee | |
Comment 5•3 years ago
|
||
I think we can make this bug the "graduation" bug where the effect of browser.defaultbrowser.notificationbar (which makes firefox show the default browser infobar instead of the prompt) behave as false when browser.proton.enabled is true.
To be clear, the current behavior of release is already to show the "default browser" prompt and not infobar:
https://searchfox.org/mozilla-central/rev/3de2db87f3c9001ae478318d47a2ca3427574382/browser/app/profile/firefox.js#263-267
So potentially release users could have changed the pref to show the notificationbar, and we can change the logic to ignore notificationbar pref if proton.enabled:
https://searchfox.org/mozilla-central/rev/3de2db87f3c9001ae478318d47a2ca3427574382/browser/components/BrowserGlue.jsm#4578-4583
|
|
Assignee | |
Comment 6•3 years ago
|
||
|
||
Updated•3 years ago
|
Pushed by elee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0daf1f22db6c Change set to default prompt from an infobar to a modal r=andreio
|
||
Comment 8•3 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Updated•3 years ago
|
Description
•