1682117 - Enable PIP mute button / audio toggle in release

Status: RESOLVED FIXED

(Toolkit :: Picture-in-Picture, task, P3)

Description

[Tom S [:evilpie]]

I couldn't find a bug for this. The mute button is enabled on Nightly since over a year: bug 1601761.

Comment 1

[Daniel Bodea [:danibodea]]

According to bug 1601761, since branch 73, the nightly channel has had the PiP's mute button enabled, but neither of the other channels have enabled it as well. I am thinking that maybe it's time to consider enabling it by default in the other channels.

Do you know why it was disabled in the first place? I believe that bug 1665584 is not bad enough to disable the "mute" button altogether.
What do you think?

Thanks!

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Hi danibodea,

I believe it was mainly because of the bug 1665584 issue, but perhaps this can be revisited now. Redirecting to Ania for consideration.

Comment 3

[Ania]

I agree with Daniel, I don't think bug 1665584 is severe enough to warrant disabling the button everywhere.

Molly, how do you feel about enabling the mute/unmute in the release?

A potential safer alternative: enable it only on Youtube, Prime Video, and Netflix only.

Comment 4

[Molly Howell (she/her) (mostly inactive)]

I don't think we even need to limit it to a few sites, let's just go for it.

Comment 5

[Ania]

Thank you, Molly.
Tentatively flagging this for 101 release, but let's decide on Thursday.

Comment 6

[kpatenio]

Attachment: Bug 1682117 - enable PiP mute toggle in release. r=#pip-reviewers!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3002da3f05e
enable PiP mute toggle in release. r=pip-reviewers,mhowell

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d3002da3f05e

Comment 10

[Daniel Bodea [:danibodea]]

The pref media.videocontrols.picture-in-picture.audio-toggle.enabled appears to be true by default in branch 101, but it will be properly verified when 101 reaches the release channel.