1685638 - Change :not(:disabled) to :enabled in CSS files

Status: RESOLVED FIXED

(Toolkit :: Themes, task)

Description

[Tim Nguyen :ntim]

https://searchfox.org/mozilla-central/search?q=%3Anot%28%3Adisabled&path=&case=false&regexp=false

:not(:disabled) -> :enabled
:not(:disabled, X) -> :enabled:not(X)

You should not change test usages in this list.

Comment 1

[Abhishek Sharma[:mick]]

HI Tim,
I work on this bug.

Thanks
Abhishek

Comment 2

[Abhishek Sharma[:mick]]

Attachment: Bug 1685638 - Change :not(:disabled) to :enabled in CSS files.

Depends on D100886

Comment 3

[Abhishek Sharma[:mick]]

Hi Tim,
I submit the patch. I changed in toolkit/components/printing/content/print.css. I have to change :not(:disabled)to :enabled in all folder like
browser/components/extensions/extension.css
browser/components/protections/content/protections.js
devtools/client/application/src/components/ui/UIButton.css
devtools/client/debugger/src/components/shared/Button/styles/CommandBarButton.css
devtools/client/themes/common.css
toolkit/components/printing/content/print.css
toolkit/themes/shared/in-content/common.inc.css

or only in toolkit folder.

Comment 4

[Abhishek Sharma[:mick]]

Can you please review it.

Thanks
Abhishek

Comment 5

[Tim Nguyen :ntim]

(In reply to Abhishek Sharma from comment #3)

Hi Tim,
I submit the patch. I changed in toolkit/components/printing/content/print.css. I have to change :not(:disabled)to :enabled in all folder like
browser/components/extensions/extension.css
browser/components/protections/content/protections.js
devtools/client/application/src/components/ui/UIButton.css
devtools/client/debugger/src/components/shared/Button/styles/CommandBarButton.css
devtools/client/themes/common.css
toolkit/components/printing/content/print.css
toolkit/themes/shared/in-content/common.inc.css

or only in toolkit folder.

All files except test files, so yes, the files you mentioned should be updated.

Comment 6

[Abhishek Sharma[:mick]]

Attachment: "Bug 1685638 - Change :not(:disabled) to :enabled in CSS files r=ntim"

Depends on D101130

Comment 7

[Abhishek Sharma[:mick]]

Hi Tim,
I changed in all the files that you mentioned above. Can you please review it.

Thanks
Abhishek

Comment 8

[Abhishek Sharma[:mick]]

Attachment: "Bug 1685638 - Change :not(:disabled) to :enabled in CSS files in browser/components/extensions/extension.css r=ntim"

Depends on D101268

Comment 9

[Abhishek Sharma[:mick]]

Hi Tim,
I combine three patches in one but it does not show.

Abhishek

Comment 10

[Tim Nguyen :ntim]

The introduction channel on chat.mozilla.org should be able to help you.

Comment 11

[Abhishek Sharma[:mick]]

Attachment: "Bug 1685638 - Change in browser/components/extensions/extension.css r=ntim"

Depends on D101130

Comment 12

[Abhishek Sharma[:mick]]

Hi Tim,
I remove the // and also add :enabled outside . Can you please review it.
I hope this time submit the patch.

Thanks
Abhishek

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9fe2b19d99d2
Change :not(:disabled) to :enabled in CSS files. r=ntim

Comment 14

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/9fe2b19d99d2

Comment 15

[Abhishek Sharma[:mick]]

Hi Tim,
Can u give me other bugs . Its great to work with you. Thanks for helping me in every step and sorry for late work.

Abhishek

Comment 16

[Tim Nguyen :ntim]

(In reply to Abhishek Sharma from comment #15)

Hi Tim,
Can u give me other bugs . Its great to work with you. Thanks for helping me in every step and sorry for late work.

Abhishek

No problem, it's a pleasure to help :)

I don't think I have any more bugs I can suggest on my side. I would suggest checking https://codetribute.mozilla.org/ regarding which topic interests you and choosing a bug from there, or maybe Sylvestre has a bug to suggest?

Comment 17

[Sylvestre Ledru [:Sylvestre]]

Sure, here is a few:
https://bugzilla.mozilla.org/show_bug.cgi?id=1688511
https://bugzilla.mozilla.org/show_bug.cgi?id=1688509
https://bugzilla.mozilla.org/show_bug.cgi?id=1688510