1689998 - Update libpixman to release 0.40.0

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Jonathan Kew [:jfkthame]]

Current cairo requires at least pixman 0.36.0, according to its NEWS file. So in order to update the main cairo sources, we will first need to take a pixman update.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1689998 - Update pixman sources to release 0.40.0. r=jrmuizel

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1689998 - Update pixman sources to release 0.40.0. r=jrmuizel

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1689998 - Mozilla-specific build fixups for pixman 0.40.0. r=jrmuizel

Depends on D103684

Comment 4

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1689998 - Adjust fuzz for an SVG filter reftest. r=jrmuizel

Depends on D103685

Comment 6

[Jonathan Kew [:jfkthame]]

We should be able to take this independently of the intended Cairo update; tryserver seems pretty happy with it. https://treeherder.mozilla.org/jobs?repo=try&revision=f5a33663973216b4896a5a355d4279a56da882e5. (I've just adjusted the patch to account for the feBlend-1.svg failure there.)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07da9c6f39dd
Update pixman sources to release 0.40.0. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/5e707628cd5d
Mozilla-specific build fixups for pixman 0.40.0. r=jrmuizel

Comment 8

[Natalia Csoregi [:nataliaCs]]

Backed out for causing reftest failures on blend-color-dodge.svg

backout: https://hg.mozilla.org/integration/autoland/rev/444011347958243a7b559b5a5645cd2d1d20c574

push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=5e707628cd5d60f6341840542a9b5f2eac9c7aa1&searchStr=reftest&selectedTaskRun=Ws0hnqtiQiiNWZLTedlCxA.0

failure log: https://treeherder.mozilla.org/logviewer?job_id=328579845&repo=autoland&lineNumber=35286

[task 2021-02-02T15:55:46.538Z] 15:55:46 INFO - REFTEST TEST-START | layout/reftests/svg/blend-color-dodge.svg == layout/reftests/svg/blend-color-dodge-ref.svg
[task 2021-02-02T15:55:46.538Z] 15:55:46 INFO - REFTEST TEST-LOAD | file:///Z:/task_1612278958/build/tests/reftest/tests/layout/reftests/svg/blend-color-dodge.svg | 9 / 494 (1%)
[task 2021-02-02T15:55:46.607Z] 15:55:46 INFO - REFTEST TEST-LOAD | file:///Z:/task_1612278958/build/tests/reftest/tests/layout/reftests/svg/blend-color-dodge-ref.svg | 9 / 494 (1%)
[task 2021-02-02T15:55:46.763Z] 15:55:46 INFO - REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/svg/blend-color-dodge.svg == layout/reftests/svg/blend-color-dodge-ref.svg | image comparison, max difference: 1, number of differing pixels: 1600

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/214ffc1253ef
Update pixman sources to release 0.40.0. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/33d60a46b7d0
Mozilla-specific build fixups for pixman 0.40.0. r=jrmuizel

Comment 10

[Natalia Csoregi [:nataliaCs]]

Backed out for linting failure

backout: https://hg.mozilla.org/integration/autoland/rev/533e557b6b109485d8d5b6323f8450fb6274d9d7

push: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=NWmKFegRRKGELeIz8vFv1w.0&searchStr=linting%2Copt%2Candroid%2Cgradle%2Ctests%2Csource-test-mozlint-android-lints%2Clints&revision=33d60a46b7d01a116e91ee8ea64896ce0c353412

failure log: https://treeherder.mozilla.org/logviewer?job_id=328895085&repo=autoland&lineNumber=192

[task 2021-02-04T21:20:26.982Z] mozbuild.frontend.sandbox.SandboxExecutionError: (['/builds/worker/checkouts/gecko/gfx/cairo/libpixman/src/moz.build'], <class 'ValueError'>, ValueError("Path 'None/sources/android/cpufeatures' is not absolute"), <traceback object at 0x7f7a6374c088>)
[task 2021-02-04T21:20:26.982Z] During handling of the above exception, another exception occurred:
[task 2021-02-04T21:20:26.983Z] Traceback (most recent call last):
[task 2021-02-04T21:20:26.983Z] File "/builds/worker/checkouts/gecko/configure.py", line 231, in <module>
[task 2021-02-04T21:20:26.983Z] sys.exit(main(sys.argv))
[task 2021-02-04T21:20:26.984Z] File "/builds/worker/checkouts/gecko/configure.py", line 85, in main
[task 2021-02-04T21:20:26.984Z] return config_status(config)
[task 2021-02-04T21:20:26.984Z] File "/builds/worker/checkouts/gecko/configure.py", line 226, in config_status
[task 2021-02-04T21:20:26.984Z] return config_status(args=[], **sanitized_config)
[task 2021-02-04T21:20:26.985Z] File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/config_status.py", line 174, in config_status
[task 2021-02-04T21:20:26.985Z] definitions = list(definitions)
[task 2021-02-04T21:20:26.985Z] File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/emitter.py", line 168, in emit
[task 2021-02-04T21:20:26.985Z] for out in output:
[task 2021-02-04T21:20:26.985Z] File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/reader.py", line 924, in read_topsrcdir
[task 2021-02-04T21:20:26.985Z] for r in self.read_mozbuild(path, self.config):
[task 2021-02-04T21:20:26.986Z] File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/reader.py", line 1102, in read_mozbuild
[task 2021-02-04T21:20:26.986Z] raise bre
[task 2021-02-04T21:20:26.986Z] File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/reader.py", line 1097, in read_mozbuild
[task 2021-02-04T21:20:26.987Z] path, config, descend=descend, metadata=metadata
[task 2021-02-04T21:20:26.987Z] File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/reader.py", line 1261, in _read_mozbuild
[task 2021-02-04T21:20:26.987Z] child_path, context.config, metadata=child_metadata
[task 2021-02-04T21:20:26.987Z] File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/reader.py", line 1102, in read_mozbuild
[task 2021-02-04T21:20:26.987Z] raise bre
[task 2021-02-04T21:20:26.987Z] File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/reader.py", line 1097, in read_mozbuild
[task 2021-02-04T21:20:26.987Z] path, config, descend=descend, metadata=metadata
[task 2021-02-04T21:20:26.988Z] File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/reader.py", line 1261, in _read_mozbuild
[task 2021-02-04T21:20:26.988Z] child_path, context.config, metadata=child_metadata
[task 2021-02-04T21:20:26.988Z] File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/reader.py", line 1102, in read_mozbuild
[task 2021-02-04T21:20:26.988Z] raise bre
[task 2021-02-04T21:20:26.988Z] File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/reader.py", line 1097, in read_mozbuild
[task 2021-02-04T21:20:26.988Z] path, config, descend=descend, metadata=metadata
[task 2021-02-04T21:20:26.988Z] File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/reader.py", line 1261, in _read_mozbuild
[task 2021-02-04T21:20:26.988Z] child_path, context.config, metadata=child_metadata
[task 2021-02-04T21:20:26.989Z] File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/reader.py", line 1111, in read_mozbuild
[task 2021-02-04T21:20:26.989Z] list(self._execution_stack), sys.exc_info()[2], sandbox_exec_error=se
[task 2021-02-04T21:20:26.989Z] mozbuild.frontend.reader.BuildReaderError:
[task 2021-02-04T21:20:26.989Z] ==============================
[task 2021-02-04T21:20:26.989Z] FATAL ERROR PROCESSING MOZBUILD FILE
[task 2021-02-04T21:20:26.989Z] ==============================
[task 2021-02-04T21:20:26.989Z] The error occurred while processing the following file:
[task 2021-02-04T21:20:26.990Z] /builds/worker/checkouts/gecko/gfx/cairo/libpixman/src/moz.build
[task 2021-02-04T21:20:26.990Z] The error was triggered on line 75 of this file:
[task 2021-02-04T21:20:26.990Z] '%%%s/sources/android/cpufeatures' % CONFIG['ANDROID_NDK']
[task 2021-02-04T21:20:26.990Z] An error was encountered as part of executing the file itself. The error appears to be the fault of the script.
[task 2021-02-04T21:20:26.990Z] The error as reported by Python is:
[task 2021-02-04T21:20:26.990Z] ["ValueError: Path 'None/sources/android/cpufeatures' is not absolute\n"]
[task 2021-02-04T21:20:27.155Z] Config object not found by mach.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7cae824e0d3
Update pixman sources to release 0.40.0. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/a308c54e0acb
Mozilla-specific build fixups for pixman 0.40.0. r=jrmuizel

Comment 12

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/f7cae824e0d3
https://hg.mozilla.org/mozilla-central/rev/a308c54e0acb