169002 - "save to disk" for ftp downloads fail

Status: VERIFIED FIXED

(Core Graveyard :: File Handling, defect)

Description

[sairuh (rarely reading bugmail)]

thanks to chris for pointing this out to me. found using 2002.09.16.08 trunk
comm bits on win2k, linux rh7.2 and mac os x 10.1.5. when doing "save to disk"
for an ftp link, the temp file is created but download progress never completes
--it never gets named/moved to the proper name/location.

dougt, could this be due to your recent checkins?

1. go to an ftp listing, eg, ftp://ftp.mozilla.org/pub/mozilla/nightly/latest/
2. click on a link.
3. when the help app ("downloading") dialog appears, make sure "save to disk" is
selected (change if needed).
4. click OK, and choose d/l location, then click Save.

results: if the d/l mgr appears (default on win2k and linux): the progress meter
never paints. if progress dlg appears (default on mac), the progress meter never
paints. on all platforms, the temp file maintains its salted name and isn't
moved properly.

what does work:

* context-clicking and selecting "save link target"
* clicking and saving http links
* save page as (and accel-S)

Comment 1

[sairuh (rarely reading bugmail)]

this was working with the 9/9 builds... narrowing down.

Comment 2

[Doug Turner (:dougt)]

this wfm in a window2k debug build updated last night.

possible related FTP problem - 168948.

Comment 3

[sairuh (rarely reading bugmail)]

looking at linux comm trunk builds, this regressed btwn 2002.0.13.09 (works
fine) and 2002.09.14.04 (broken).

Comment 4

[Doug Turner (:dougt)]

hmm.

bonsai says:

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=9%2F13%2F2002+00%3A00%3A00&maxdate=9%2F14%2F2002+24%3A00%3A00&cvsroot=%2Fcvsroot

Maybe it was neeti's checkin for bug: 141451.  does backing out this file:

mozilla/ netwerk/ protocol/ ftp/ src/ nsFtpConnectionThread.cpp
to version 1.246 help?

Comment 5

[Doug Turner (:dougt)]

*** Bug 168948 has been marked as a duplicate of this bug. ***

Comment 6

[neeti]

I can reproduce the problem an debug win2k build from 9/16. By backing out the
changes for bug 141451, this problem goes away. Attaching the ftp logs before
and after the patch. 

Comment 7

[neeti]

Attachment: ftp log without patch for bug 141451

Comment 8

[neeti]

Attachment: ftp log with patch for bug 141451

Comment 9

[Doug Turner (:dougt)]

lets back out 141451 until we can figure out why this regressed.

Comment 10

[neeti]

backed out changes to bug 141451

Comment 11

[Pratik]

*** Bug 169142 has been marked as a duplicate of this bug. ***

Comment 12

[sairuh (rarely reading bugmail)]

thanks, neeti.

vrfy'd fixed with 2002.09.18 comm trunk builds.

Comment 13

[Boris 'pi' Piwinger]

*** Bug 169437 has been marked as a duplicate of this bug. ***

Comment 14

[Adam Hauner]

*** Bug 169609 has been marked as a duplicate of this bug. ***

Comment 15

[Daniel Wang]

*** Bug 160292 has been marked as a duplicate of this bug. ***