Closed Bug 169002 Opened 23 years ago Closed 23 years ago

"save to disk" for ftp downloads fail

Categories

(Core Graveyard :: File Handling, defect)

defect
Not set
critical

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: bugzilla, Assigned: neeti)

References

()

Details

(Keywords: regression)

Attachments

(2 files)

thanks to chris for pointing this out to me. found using 2002.09.16.08 trunk comm bits on win2k, linux rh7.2 and mac os x 10.1.5. when doing "save to disk" for an ftp link, the temp file is created but download progress never completes --it never gets named/moved to the proper name/location. dougt, could this be due to your recent checkins? 1. go to an ftp listing, eg, ftp://ftp.mozilla.org/pub/mozilla/nightly/latest/ 2. click on a link. 3. when the help app ("downloading") dialog appears, make sure "save to disk" is selected (change if needed). 4. click OK, and choose d/l location, then click Save. results: if the d/l mgr appears (default on win2k and linux): the progress meter never paints. if progress dlg appears (default on mac), the progress meter never paints. on all platforms, the temp file maintains its salted name and isn't moved properly. what does work: * context-clicking and selecting "save link target" * clicking and saving http links * save page as (and accel-S)
Keywords: nsbeta1
this was working with the 9/9 builds... narrowing down.
Keywords: regression
this wfm in a window2k debug build updated last night. possible related FTP problem - 168948.
looking at linux comm trunk builds, this regressed btwn 2002.0.13.09 (works fine) and 2002.09.14.04 (broken).
hmm. bonsai says: http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=9%2F13%2F2002+00%3A00%3A00&maxdate=9%2F14%2F2002+24%3A00%3A00&cvsroot=%2Fcvsroot Maybe it was neeti's checkin for bug: 141451. does backing out this file: mozilla/ netwerk/ protocol/ ftp/ src/ nsFtpConnectionThread.cpp to version 1.246 help?
*** Bug 168948 has been marked as a duplicate of this bug. ***
I can reproduce the problem an debug win2k build from 9/16. By backing out the changes for bug 141451, this problem goes away. Attaching the ftp logs before and after the patch.
Assignee: law → neeti
lets back out 141451 until we can figure out why this regressed.
backed out changes to bug 141451
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
*** Bug 169142 has been marked as a duplicate of this bug. ***
thanks, neeti. vrfy'd fixed with 2002.09.18 comm trunk builds.
Status: RESOLVED → VERIFIED
*** Bug 169437 has been marked as a duplicate of this bug. ***
*** Bug 169609 has been marked as a duplicate of this bug. ***
*** Bug 160292 has been marked as a duplicate of this bug. ***
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: