Closed Bug 1691579 Opened 3 years ago Closed 3 years ago

Fix and re-enable devtools/client/shared/test/browser_spectrum.js test for Fission

Categories

(DevTools :: General, task)

task

Tracking

(Fission Milestone:M7a, firefox89 fixed)

RESOLVED FIXED
89 Branch
Fission Milestone M7a
Tracking Status
firefox89 --- fixed

People

(Reporter: cpeterson, Assigned: nchevobbe)

References

(Blocks 2 open bugs)

Details

(Whiteboard: dt-fission-m3-mvp)

Attachments

(1 file)

This test was disabled for Fission in bug 1568035, but it was already disabled for intermittent --verify failures in bug 1478156.

Does re-enabling this test need to block shipping Fission MVP?

https://searchfox.org/mozilla-central/rev/7067bbd8194f4346ec59d77c33cd88f06763e090/devtools/client/shared/test/browser.ini#203-206

[browser_spectrum.js]
skip-if =
  verify  # Bug 1478156 test verify fails on master
  fission && debug  # Fails intermittently.
Component: Inspector → General
Whiteboard: dt-fission-triage → dt-fission-m3-triage
Whiteboard: dt-fission-m3-triage → dt-fission-m3-mvp

Tracking DevTools test bugs for Fission M8 (blocking Release experiment).

Fission Milestone: ? → M8

Tracking DevTools Post-M8 bugs for Fission MVP milestone. They don't block the Fission Release channel experiment, but we would like them to be completed before we roll out Fission by default.

Fission Milestone: M8 → MVP
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED

The test failure doesn't seem to have anything to do with Fission,
but this might have introduce some changes in timings that would
trigger a race condition somehow.
The test was failing because in one of the test we were moving a slider
to change a color, while the slider element had a height of 0, which
would interfere with the computations that are done later.
Waiting for a tick before running the tests so the container is properly
rendered seems to do the trick.

Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5c8e536a9b11
[devtools] Enable browser_spectrum.js on Fission. r=jdescottes.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Fission Milestone: MVP → M7a
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: