1691579 - Fix and re-enable devtools/client/shared/test/browser_spectrum.js test for Fission

Status: RESOLVED FIXED

(DevTools :: General, task)

Description

[Chris Peterson [:cpeterson]]

This test was disabled for Fission in bug 1568035, but it was already disabled for intermittent --verify failures in bug 1478156.

Does re-enabling this test need to block shipping Fission MVP?

https://searchfox.org/mozilla-central/rev/7067bbd8194f4346ec59d77c33cd88f06763e090/devtools/client/shared/test/browser.ini#203-206

[browser_spectrum.js]
skip-if =
  verify  # Bug 1478156 test verify fails on master
  fission && debug  # Fails intermittently.

Comment 1

[Chris Peterson [:cpeterson]]

Tracking DevTools test bugs for Fission M8 (blocking Release experiment).

Comment 2

[Chris Peterson [:cpeterson]]

Tracking DevTools Post-M8 bugs for Fission MVP milestone. They don't block the Fission Release channel experiment, but we would like them to be completed before we roll out Fission by default.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1691579 - [devtools] Enable browser_spectrum.js on Fission. r=jdescottes.

The test failure doesn't seem to have anything to do with Fission,
but this might have introduce some changes in timings that would
trigger a race condition somehow.
The test was failing because in one of the test we were moving a slider
to change a color, while the slider element had a height of 0, which
would interfere with the computations that are done later.
Waiting for a tick before running the tests so the container is properly
rendered seems to do the trick.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c8e536a9b11
[devtools] Enable browser_spectrum.js on Fission. r=jdescottes.

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/5c8e536a9b11