1691586 - Fix and re-enable dom/tests/browser/browser_ConsoleStorageAPITests.js test for Fission

Status: RESOLVED FIXED

(DevTools :: General, task, P3)

Description

[Chris Peterson [:cpeterson]]

This test was disabled for Fission in bug 1566182. This test was disabled for Linux ASan in bug 1614436.

https://searchfox.org/mozilla-central/rev/7067bbd8194f4346ec59d77c33cd88f06763e090/dom/tests/browser/browser.ini#51-52

[browser_ConsoleStorageAPITests.js]
skip-if = fission || (asan && os == "linux") # Bug 1614436

Comment 1

[Chris Peterson [:cpeterson]]

Tracking DevTools test bugs for Fission M8 (blocking Release experiment).

Comment 2

[Chris Peterson [:cpeterson]]

Tracking DevTools Post-M8 bugs for Fission MVP milestone. They don't block the Fission Release channel experiment, but we would like them to be completed before we roll out Fission by default.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1691586 - [devtools] Enable browser_ConsoleStorageAPITests.js on fission. r=bomsy

The test was doing a navigation from about:blank to an example.com URL in a
ContentTask, which I guess was going bad with fission enabled since we were
creating a new content process.
I don't think there was a good reason to do that, so we start the test directly
with the "final" URL.
And since about:blank page can be special, we use a data url instead.
A few info calls are added to have better logs, and the test is slightly refactored
to be easier to follow.

Finally, the test was a bit loose, only checking the number of events we were
receiving. We take this opportunity to really check that we get the events that
are expected.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aef5baafb946
[devtools] Enable browser_ConsoleStorageAPITests.js on fission. r=bomsy

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/aef5baafb946