Closed Bug 1691611 Opened 3 years ago Closed 3 years ago

Fix and re-enable devtools/client/inspector/test/browser_inspector_fission_frame_navigation.js test for Fission

Categories

(DevTools :: Inspector, defect, P2)

defect

Tracking

(Fission Milestone:M8, firefox91 fixed)

RESOLVED FIXED
91 Branch
Fission Milestone M8
Tracking Status
firefox91 --- fixed

People

(Reporter: cpeterson, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

(Whiteboard: dt-fission-m3-mvp)

Attachments

(1 file)

This test was disabled for Fission in bug 1566182.

https://searchfox.org/mozilla-central/rev/7067bbd8194f4346ec59d77c33cd88f06763e090/devtools/client/inspector/test/browser.ini#78

[browser_inspector_fission_frame_navigation.js]
skip-if = fission && (bits == 64 && (os == "win" || os == "linux")) # Bug 1665482
Whiteboard: dt-fission-triage → dt-fission-m3-triage
Whiteboard: dt-fission-m3-triage → dt-fission-m3-mvp

Tracking DevTools test bugs for Fission M8 (blocking Release experiment).

Fission Milestone: ? → M8

(In reply to Chris Peterson [:cpeterson] from comment #0)

This test was disabled for Fission in bug 1566182.

Small correction, this was disabled by sheriffs in Bug 1665482. Effectively disabled on all fission platforms. As it is a fission test, I will assign P2 here, it should be re-enabled for fission sooner rather than later.

Severity: -- → S3
Priority: -- → P2

Tracking DevTools Post-M8 bugs for Fission MVP milestone. They don't block the Fission Release channel experiment, but we would like them to be completed before we roll out Fission by default.

Fission Milestone: M8 → MVP
No longer blocks: fission-tests

While we don't emit DOCUMENT_EVENT's for in-process iframes, each new target
will generate DOCUMENT_EVENT for the target's top level document.
So that the frontend do receive DOCUMENT_EVENT's for the remote iframes, in addition to the top level target document.

In most cases, we listen to will-navigate only to watch the top most top level document
and only this one, so we should only consider the top level target's DOCUMENT_EVENT.

As a side effect, we can re-enable browser_inspector_fission_frame_navigation.js which was failing because of this.

Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Fission Milestone: MVP → M8
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2debeb242740
[devtools] Ignore will-navigate events for remote iframe targets. r=jdescottes
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: