1691611 - Fix and re-enable devtools/client/inspector/test/browser_inspector_fission_frame_navigation.js test for Fission

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P2)

Description

[Chris Peterson [:cpeterson]]

This test was disabled for Fission in bug 1566182.

https://searchfox.org/mozilla-central/rev/7067bbd8194f4346ec59d77c33cd88f06763e090/devtools/client/inspector/test/browser.ini#78

[browser_inspector_fission_frame_navigation.js]
skip-if = fission && (bits == 64 && (os == "win" || os == "linux")) # Bug 1665482

Comment 1

[Chris Peterson [:cpeterson]]

Tracking DevTools test bugs for Fission M8 (blocking Release experiment).

Comment 2

[Julian Descottes [:jdescottes]]

(In reply to Chris Peterson [:cpeterson] from comment #0)

This test was disabled for Fission in bug 1566182.

Small correction, this was disabled by sheriffs in Bug 1665482. Effectively disabled on all fission platforms. As it is a fission test, I will assign P2 here, it should be re-enabled for fission sooner rather than later.

Comment 3

[Chris Peterson [:cpeterson]]

Tracking DevTools Post-M8 bugs for Fission MVP milestone. They don't block the Fission Release channel experiment, but we would like them to be completed before we roll out Fission by default.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1691611 - [devtools] Ignore will-navigate events for remote iframe targets.

While we don't emit DOCUMENT_EVENT's for in-process iframes, each new target
will generate DOCUMENT_EVENT for the target's top level document.
So that the frontend do receive DOCUMENT_EVENT's for the remote iframes, in addition to the top level target document.

In most cases, we listen to will-navigate only to watch the top most top level document
and only this one, so we should only consider the top level target's DOCUMENT_EVENT.

As a side effect, we can re-enable browser_inspector_fission_frame_navigation.js which was failing because of this.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2debeb242740
[devtools] Ignore will-navigate events for remote iframe targets. r=jdescottes

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2debeb242740