1692476 - Perma Linux/Windows opt devtools/client/webconsole/test/browser/browser_console_webconsole_private_browsing.js | Test timed out - when Gecko 87 merges to Beta on 2021-02-22

Status: VERIFIED FIXED

(DevTools :: Console, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

• central-as-beta simulation
• How to run these simulations
• Failure log

[task 2021-02-12T12:17:56.400Z] 12:17:56 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_console_webconsole_private_browsing.js | no exception displayed -
[task 2021-02-12T12:17:56.400Z] 12:17:56 INFO - Matched a message with text: "This is not a private message", all messages received.
[task 2021-02-12T12:17:56.404Z] 12:17:56 INFO - Console message: [JavaScript Error: "ReferenceError: privateException is not defined" {file: "data:text/html;charset=utf8,Test console in private windows <script> function logMessages() { /* Wrap the exception so we don't throw in ContentTask. / setTimeout(() => { console.log("This is a private message"); privateException(); }, 10); } </script>" line: 1}]
[task 2021-02-12T12:17:56.405Z] 12:17:56 INFO - logMessages/<@data:text/html;charset=utf8,Test console in private windows <script> function logMessages() { / Wrap the exception so we don't throw in ContentTask. / setTimeout(() => { console.log("This is a private message"); privateException(); }, 10); } </script>:1:174
[task 2021-02-12T12:17:56.405Z] 12:17:56 INFO - setTimeout handlerlogMessages@data:text/html;charset=utf8,Test console in private windows <script> function logMessages() { /* Wrap the exception so we don't throw in ContentTask. / setTimeout(() => { console.log("This is a private message"); privateException(); }, 10); } </script>:1:109
[task 2021-02-12T12:17:56.405Z] 12:17:56 INFO - @chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/browser_console_webconsole_private_browsing.js:130:32
[task 2021-02-12T12:17:56.406Z] 12:17:56 INFO - execute@resource://specialpowers/SpecialPowersSandbox.jsm:141:12
[task 2021-02-12T12:17:56.407Z] 12:17:56 INFO - _spawnTask@resource://specialpowers/SpecialPowersChild.jsm:1611:15
[task 2021-02-12T12:17:56.407Z] 12:17:56 INFO - receiveMessage@resource://specialpowers/SpecialPowersChild.jsm:310:21
[task 2021-02-12T12:17:56.407Z] 12:17:56 INFO - JSActor queryreceiveMessage@resource://specialpowers/SpecialPowersParent.jsm:1236:12
[task 2021-02-12T12:17:56.407Z] 12:17:56 INFO - JSActor queryspawn@resource://specialpowers/SpecialPowersChild.jsm:1543:17
[task 2021-02-12T12:17:56.407Z] 12:17:56 INFO - logPrivateMessages@chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/browser_console_webconsole_private_browsing.js:129:17
[task 2021-02-12T12:17:56.407Z] 12:17:56 INFO - @chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/browser_console_webconsole_private_browsing.js:101:21
[task 2021-02-12T12:17:56.408Z] 12:17:56 INFO - AsyncTester_execTest/<@chrome://mochikit/content/browser-test.js:1088:34
[task 2021-02-12T12:17:56.408Z] 12:17:56 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1128:11
[task 2021-02-12T12:17:56.408Z] 12:17:56 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:948:14
[task 2021-02-12T12:17:56.408Z] 12:17:56 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1037:23
[task 2021-02-12T12:17:56.409Z] 12:17:56 INFO -
[task 2021-02-12T12:17:56.410Z] 12:17:56 INFO - Matched a message with text: "This is a private message", all messages received.
[task 2021-02-12T12:17:56.411Z] 12:17:56 INFO - Buffered messages finished
[task 2021-02-12T12:17:56.415Z] 12:17:56 INFO - TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/browser/browser_console_webconsole_private_browsing.js | Test timed out -

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

From bug 1689297 or bug 1642599?

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Caused by Bug 1642599

While fixing this, it revealed an issue in the test as well as in the browser console code when fission is enabled. I'll provide a patch soon

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1692476 - [devtools] Fix browser_console_webconsole_private_browsing.js permafail on beta. r=ochameau.

The test is failing on beta because there devtools.browsertoolbox.fission is
set to false, so we are getting content error messages from the process target,
and we excluded all private messages for process targets, whereas we only
want to exclude cached private messages.

As I tried to modify the test to run it with and without devtools.browsertoolbox.fission,
this revealed another issue when the pref is true; since we directly get the messages
from the frame target, we don't exclude cached private messages.
We don't handle this here directly, but in Bug 1692838, so we don't leave the
test failing on beta for too long.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1760b5f88041
[devtools] Fix browser_console_webconsole_private_browsing.js permafail on beta. r=ochameau.

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/1760b5f88041

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed in today's central-as-beta simulation.