1692522 - Bring back the keyboard shortcut on the first item in Recently Closed Tabs/Windows subviews

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P2)

Description

[Dão Gottwald [:dao]]

See bug 1689378 comment 5.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

I chatted about this with UX and Content Design. What we're going to do is add a tooltip to the Recently Closed Tabs panel header, with the text "Undo close tab: <shortcut>", and similarly add one to the Recently Closed Windows panel header with "Undo close window: <shortcut>".

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1689378

Comment 3

[:Gijs (he/him)]

Does this need to track 87 given it'll take strings to do what's suggested in comment #1? Alternatively, should we back out 1689378 once 87 merges to beta?

Comment 4

[Dão Gottwald [:dao]]

(In reply to Mike Conley (:mconley) (:⚙️) (Catching up on needinfos) from comment #1)

I chatted about this with UX and Content Design. What we're going to do is add a tooltip to the Recently Closed Tabs panel header, with the text "Undo close tab: <shortcut>", and similarly add one to the Recently Closed Windows panel header with "Undo close window: <shortcut>".

The header is visibly not interactive. Why would people hover over it and wait for a tooltip to appear?

Comment 5

[Mike Conley (:mconley) (:⚙️)]

We're quickly approaching soft freeze and uplift. I'm going to propose we land a patch that puts the shortcut back on the top menuitem (for now) so that we're not rushed on a decision here. No guarantees that it won't hit the cutting room floor when Proton rolls out, though.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1692522 - Temporarily re-introduce keyboard shortcut display in Recently Closed Win/Tab submenu. r?emalysz!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31dd766167ab
Temporarily re-introduce keyboard shortcut display in Recently Closed Win/Tab submenu. r=emalysz

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Changing the priority to p2 as the bug is tracked by a release manager for the current nightly.
See What Do You Triage for more information

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/31dd766167ab

Comment 10

[Alin Ilea, Desktop QA]

Verified - Fixed in latest Nightly 88.0a1 (build id: 20210315214853) and Beta 87.0b8, both with proton pref on and off, using Windows 10 and Ubuntu 18.04.