Closed Bug 1692522 Opened 7 months ago Closed 7 months ago

Bring back the keyboard shortcut on the first item in Recently Closed Tabs/Windows subviews

Categories

(Firefox :: Menus, defect, P2)

defect

Tracking

()

VERIFIED FIXED
87 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox85 --- unaffected
firefox86 --- unaffected
firefox87 + verified

People

(Reporter: dao, Assigned: mconley)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: parity-chrome, regression, Whiteboard: [proton-hamburger-menu])

Attachments

(1 file)

I chatted about this with UX and Content Design. What we're going to do is add a tooltip to the Recently Closed Tabs panel header, with the text "Undo close tab: <shortcut>", and similarly add one to the Recently Closed Windows panel header with "Undo close window: <shortcut>".

Set release status flags based on info from the regressing bug 1689378

Severity: -- → S3
Priority: -- → P3

Does this need to track 87 given it'll take strings to do what's suggested in comment #1? Alternatively, should we back out 1689378 once 87 merges to beta?

Flags: needinfo?(mconley)

(In reply to Mike Conley (:mconley) (:⚙️) (Catching up on needinfos) from comment #1)

I chatted about this with UX and Content Design. What we're going to do is add a tooltip to the Recently Closed Tabs panel header, with the text "Undo close tab: <shortcut>", and similarly add one to the Recently Closed Windows panel header with "Undo close window: <shortcut>".

The header is visibly not interactive. Why would people hover over it and wait for a tooltip to appear?

We're quickly approaching soft freeze and uplift. I'm going to propose we land a patch that puts the shortcut back on the top menuitem (for now) so that we're not rushed on a decision here. No guarantees that it won't hit the cutting room floor when Proton rolls out, though.

Flags: needinfo?(mconley)
Assignee: nobody → mconley
Status: NEW → ASSIGNED
Blocks: 1693098
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/31dd766167ab
Temporarily re-introduce keyboard shortcut display in Recently Closed Win/Tab submenu. r=emalysz

Changing the priority to p2 as the bug is tracked by a release manager for the current nightly.
See What Do You Triage for more information

Priority: P3 → P2
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
Summary: Bring back the keyboard shortcut on the first item in Recently Closed Tabs/Winows subviews → Bring back the keyboard shortcut on the first item in Recently Closed Tabs/Windows subviews

Verified - Fixed in latest Nightly 88.0a1 (build id: 20210315214853) and Beta 87.0b8, both with proton pref on and off, using Windows 10 and Ubuntu 18.04.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.