1868452 - Error: Key key_undoCloseTab of menuitem [title of closed tab here] could not be found

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect, P2)

Description

[Rob Wu [:robwu]]

STR:

1. Open a tab, e.g. example.com
2. Close that tab
3. Click on the History > Recently Closed Tabs menu.
4. Look at the global Browser Console.

Expected:

• No error messages

Actual:

• "Key key_undoCloseTab of menuitem [title of closed tab here] could not be found menu.js:295:21"
• menu.js permalink: https://searchfox.org/mozilla-central/rev/413b88689f3ca2a30b3c49465730c0e7d40f9188/toolkit/content/widgets/menu.js#295

It looks like the key is specified at https://searchfox.org/mozilla-central/rev/413b88689f3ca2a30b3c49465730c0e7d40f9188/browser/components/sessionstore/RecentlyClosedTabsAndWindowsMenuUtils.sys.mjs#316 (as part of bug 1692522, "Temporarily re-introduce keyboard shortcut display in Recently Closed Win/Tab submenu").

... but the patch to bug 1833416 removed the "key_undoCloseTab" key, and renamed it to "key_restoreLastClosedTabOrWindowOrSession".

To solve this, either the patch from bug 1692522 should be undone (if the display is no longer needed), or the code should be adjusted to use the new key id instead.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1833416

:sclements, since you are the author of the regressor, bug 1833416, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Sarah Clements [:sclements]]

Thanks for filing the bug Rob, and doing some investigating.

Mike, do you have any context on bug 1692522 - ie, the intention seems to be that it was temporary? Should I update the key or remove the code added in bug 1692522?

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Hi sclements,

Reading through the comments in bug 1689378 and bug 1692522, I think what happened was as follows:

1. We used to display the keyboard shortcut for undoing the closing of a tab or window on the first item of the Recently Closed Tabs and Recently Closed Windows lists. This was the only place where that shortcut was made known to users.
2. The Proton project in 2021 was a refresh of the browser UI, and involved reorganization across many of Firefox's primary surfaces, including menus. One of that projects remits was to simplify and de-noise as much of our UI as possible. One of the things that ended up on the cutting room floor were the shortcut labels on the first items in those two menus I mentioned.
3. A UI refresh is hard, and given our 4 week release cycle, wasn't something we could do at all at once, so pieces that could be worked on and shipped in advance did so. This included menus.
4. Dao pointed out that the shortcut label that we had removed was the only place that it was displayed to users. He advised that we find a way of putting it back so that people knew that the keyboard shortcut actually existed.
5. UX / Content Design and engineering came up with a compromise that, in the interests of time (all teams were under significant time pressure during Proton), we'd add the keyboard shortcut to the tooltip of the first item in the list. Presumably, the "temporary" was so that UX / Content Design could come back around and come up with something better when they had a chance to breathe.

And I think that's where we are today.

What I suggest is:

1. Let's update the key, so that we get the tooltip working correctly again.
2. Let's reach out to UX / Content Design to see if they have any cycles to think about this again, or if they're happy with the current approach.

Comment 4

[Claas Augner [:claas]]

Attachment: Bug 1868452 - [sessionstore] Fix recently closed tab menu entry key r=gijs

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d64a694f355
[sessionstore] Fix recently closed tab menu entry key r=sclements,sessionstore-reviewers,Gijs

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/2d64a694f355

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:claas, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox132 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-09-28 Nightly build on Windows 10.
Verified as fixed on Firefox Nightly 135.0a1 and Firefox 134.0b1 on Windows 10, Ubuntu 22, macOS 14.