Closed Bug 1693866 Opened 4 years ago Closed 4 years ago

[Proton] in in-content pages menupopups have a big gap to the menulist when they open above the menulist

Categories

(Firefox :: Theme, defect, P1)

defect

Tracking

()

VERIFIED FIXED
88 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox86 --- unaffected
firefox87 --- unaffected
firefox88 --- verified

People

(Reporter: Paenglab, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Keywords: regression, Whiteboard: [proton-context-menus])

Attachments

(1 file)

Attached image menulist-popup-gap.png

In in-content pages like the preferences when a menupopup opens above the menulist there is a big gap between them.

A
xul|menulist > xul|menupopup {
padding: 0;
margin-top: 0;
margin-inline-start: 0;
}

in common.css would fix this issue together with the too narrow menupopup.

See Also: → 1693610, 1693659

The same issue affects other menus, and the suggested fix in comment #0 doesn't help there. The real fix here is bug 1692081 and fixing the positioning in native code.

(In reply to Richard Marti (:Paenglab) from comment #0)

xul|menulist > xul|menupopup {
padding: 0;
margin-top: 0;
margin-inline-start: 0;
}

in common.css would fix this issue together with the too narrow menupopup.

This removes the box-shadow around the menupopup completely, so I don't think we want to do that.

Depends on: 1692081
Severity: -- → S2
Keywords: regression
Priority: -- → P2
Whiteboard: [proton-context-menus]
Priority: P2 → P1
Depends on: 1699427

Fixed by bug 1699427

Assignee: nobody → gijskruitbosch+bugs
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch

Reproduced the initial issue using old Nightly from 2021-02-19, verified that this is indeed fixed on Latest Nightly 88.0a1.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: