Closed Bug 1699410 Opened 3 years ago Closed 3 years ago

Screenshots are cropped when custom firefox scale is used

Categories

(Firefox :: Screenshots, defect, P2)

Product:
Firefox
Component:
Screenshots
Version:
78 Branch
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox86 --- wontfix
firefox87 --- wontfix
firefox88 --- wontfix
firefox89 --- wontfix
firefox90 --- fixed

People

(Reporter: TheProfosist, Assigned: emmamalysz, NeedInfo)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(4 files)

2021-03-18 06_44_41-Enter A Bug — Firefox Nightly.png
565.59 KB, image/png
Details
Screenshot_2021-03-19 Enter Bug Core(2).png
242.85 KB, image/png
Details
Bug 1699410: factor in zoom value when taking a screenshot
48 bytes, text/x-phabricator-request
Details | Review
2021-03-21 03_13_52-Settings.png
32.38 KB, image/png
Details

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

Attempted to take a "save visible" screenshot with display scaling set to 175% on a 4K monitor

Actual results:

the images come out cropped. this happens with everything except "full page"

Expected results:

the correct thing I screenshot should come out not cropped

The Bugbug bot thinks this bug should belong to the 'Firefox::Screenshots' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: Untriaged → Screenshots
Severity: -- → S4
Priority: -- → P2
Summary: Screenshots are cropped when using monitor scaling → Screenshots are cropped when custom scale
Summary: Screenshots are cropped when custom scale → Screenshots are cropped when custom scale is used

Hi,
I tried to reproduce this issue on my machine Win 10x64 with display scaling set to 175% on a 4K monitor on Fx 78.8.0 ESR and Fx Release 86.0.1, but my screenshot comes out not cropped. Please see attachment.

Please test if the issue occurs in safe mode. Here is a link that can help you do that:
https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode

If the issue still persists, please test it using a new profile, you can find the steps to do that below:
https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles?redirectlocale=en-US&redirectslug=Managing-profiles#w_starting-the-profile-manager

Flags: needinfo?(TheProfosist)
Assignee: nobody → emalysz
Status: UNCONFIRMED → ASSIGNED
status-firefox86: --- → wontfix
status-firefox87: --- → wontfix
status-firefox88: --- → affected
status-firefox89: --- → affected
status-firefox-esr78: --- → unaffected
Ever confirmed: true
Keywords: regression
Regressed by: 1664444
Has Regression Range: --- → yes

I have double-checked in Firefox 89a1 in multiple profiles and it is still and issue. If I take a window and move it around between monitors the screen shots are more cropped/zoomed in on the panels with higher scaling. The real issue is if I say save visible or use a crop it doesnt actually save what I have selected.

Maybe it is more specific to my setup as I run multiple monitors with different scaling across multiple graphics cards.

1 - 750 Ti - 1920x1200 - 100% - Portrait
2 - 750 Ti - 1920x1080 - 100% - Landscape
3 - 2080 Ti - 3840x2160 - 125% - Landscape
4 - 2080 Ti - 3840x2160 - 125% - Landscape
5 - 2080 Ti - 3840x2160 - 175% - Portrait

Flags: needinfo?(TheProfosist)

When does thing problem fixed? It's quite hard to screenshoot the pages over time, because of zooming text. Thank you

Sam do you think you can get to this review soon?

Flags: needinfo?(sfoster)

(In reply to Julien Cristau [:jcristau] from comment #12)

Sam do you think you can get to this review soon?

This was caught up in some exploratory work by by prospective interns, but I think that is settled now and I'll get this back in my queue so we can try to land it

Flags: needinfo?(sfoster)

I'm going to file a separate bug for the issue mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=1699410#c8. See Bug 1711101.

The patch for this bug will resolve the issue with a firefox zoom value

Summary: Screenshots are cropped when custom scale is used → Screenshots are cropped when custom firefox scale is used
Pushed by emalysz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c5cf5c19840c
factor in zoom value when taking a screenshot r=sfoster

https://hg.mozilla.org/mozilla-central/rev/c5cf5c19840c

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

The patch landed in nightly and beta is affected.
:emalysz, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(emalysz)
status-firefox89: affected → wontfix
Flags: needinfo?(emalysz)

This bug is still with me in FF 90 and FF 91.0b1. :/

(In reply to Frederik Bovendeerd from comment #19)

This bug is still with me in FF 90 and FF 91.0b1. :/

Confirmed on Windows 10 64 bit 90.0 that released today 64bit.

Does it really fixed on 90? Why I still has problem like Fredik mentioned?

Flags: needinfo?(emalysz)

(In reply to Benyamin Limanto from comment #20)

Confirmed on Windows 10 64 bit 90.0 that released today 64bit.
Does it really fixed on 90? Why I still has problem like Fredik mentioned?
Thanks for confirming that it is not just me AND for putting that little flag "up"!
Totally overlooked that option.

Also excuse the mess I made of my reply. sigh

I was unable to reproduce this error. Can either of you provide STR?

I want to call out this is specifically the Firefox zoom level (displayed in the right-hand corner of the url bar). What this bug aimed to fix was going to a webpage, modifying the Firefox zoom level, and ensuring the resulting screenshot is correct.

Perhaps the issue you are seeing is Bug 1711101, which pertains to the device scale value.

Flags: needinfo?(emalysz)

Thanks for getting back to me/us!
My original bug report was closed by you a while ago as a duplicate of this one:
https://bugzilla.mozilla.org/show_bug.cgi?id=1700736

My issue is specifially referring to the FF zoom, in my case zooming in using the mouse wheel.
I do not use any scaling on OS level.

Also I could probably provide STR but I don't know what that is! :)

Flags: needinfo?(emalysz)

(In reply to Emma Malysz from comment #23)

I was unable to reproduce this error. Can either of you provide STR?

I want to call out this is specifically the Firefox zoom level (displayed in the right-hand corner of the url bar). What this bug aimed to fix was going to a webpage, modifying the Firefox zoom level, and ensuring the resulting screenshot is correct.

Perhaps the issue you are seeing is Bug 1711101, which pertains to the device scale value.

Does this only work for full webpages? Or some part of the webpages, because the title state when zoom only on text, I presume it for both all webpage and some part of it. I tried on full webpage, it works, just when it's only some part it's not. I did scale up til 150% text only. It still cropped when some part of webpage is croped

There are still problems when I test using the keyboard shortcut Ctrl+Shift+S. However, I get better results using the right-click context menu item Take Screenshot. I don't claim to understand the code, but it seems the zoom level is only stored if the extension was invoked with a context menu click. See:

(If you switch between the shortcut and the menu, results are confusing, so for testing, you can reset the zoom level to 100% then use the context menu to store that value for the site, then increase/decrease the zoom, then test the shortcut to see the discrepancy.)

With that in mind:

(A) Standard scale -- you can simulate by setting layout.css.devPixelsPerPx to 1.0 for 100% (for Retina, double it)

(1) No page zoom applied: [no fix was needed]

(2) Page zoom applied (proportional zoom / full zoom)

  • SHORTCUT: full page still incorrect (truncated for zoom-in, padded for zoom-out); save visible and selection are working
  • MENU: all fixed!

(3) Text-only page zoom applied

  • SHORTCUT: all still incorrect (truncated for zoom-in, padded for zoom-out)
  • MENU: full page good; save visible and selection still incorrect (truncated for zoom-in, padded for zoom-out)

(B) Custom scale -- you can simulate by setting layout.css.devPixelsPerPx to 1.5 for 150% (for Retina, double it)

(1) No page zoom applied: fixed!

(2) Page zoom applied (proportional zoom / full zoom)

Problems remain; more testing would be useful

(3) Text-only page zoom applied

Problems remain; more testing would be useful

(In reply to jscher2000 from comment #26)

There are still problems when I test using the keyboard shortcut Ctrl+Shift+S. However, I get better results using the right-click context menu item Take Screenshot. I don't claim to understand the code, but it seems the zoom level is only stored if the extension was invoked with a context menu click.

I am getting the exact same incorrect results using all possible ways to start the process of taking a screenshot.
Ctrl+Shift+S, the right-click context menu as well as the scissors icon in the toolbar:
All of them produce overly zoomed, cropped screenshots.

Interestingly "save full page" is working correctly, "save visible" and picking a specific area by selecting it do not work correctly, just as Benyamin describes.

Thanks! I've filed follow up bugs:

  1. Bug 1721105 to take into account the screenshots shortcut
  2. Bug 1721198 to handle the mouse zoom feature
  3. Bug 1721200 to ensure the zoom factor is not just for save full page (a more recent regression)
Flags: needinfo?(emalysz)

Hello, is there any update on this Ms. Emma. The bug still persist if zoom text only activated. Or there're some other bug blocking ? Thank you

Hello everyone, just looking for any updates here.

Personally, on different OS (with same Firefox version 89.0.1), I am still experiencing this annoying bug where I cannot save/take an entire full page screenshot if there is any zoom applied to the webpage. - In particular the result is always out of scale or cropped.

Is there any fixing on the way? Is anyone following this?
Thank you

(In reply to Frederik Bovendeerd from comment #27)

Interestingly "save full page" is working correctly, "save visible" and picking a specific area by selecting it do not work correctly, just as Benyamin describes.

To me it is exactly the opposite without zoom everything works great, but if any zoom is applied to the page then the "save visible" works great and "save full page" crop the final result.
I can tell that the cropping start from the lower bottom right corner of the page, based on the zoom applied this crop can be minimal or huge. Honestly even with an easy 120% or 133% zoom-in the crop is enough to not entirely present the content correctly.

Hi Steo, this bug was fixed in Firefox 90 and since Firefox 89 is no longer supported, your version is not going to be fixed. If you are having a problem with a currently supported release of Firefox --

  • Firefox 94 or later
  • Firefox 91.3.0esr

-- you can file a new bug about that specific behavior.

If something is holding you back from updating, you can ask for help on Mozilla Support, https://support.mozilla.org/

As others have pointed out, this bug is absolutely not fixed in current Firefox versions, and I don't understand how it could have been marked as closed. At least, it is certain that screenshots in Firefox 94 are utterly broken, just as they have been in all versions since 86.

Note that there is a whole mess of different problems under the general umbrella of "screenshots are completely broken since Firefox 86", depending on whether using "zoom text only" or not, and depending on how the screenshot region is selected: so maybe the person who closed it thought they had fixed things because they had fixed one particular combination, but the general mess remains.

This needs to be fixed correctly, i.e., under every combination of zoom level, "zoom text only" setting or not, and screenshot region selected (specific element, mouse-selected, full document or visible). At the present moment, it is not at all fixed.

So what would be the correct procedure? Reopen this bug, or file a new one?

(In reply to David A. Madore from comment #33)

Note that there is a whole mess of different problems under the general umbrella of "screenshots are completely broken since Firefox 86", depending on whether using "zoom text only" or not, and depending on how the screenshot region is selected: so maybe the person who closed it thought they had fixed things because they had fixed one particular combination, but the general mess remains.

Just want to second this.
I have given up on filing any report on this because what appears to be one massive bug has been split up into several tiny, very specific use-case bugs when in fact, I have not been able to take a proper screenshot since FF86.
It might work some way or the other, but all "my" use-cases still come out cropped / blown up instead.

Flags: needinfo?(emmamalysz)

We are aware of existing bugs with scaling. I get that it can be frustrating when one case is fixed but not the others. But commenting on a closed bug isn't going to help. If you don't see your cases covered by an open bug, please file a new one.

Flags: needinfo?(emmamalysz)

(In reply to Sam Foster [:sfoster] (he/him) from comment #35)

We are aware of existing bugs with scaling. I get that it can be frustrating when one case is fixed but not the others. But commenting on a closed bug isn't going to help. If you don't see your cases covered by an open bug, please file a new one.

Sadly the bug I created way back was merged with others and then closed although the issue still exists.
https://bugzilla.mozilla.org/show_bug.cgi?id=1700736

(In reply to Sam Foster [:sfoster] (he/him) from comment #35)

We are aware of existing bugs with scaling. I get that it can be frustrating when one case is fixed but not the others. But commenting on a closed bug isn't going to help. If you don't see your cases covered by an open bug, please file a new one.

I'm just commenting to ask what the correct procedure is. I had filed bug #1702313 for a specific case (when page is zoomed in "zoom text only" mode), it got closed-merged into this one, but it was never ever fixed. So should I:

  • reopen bug #1702313,

  • reopen this one,

  • or file a brand new one, which could be verbatim identical to bug #1702313 because nothing has changed?

What is the correct course of action here?

Let's reopen bug 1702313. Thanks for asking.

I re-opened bug 1700736, which I think describes the same issue?

This one should be reopened. It is not fixed in latest stable builds (FF95).

I'm also still experiencing this issue on Linux (FF 99.0) on two systems (one triple-head, one single-head, so this is not covered by bug 1711101). Neither of them use Zoom text only, so this is not bug 1700736 either.

For me, the issue is reversed because I prefer to view at Default Zoom 90%. When I take a screenshot without first bumping zoom back to 100%, I get transparent regions to the right and bottom of the image, filling the space that 100% zoom would have consumed.

Blocks: 1753269

Having this issue on Firefox 99.0.1 (64-bit), 1080p monitor.
Full-page screenshots are fine. Screenshots taken with "save visible" or taken via making a selection are cropped significantly. Seem to be a relation issue to the following;

https://old.reddit.com/r/firefox/comments/ceqzuc/screenshot_quality_has_suddenly_decreased/

https://github.com/mozilla-services/screenshots/issues/5387

(In reply to Ren from comment #42)

Having this issue on Firefox 99.0.1 (64-bit), 1080p monitor.

If you are able to reproduce the problem with Nightly, can you file a new bug for this? We recently landed a few changes that should have fixed any remaining zoom and scaling-related issues.

Flags: needinfo?(awsomebot)

This must be the most persistent and most annoying bug I have ever encountered.
I have not been able to use the screenshot feature for over a year now, so yeah... this one is still happening in 100.0b9:
https://bugzilla.mozilla.org/show_bug.cgi?id=1700736

(In reply to Sam Foster [:sfoster] (he/him) from comment #43)

(In reply to Ren from comment #42)

Having this issue on Firefox 99.0.1 (64-bit), 1080p monitor.

If you are able to reproduce the problem with Nightly, can you file a new bug for this?

Thank you for your reply. I can confirm that this bug does not happen on Nightly build 101.0a1 (2022-04-22) (64-bit)

So there's hope!

If you are able to reproduce the problem with Nightly, can you file a new bug for this?

Thank you for your reply. I can confirm that this bug does not happen on Nightly build 101.0a1 (2022-04-22) (64-bit)

Sorry, it seems I spoke too soon.
It appears the issue has to do with my personal set-up of Firefox, as the bug started happening again as soon as I transferred my Firefox profile from the regular build to the Nightly build.
I've done some tests and I don't think the issue is to do with my add-ons. It persists on Firefox's incognito mode (with no add-ons enabled) and when I install the same add-ons on Nightly, it can do screenshots fine with no issues.
The issue only starts happening when I transfer my prefs.js file to Nightly's profile folder. I'll look into it further.

Flags: needinfo?(awsomebot)

(In reply to Frederik Bovendeerd from comment #44)

This must be the most persistent and most annoying bug I have ever encountered.
I have not been able to use the screenshot feature for over a year now, so yeah... this one is still happening in 100.0b9:
https://bugzilla.mozilla.org/show_bug.cgi?id=1700736

Ah yes thanks for that clarification. The "zoom text only" issue is its own special case, so I spoke too soon in saying all scaling/zoom related issues should be fixed. Lets continue to track that in bug 1700736.

(In reply to Ren from comment #47)

It appears the issue has to do with my personal set-up of Firefox, as the bug started happening again as soon as I transferred my Firefox profile from the regular build to the Nightly build.
I've done some tests and I don't think the issue is to do with my add-ons. It persists on Firefox's incognito mode (with no add-ons enabled) and when I install the same add-ons on Nightly, it can do screenshots fine with no issues.
The issue only starts happening when I transfer my prefs.js file to Nightly's profile folder. I'll look into it further.

Can you see if you also have the "Zoom text only" checkbox checked on about:preferences#general? I suspect this is bug 1700736.

Flags: needinfo?(awsomebot)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: