1699410 - Screenshots are cropped when custom firefox scale is used

Status: RESOLVED FIXED

(Firefox :: Screenshots, defect, P2)

Description

[TheProfosist]

Attachment: 2021-03-18 06_44_41-Enter A Bug — Firefox Nightly.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

Attempted to take a "save visible" screenshot with display scaling set to 175% on a 4K monitor

Actual results:

the images come out cropped. this happens with everything except "full page"

Expected results:

the correct thing I screenshot should come out not cropped

Comment 1

[Release mgmt bot [:sylvestre / :calixte / :marco for bugbug]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Screenshots' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 3

[Ralu]

Attachment: Screenshot_2021-03-19 Enter Bug Core(2).png

Comment 4

[Ralu]

Hi,
I tried to reproduce this issue on my machine Win 10x64 with display scaling set to 175% on a 4K monitor on Fx 78.8.0 ESR and Fx Release 86.0.1, but my screenshot comes out not cropped. Please see attachment.

Please test if the issue occurs in safe mode. Here is a link that can help you do that:
https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode

If the issue still persists, please test it using a new profile, you can find the steps to do that below:
https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles?redirectlocale=en-US&redirectslug=Managing-profiles#w_starting-the-profile-manager

Comment 5

[Emma Malysz]

Attachment: Bug 1699410: factor in zoom value when taking a screenshot

Comment 8

[TheProfosist]

Attachment: 2021-03-21 03_13_52-Settings.png

I have double-checked in Firefox 89a1 in multiple profiles and it is still and issue. If I take a window and move it around between monitors the screen shots are more cropped/zoomed in on the panels with higher scaling. The real issue is if I say save visible or use a crop it doesnt actually save what I have selected.

Maybe it is more specific to my setup as I run multiple monitors with different scaling across multiple graphics cards.

1 - 750 Ti - 1920x1200 - 100% - Portrait
2 - 750 Ti - 1920x1080 - 100% - Landscape
3 - 2080 Ti - 3840x2160 - 125% - Landscape
4 - 2080 Ti - 3840x2160 - 125% - Landscape
5 - 2080 Ti - 3840x2160 - 175% - Portrait

Comment 11

[Benyamin Limanto]

When does thing problem fixed? It's quite hard to screenshoot the pages over time, because of zooming text. Thank you

Comment 12

[Julien Cristau [:jcristau]]

Sam do you think you can get to this review soon?

Comment 13

[Sam Foster [:sfoster] (he/him)]

(In reply to Julien Cristau [:jcristau] from comment #12)

Sam do you think you can get to this review soon?

This was caught up in some exploratory work by by prospective interns, but I think that is settled now and I'll get this back in my queue so we can try to land it

Comment 14

[Emma Malysz]

I'm going to file a separate bug for the issue mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=1699410#c8. See Bug 1711101.

The patch for this bug will resolve the issue with a firefox zoom value

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5cf5c19840c
factor in zoom value when taking a screenshot r=sfoster

Comment 17

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/c5cf5c19840c

Comment 18

[Release mgmt bot [:sylvestre / :calixte / :marco for bugbug]]

The patch landed in nightly and beta is affected.
:emalysz, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.