Closed Bug 1702000 Opened 2 months ago Closed 1 month ago

Add pin to taskbar action to the primary button

Categories

(Firefox :: Messaging System, enhancement, P2)

enhancement

Tracking

()

VERIFIED FIXED
89 Branch
Iteration:
89.2 - Apr 5 - Apr 18
Tracking Status
firefox89 --- verified
firefox90 --- verified

People

(Reporter: andreio, Assigned: andreio)

References

Details

(Whiteboard: [proton-modals][proton-onboarding])

Attachments

(2 files)

We want the primary button for the default browser prompt to pin + set to default similar to the new onboarding experience.

Severity: -- → S3
Priority: -- → P2

Andrei, note that Meridel just now worked on refreshed copy to reflect the 2 behaviors.

Can you confirm that we can display the different copy only for the windows versions where the pinning is relevant? (And for Mac and Linux where pinning is not a thing)

(see attached image)

Yes we can do the updated design.

Assignee: nobody → andrei.br92
Attachment #9214361 - Attachment description: WIP: Bug 1702000 - Add pin to taskbar action to the primary button → Bug 1702000 - Add pin to taskbar action to the primary button r?andreio
Pushed by elee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d39717cd014e
Add pin to taskbar action to the primary button r=andreio

Backed out for causing mochitest browser-chrome failures in browser_aboutNewTab_defaultBrowserNotification

Backout link: https://hg.mozilla.org/integration/autoland/rev/a0d25dda4dd71d33d777fc940b817861f0b6daa1

Push with failures

Failure log

Flags: needinfo?(andrei.br92)

(In reply to Sandor Molnar from comment #6)

Backed out for causing mochitest browser-chrome failures in browser_aboutNewTab_defaultBrowserNotification

Looks like ./mach try autochooser happened to pick tests that were skipped:

    This test gets skipped with pattern: debug || asan || tsan || ccov || verify
Flags: needinfo?(andrei.br92)
Pushed by elee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c4e724c8d98b
Add pin to taskbar action to the primary button r=andreio
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Iteration: --- → 89.2 - Apr 5 - Apr 18
QA Whiteboard: [qa-89b-p2]
Whiteboard: [proton-modals][proton-onboarding]

We've verified the fix on the latest Nightly 90.0a1 (20210510160229) and on Beta 89.0b10 (20210509185840), but the icon does not remain pinned to taskbar after setting the browser as default. We've performed the testing on Windows 10x64 version 20H2.
I mention that on Windows 10x64 version 20H1 it works.

@Andrei, can you please take a look at this?

Flags: needinfo?(andrei.br92)

Did the prompt say "primary" or "default" when the icon didn't remain pinned? It should only say "primary" if Firefox can be pinned and is unpinned. Potentially it can't be pinned if it's not installed, e.g., run from an unzipped folder. Also just checking, when it fails to pin (you should be able to verify by opening the context menu on the taskbar icon to see if it offers to "pin" vs "unpin"), does about:welcome also show "default" vs "primary" and also fails to pin?

Flags: needinfo?(andrei.br92) → needinfo?(giorgia.moldovan)

You are right, I was running Firefox from unzipped folders and the prompt said only "default". Thanks for the information and shedding some light on this :)

I was able to verify the fix using the latest Nightly 90.0a1 (2021-05-11) and Firefox 89.0b9 (2021-05-06) on Windows 10x64. Also, I’ve checked that the modals are correctly displayed as per comment 2, on macOS 10.15 and Ubuntu 20.04x64.

Status: RESOLVED → VERIFIED
Flags: needinfo?(giorgia.moldovan)
You need to log in before you can comment on or make changes to this bug.