1702645 - favicon's red crash badge is centered in the favicon instead of the upper right corner (regression in Firefox 88)

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P2)

Description

[Chris Peterson [:cpeterson]]

Attachment: Firefox_87_screenshot.jpg

Steps to reproduce

1. In 88 Beta or 89 Nightly, open a page with a prominent favicon, such as https://news.ycombinator.com/.
2. Enter about:crashcontent in the address bar.

Expected result

The favicon's red crash badge should be positioned in the upper right corner of the favicon.

Actual result

The favicon's red crash badge is centered in the favicon. See the attached before/after screenshots. This crash badge bug is reproducible with or without any Photon prefs enabled. I bisected this regression to this pushlog:

This is a regression from Photon tab audio indicator bug 1693066:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=9a7dd526e56ca6c9c5a022a1aa74fa97dbc522ba&tochange=9afd696ad2b4d6050828a59306c27a9bff724dbc

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Firefox_88_screenshot.jpg

Here is a screenshot of the regression in Firefox 88 Beta.

Comment 2

[Pascal Chevrel:pascalc]

dao, this is a regression caused by proton work, do we care about it for 89? Thanks

Comment 4

[Dão Gottwald [:dao]]

Attachment: Bug 1702645 - Properly position crashed badge. r=sfoster

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d9e57c70a9b
Properly position crashed badge. r=tabbrowser-reviewers,mak

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/6d9e57c70a9b

Comment 8

[Dana Lucaci, Desktop QA]

Reproduced the issue with Firefox 89.0a1 (2021-04-01) on macOS 14.
The issue is verified fixed with Firefox 131.0a1 (20240807215007) and Firefox 130.0b2 (20240807091924) onWindows 10, macOS 14 and Ubuntu 22.