1909843 - Tabs without favicons don't look right in the vertical tabstrip

Status: VERIFIED FIXED

(Firefox :: Sidebar, defect)

Description

[:Gijs (he/him)]

STR:

1. open data:text/html, as a tab

ER:

Be able to see it (with a default favicon, probably) in the tabstrip

AR:

Blank space (though the hover effect shows something is there)

(I did search to see if this was on file already but didn't see anything - please dupe if this is already a known issue.)

Comment 1

[:Gijs (he/him)]

So I guess this is part-caused by me applying the in-progress patch from bug 1899336 - but even without that patch the tab doesn't look right. Instead of the blank space in the example from comment 0 it will show "data..." faded out. It should show the default favicon instead (like pinned tabs in the horizontal tabstrip).

Comment 2

[Sarah Clements [:sclements]]

Thanks for this, it was because a rule wasn't applying correctly in vertical tabs mode.

Comment 3

[Sarah Clements [:sclements]]

Attachment: Bug 1909843 - Vertical tab fixes r=#tabbrowser-reviewers

• Fix rule to show favicon when icons are missing
• Fix typo name change that affects unpinning tabs
• Fix padding issue for arrowscrollbox that affects alignment

Comment 4

[Sarah Clements [:sclements]]

This patch is addressing the issue with filed in bug 1910576, where tabbrowser.js needs to check tabContainer.verticalMode rather than tabContainer.inVerticalTabsMode.

Edit: This change got pulled out into bug 1910576 after all.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06914b4eaad0
Vertical tab fixes r=tabbrowser-reviewers,desktop-theme-reviewers,dao

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/06914b4eaad0

Comment 8

[Ina Popescu, Desktop QA]

I've replicated this issue using Nightly 130.0a1 (2024-07-25) on Windows 10 x64 following the STR from Comment 0. When a website doesn't provide a corresponding favicon, the title of the page is displayed in the tab.
Verified as fixed in the latest Firefox 131.0b8 and Nightly 132.0a1 versions on Windows 10 x64, macOS 13, and Ubuntu 22.04. In the latest versions,, if a website doesn't provide a corresponding favicon, a default global favicon is displayed in tab.