1703382 - [Proton] Broken notifications with Proton enabled

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Alessandro Castellani [:aleca]]

Attachment: Screenshot from 2021-04-06 14-23-11.png

I'm not sure if this should be in Upstream Synchronization or Theme.

I put this in theme because other than the obvious issue of multiple notifications not stacking properly, it highlighted an issue with the message header.
The <table> containing the Subject line grows vertically and center aligns the subject text but not the label.
The subject text should remain with a regular alignment like the label.

To easily recreate this issue you can save a draft with an embedded remote image.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: image.png

Is this bug too for the issues in attachment reminder and the not showing dropmarker and popup in the remote blocked info bar?

M-C is planning to enable the info bars directly with browser.proton.enabled, see bug 1702330.

Comment 2

[Richard Marti (:Paenglab)]

M-C is working hard on bug 1702330 to remove the browser.proton.infobars.enabled and convert it into browser.proton.enabled. When this happens and this bug isn't fixed we get a defective UI with the infobars and need then to disable browser.proton.enabled completely.

Magnus, do you have somebody that can work on this bug?

Comment 3

[Magnus Melin [:mkmelin]]

I don't see the original bug on trunk. I guess it's because you enabled browser.proton.infobars.enabled? I don't see the problems of comment 1 either. If the box shows more than one notification that may be a toolkit bug.

Aleca, since you've done a lot on our notification bars, please take a look at what might be needed here.

Comment 4

[Alessandro Castellani [:aleca]]

I'll take care of it!

Comment 5

[Magnus Melin [:mkmelin]]

The m-c bug got backed out, but the c-c run for it had plenty of failures (I think due to different notification structure): https://treeherder.mozilla.org/jobs?repo=comm-central&selectedTaskRun=CrYGtxSfTG2fqr2kk_816A.0&revision=01b42daa8a2675fd108dcfd4873dd75970425e2c

Comment 6

[Richard Marti (:Paenglab)]

Attachment: 1703382-moz-proton-infobars-remove.patch

The -moz-proton-infobars media query is no more used and converted to -moz-proton.
This patch converts it too in the CSS files.

Alessandro, it's up to you if we land this patch separate or you integrate it into your patch.

Comment 7

[Magnus Melin [:mkmelin]]

Bug 1702330 landed again. Will disable proton for now so the tree won't light up too much.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/043fcd28a89f
disable proton theme - bug 1702330 landing breaks many tests. rs=bustage-fix

Comment 9

[Richard Marti (:Paenglab)]

Comment on attachment 9214954 [details] [diff] [review]
1703382-moz-proton-infobars-remove.patch

Patch is no more needed. Geoff landed the same.

Comment 10

[Alessandro Castellani [:aleca]]

Attachment: Bug 1703382 - Adapt the notification box styles to the new Proton UI. r=mkmelin, ui-r=Paenglab

Comment 11

[Alessandro Castellani [:aleca]]

I updated the description and the scope of this bug as the Proton style changed the markup and hierarchy of accessible child of the notification element, breaking pretty much every notification bar we use, as well as all the tests.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3ff4d1fa2589
Adapt the notification box styles to the new Proton UI. r=mkmelin, ui-r=Paenglab