1703957 - Ensure dark/light theme manifest properties match default theme dark/light mode properties for Proton

Status: VERIFIED FIXED

(Firefox :: Theme, task, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

Unintuitively, we have both the dark theme, and the default theme with a dark mode (which is triggered by the OS). We should make sure that these two themes match before shipping Proton.

Comment 1

[Sören Hentzschel]

Is there a similar bug for the the light theme? The light theme and the default theme with the "light/default mode" from the OS are almost the same but there are at least two differences.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Might as well do it at the same time, I guess.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1703957 - Colors for dark/light/system/system-dark audited and confirmed consistent.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15e19c4203af
Colors for dark/light/system/system-dark audited and confirmed consistent. r=mconley

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Wiring up dependency to make it clearer what needs to land first before a beta uplift.

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/15e19c4203af

Comment 7

[Alexandru Michis [:malexandru]]

Backed out changeset 15e19c4203af (Bug 1703957) for causing issues with addressbar suggestions (Bug 1707257). a=backout
Backout link: https://hg.mozilla.org/mozilla-central/rev/1241823043e92c9915ed7cae9e71361c652321f4

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8fd0175a750a
Colors for dark/light/system/system-dark audited and confirmed consistent. r=mconley

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9217778 [details]
Bug 1703957 - Colors for dark/light/system/system-dark audited and confirmed consistent.

Beta/Release Uplift Approval Request

• User impact if declined: Required for MR1/Proton.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Colors on UI elements should match those specified on https://www.figma.com/file/0XjasINHogZOxcxSmYfs4i/Colours?node-id=26%3A265
• List of other uplifts needed: Bug 1705849
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): CSS-only changes
• String changes made/needed: none

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8fd0175a750a

Comment 11

[Pascal Chevrel:pascalc]

Comment on attachment 9217778 [details]
Bug 1703957 - Colors for dark/light/system/system-dark audited and confirmed consistent.

Approved for 89 beta 6, thanks.

Comment 12

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/8ba3bea46de2

Comment 13

[Catalin Sasca, QA [:csasca]]

Attachment: Ubuntu 20 themes.webm

Verified that the themes are consistent across Windows 10 and macOS 10.15.7 with Firefox 89.0b8 and 90.0a1 and the expected colors are displayed.

Seems that on Ubuntu 20.04 the themes change a bit from default (OS) and dark/light (see attachment). Is there something to be done here?

Comment 14

[Jared Wein [:jaws] (please needinfo? me)]

Redirecting to Harry as I'm on PTO this week.

Comment 15

[Harry Twyford]

It's expected that Linux system dark and Firefox Dark will be different colors. Linux system dark uses system colors. That way, Firefox windows match other OS windows. Firefox Dark always uses the same colors regardless of system. So this is not a problem for this bug. Similarly, Linux system light and Firefox Light are expected to be slightly different.

With that said, please file bugs if QA finds any specific UI elements that are low-contrast or otherwise hard to see when a using Linux system theme.

Comment 16

[Catalin Sasca, QA [:csasca]]

Thank you for the response Harry. That said we can close this bug as fixed.