1706695 - Proton plus/add (new tab) icon is offset to the right

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P2)

Description

[Dariusz Czajkowski]

Attachment: add.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:89.0) Gecko/20100101 Firefox/89.0

Steps to reproduce:

The plus icon used as a new tab icon (chrome://global/skin/icons/add.svg) is not centered.

This makes it hard to use this icon, including it being off-center on the compact mode.

I am attaching a rasterized version (result of rendering by Firefox) to show the problem.

Comment 1

[Hani Yacoub, Desktop QA]

Managed to reproduce this issue Windows 10 x64, macOS 10.15, Ubuntu 20.04 and on Windows 7 x64.
Might be regressed by Bug 1702285 - Update tabstrip icons for Proton.

Comment 2

[Hani Yacoub, Desktop QA]

Attachment: Navigation button.png

This issue seems to be reproducible also for the navigation buttons (< >) and List all tab button.

Comment 3

[Sam Foster [:sfoster] (he/him)]

The icons are drawn on a 16x16 grid. In order to avoid excessive sub-pixel dithering, the main vertical and horizontal lines are aligned on that grid. This necessarily means that some appear off-center, in some contexts. Where that creates a visible regression, I'd prefer we make adjustments in the CSS rather than the icon itself. This keeps the icons consistent with each other, and avoids "fixing" an alignment or spacing issue in one case, only to break it in others. This one (add.svg) is used in several other places in addition to the tab strip.

Comment 5

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1706695 - Shift + icon paths left 1px to better center it. r?dao

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea13cba25bde
Shift + icon paths left 1px to better center it. r=dao

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/ea13cba25bde

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 9

[Sam Foster [:sfoster] (he/him)]

90 is affected. I'd suggest either fix-optional or wontfix. Uplift would require also uplifting bug 1700124 which renames the image from add.svg to plus.svg. I'm not sure the cost/risk outweighs the gain in this case.

Comment 10

[Pascal Chevrel:pascalc]

Sam, bug 1700124 landed in the 91 cycle so that seems safe to uplist in 91, do you want to request it?

Comment 11

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 9229980 [details]
Bug 1706695 - Shift + icon paths left 1px to better center it. r?dao

Beta/Release Uplift Approval Request

• User impact if declined: "+" is offset/misaligned by 1px
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small change to a single svg file, to move the "+" paths 1 pixel to the left to better center them.
• String changes made/needed: None

Comment 12

[Pascal Chevrel:pascalc]

Comment on attachment 9229980 [details]
Bug 1706695 - Shift + icon paths left 1px to better center it. r?dao

Polish, approved for 91 beta 5, thanks.

Comment 13

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/7a6116732ab2

Comment 14

[Anca Soncutean, Desktop QA]

Reproduced with Fx 89.0 on Windows 10, macOS 11.0, Ubuntu 18.04.
Verified fixed with Fx 92.0a1 (22-06-2021) and Fx 91.0b6 on Windows 10, macOS 11.0, Ubuntu 18.04.